)]}'
{"cinder/tests/unit/image/fake.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed3e10ab4dbb4bc87bcc11398b2f77c5d6c9f5ad","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_remote_image_service\u0027,"},{"line_number":242,"context_line":"                         lambda x, y: (FakeImageService(), y))"},{"line_number":243,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_default_image_service\u0027,"},{"line_number":244,"context_line":"                         lambda: FakeImageService())"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_e8f1e2ce","line":244,"updated":"2016-08-25 10:33:15.000000000","message":"-1: With mock this should be:\n\n testcase.mock_object(cinder.image.glance, \u0027get_default_image_service\u0027,\n                      side_effect\u003dFakeImageService)","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"a81251561822770f2fae6803bd0bcab182b69c72","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_remote_image_service\u0027,"},{"line_number":242,"context_line":"                         lambda x, y: (FakeImageService(), y))"},{"line_number":243,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_default_image_service\u0027,"},{"line_number":244,"context_line":"                         lambda: FakeImageService())"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_58e9e119","line":244,"in_reply_to":"1ac06dbe_e8f1e2ce","updated":"2016-08-26 11:39:37.000000000","message":"Your suggestion does not work. But testcase.mock_object(cinder.image.glance, get_default_image_service\u0027, mock.Mock(side_effect\u003dFakeImageService)) does.","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"abad2c09d1ca06aacce22a9bd414a3683e4b5c38","unresolved":false,"context_lines":[{"line_number":241,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_remote_image_service\u0027,"},{"line_number":242,"context_line":"                         lambda x, y: (FakeImageService(), y))"},{"line_number":243,"context_line":"    testcase.mock_object(cinder.image.glance, \u0027get_default_image_service\u0027,"},{"line_number":244,"context_line":"                         lambda: FakeImageService())"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_6c33e762","line":244,"in_reply_to":"fa7ab95a_58e9e119","updated":"2016-08-29 12:22:41.000000000","message":"OK, our mock_object method doesn\u0027t work as it should.  :-(\n\nI have just submitted a patch to fix it [1] and another to use it in our tests [2], but in the meantime, your solution would be consistent with how we are doing things in other tests.\n\n[1]: https://review.openstack.org/362065\n[2]: https://review.openstack.org/362066","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"}],"cinder/tests/unit/image/test_glance.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed3e10ab4dbb4bc87bcc11398b2f77c5d6c9f5ad","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.service \u003d self._create_image_service(client)"},{"line_number":104,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, auth_token\u003dTrue)"},{"line_number":105,"context_line":"        self.context.service_catalog \u003d service_catalog"},{"line_number":106,"context_line":"        self.mock_object(glance.time, \u0027sleep\u0027, lambda s: None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _create_image_service(self, client):"},{"line_number":109,"context_line":"        def _fake_create_glance_client(context, netloc, use_ssl, version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_c88b4667","line":106,"updated":"2016-08-25 10:33:15.000000000","message":"-1: Using mock this should be:\n\n self.mock_object(glance.time, \u0027sleep\u0027, return_value\u003dNone)","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"a81251561822770f2fae6803bd0bcab182b69c72","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        self.service \u003d self._create_image_service(client)"},{"line_number":104,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, auth_token\u003dTrue)"},{"line_number":105,"context_line":"        self.context.service_catalog \u003d service_catalog"},{"line_number":106,"context_line":"        self.mock_object(glance.time, \u0027sleep\u0027, lambda s: None)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _create_image_service(self, client):"},{"line_number":109,"context_line":"        def _fake_create_glance_client(context, netloc, use_ssl, version):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_58d3a138","line":106,"in_reply_to":"1ac06dbe_c88b4667","updated":"2016-08-26 11:39:37.000000000","message":"Your suggestion does not work. But self.mock_object(glance.time, \u0027sleep\u0027, mock.Mock(return_value\u003dNone)) does.","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ed3e10ab4dbb4bc87bcc11398b2f77c5d6c9f5ad","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    def setUp(self):"},{"line_number":875,"context_line":"        super(TestGlanceImageServiceClient, self).setUp()"},{"line_number":876,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, auth_token\u003dTrue)"},{"line_number":877,"context_line":"        self.mock_object(glance.time, \u0027sleep\u0027, lambda s: None)"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"    def test_create_glance_client(self):"},{"line_number":880,"context_line":"        self.flags(auth_strategy\u003d\u0027keystone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_4844761a","line":877,"updated":"2016-08-25 10:33:15.000000000","message":"ditto","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"a81251561822770f2fae6803bd0bcab182b69c72","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    def setUp(self):"},{"line_number":875,"context_line":"        super(TestGlanceImageServiceClient, self).setUp()"},{"line_number":876,"context_line":"        self.context \u003d context.RequestContext(\u0027fake\u0027, \u0027fake\u0027, auth_token\u003dTrue)"},{"line_number":877,"context_line":"        self.mock_object(glance.time, \u0027sleep\u0027, lambda s: None)"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"    def test_create_glance_client(self):"},{"line_number":880,"context_line":"        self.flags(auth_strategy\u003d\u0027keystone\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_d8e7b110","line":877,"in_reply_to":"1ac06dbe_4844761a","updated":"2016-08-26 11:39:37.000000000","message":"ditto","commit_id":"f0493c35a35ae8c34d77efe55d4fd49923eaef25"}]}