)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"27cde01e88589034de0e3497794d34369ab0ff0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 11:28:50 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py (end)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases that"},{"line_number":10,"context_line":"use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_748c08da","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":33},"updated":"2016-08-24 08:06:58.000000000","message":"nit: (2/2)","commit_id":"a0b617176f113b9b1f755508b1c602dacac630ce"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"0e4837558ad01de9dc9d53960826e98adfdc1a39","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 11:28:50 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py (end)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases that"},{"line_number":10,"context_line":"use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_25f25c06","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":33},"in_reply_to":"1ac06dbe_748c08da","updated":"2016-08-24 08:36:30.000000000","message":"Done","commit_id":"a0b617176f113b9b1f755508b1c602dacac630ce"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"27cde01e88589034de0e3497794d34369ab0ff0a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Replaced mox with mock and stubs.Set() with mock_object() in"},{"line_number":13,"context_line":"some classes in cinder/tests/unit/."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The remaining files are fixed in another patch set at:"},{"line_number":16,"context_line":"https://review.openstack.org/#/c/357648/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2f77d3dc9d09cdaf88be6f8e1b0894e7548ea2e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_54758cc8","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":40},"updated":"2016-08-24 08:06:58.000000000","message":"nit: There\u0027s no need to mention it here, this could have gone into a comment in gerrit. And no comment would be necessary if this patch was dependent on the other one.","commit_id":"a0b617176f113b9b1f755508b1c602dacac630ce"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"0e4837558ad01de9dc9d53960826e98adfdc1a39","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Replaced mox with mock and stubs.Set() with mock_object() in"},{"line_number":13,"context_line":"some classes in cinder/tests/unit/."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The remaining files are fixed in another patch set at:"},{"line_number":16,"context_line":"https://review.openstack.org/#/c/357648/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2f77d3dc9d09cdaf88be6f8e1b0894e7548ea2e5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1ac06dbe_a5bdac03","line":16,"range":{"start_line":15,"start_character":0,"end_line":16,"end_character":40},"in_reply_to":"1ac06dbe_54758cc8","updated":"2016-08-24 08:36:30.000000000","message":"Done","commit_id":"a0b617176f113b9b1f755508b1c602dacac630ce"}],"cinder/tests/unit/test_volume.py":[{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"56ed5dea18afabff0e1c16f8a60f34532076bc41","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"            volume_ref \u003d db.volume_get(context.get_admin_context(), volume_id)"},{"line_number":1152,"context_line":"            self.assertEqual(volume_id, volume_ref.id)"},{"line_number":1153,"context_line":"            self.assertEqual(\"available\", volume_ref.status)"},{"line_number":1154,"context_line":"            mock_del_vol.assert_called_once_with(mock.ANY)"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def test_get_volume_different_tenant(self):"},{"line_number":1157,"context_line":"        \"\"\"Test can\u0027t get volume of another tenant when viewable_admin_meta.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_392cd7aa","line":1154,"range":{"start_line":1154,"start_character":54,"end_line":1154,"end_character":57},"updated":"2016-08-16 13:58:37.000000000","message":"It should be mock_del_vol.assert_called_once_with(volume) otherwise it does not check a parameter passed to self.volume.driver.delete_volume(volume)","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"7acf6ec9783fd8dc2a71334d353694bc9b6085a4","unresolved":false,"context_lines":[{"line_number":1151,"context_line":"            volume_ref \u003d db.volume_get(context.get_admin_context(), volume_id)"},{"line_number":1152,"context_line":"            self.assertEqual(volume_id, volume_ref.id)"},{"line_number":1153,"context_line":"            self.assertEqual(\"available\", volume_ref.status)"},{"line_number":1154,"context_line":"            mock_del_vol.assert_called_once_with(mock.ANY)"},{"line_number":1155,"context_line":""},{"line_number":1156,"context_line":"    def test_get_volume_different_tenant(self):"},{"line_number":1157,"context_line":"        \"\"\"Test can\u0027t get volume of another tenant when viewable_admin_meta.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8842b766","line":1154,"range":{"start_line":1154,"start_character":54,"end_line":1154,"end_character":57},"in_reply_to":"3ac371cc_392cd7aa","updated":"2016-08-17 01:42:55.000000000","message":"Done","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"56ed5dea18afabff0e1c16f8a60f34532076bc41","unresolved":false,"context_lines":[{"line_number":3450,"context_line":"            self.assertEqual(snapshot_id, snapshot_ref.id)"},{"line_number":3451,"context_line":"            self.assertEqual(fields.SnapshotStatus.AVAILABLE,"},{"line_number":3452,"context_line":"                             snapshot_ref.status)"},{"line_number":3453,"context_line":"            mock_del_snap.assert_called_once_with(mock.ANY)"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"    @test.testtools.skipIf(sys.platform \u003d\u003d \"darwin\", \"SKIP on OSX\")"},{"line_number":3456,"context_line":"    def test_delete_no_dev_fails(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_04da5278","line":3453,"range":{"start_line":3453,"start_character":50,"end_line":3453,"end_character":54},"updated":"2016-08-16 13:58:37.000000000","message":"mock_del_snap.assert_called_once_with(snapshot)","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"7acf6ec9783fd8dc2a71334d353694bc9b6085a4","unresolved":false,"context_lines":[{"line_number":3450,"context_line":"            self.assertEqual(snapshot_id, snapshot_ref.id)"},{"line_number":3451,"context_line":"            self.assertEqual(fields.SnapshotStatus.AVAILABLE,"},{"line_number":3452,"context_line":"                             snapshot_ref.status)"},{"line_number":3453,"context_line":"            mock_del_snap.assert_called_once_with(mock.ANY)"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"    @test.testtools.skipIf(sys.platform \u003d\u003d \"darwin\", \"SKIP on OSX\")"},{"line_number":3456,"context_line":"    def test_delete_no_dev_fails(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_0857e726","line":3453,"range":{"start_line":3453,"start_character":50,"end_line":3453,"end_character":54},"in_reply_to":"3ac371cc_04da5278","updated":"2016-08-17 01:42:55.000000000","message":"Done","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":14305,"name":"Yuriy Nesenenko","email":"ynesenenko@mirantis.com","username":"yuriy_n"},"change_message_id":"56ed5dea18afabff0e1c16f8a60f34532076bc41","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"            self.assertEqual(snapshot_id, snapshot_ref.id)"},{"line_number":3478,"context_line":"            self.assertEqual(fields.SnapshotStatus.AVAILABLE,"},{"line_number":3479,"context_line":"                             snapshot_ref.status)"},{"line_number":3480,"context_line":"            mock_del_snap.assert_called_once_with(mock.ANY)"},{"line_number":3481,"context_line":""},{"line_number":3482,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":3483,"context_line":"                          self.volume.delete_snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_8462c2ab","line":3480,"range":{"start_line":3480,"start_character":58,"end_line":3480,"end_character":59},"updated":"2016-08-16 13:58:37.000000000","message":"mock_del_snap.assert_called_once_with(snapshot)","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"7acf6ec9783fd8dc2a71334d353694bc9b6085a4","unresolved":false,"context_lines":[{"line_number":3477,"context_line":"            self.assertEqual(snapshot_id, snapshot_ref.id)"},{"line_number":3478,"context_line":"            self.assertEqual(fields.SnapshotStatus.AVAILABLE,"},{"line_number":3479,"context_line":"                             snapshot_ref.status)"},{"line_number":3480,"context_line":"            mock_del_snap.assert_called_once_with(mock.ANY)"},{"line_number":3481,"context_line":""},{"line_number":3482,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":3483,"context_line":"                          self.volume.delete_snapshot,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_e8536b37","line":3480,"range":{"start_line":3480,"start_character":58,"end_line":3480,"end_character":59},"in_reply_to":"3ac371cc_8462c2ab","updated":"2016-08-17 01:42:55.000000000","message":"Done","commit_id":"6634e5e38c7df67e992b487a6fca9a54ac40a8ee"},{"author":{"_account_id":22257,"name":"Manish","email":"deolalkar.manish@hpe.com","username":"manishd"},"change_message_id":"509505dc81f6248d8e7d8b34a8e9754c644147e2","unresolved":false,"context_lines":[{"line_number":4611,"context_line":""},{"line_number":4612,"context_line":"    def test_migrate_volume_driver(self):"},{"line_number":4613,"context_line":"        \"\"\"Test volume migration done by driver.\"\"\""},{"line_number":4614,"context_line":"        # stub out driver and rpc functions"},{"line_number":4615,"context_line":"        self.mock_object(self.volume.driver, \u0027migrate_volume\u0027,"},{"line_number":4616,"context_line":"                         lambda x, y, z, new_type_id\u003dNone: ("},{"line_number":4617,"context_line":"                             True, {\u0027user_id\u0027: fake.USER_ID}))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_c2f50acc","line":4614,"range":{"start_line":4614,"start_character":8,"end_line":4614,"end_character":43},"updated":"2016-08-19 08:57:59.000000000","message":"stub out \u003d Mock","commit_id":"56f02529fc5524adde6b6b8d209ab4090c56c25f"}]}