)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"08884caf83c8f84e3f2afd3a2034584f7100840f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soffie Huang \u003cSoffie.Huang@falconstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-09 10:18:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring FalconStor FSS storage driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_69b4acd0","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":42},"updated":"2016-08-16 20:04:05.000000000","message":"Summary line doesn\u0027t require a \".\" at the EOL","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soffie Huang \u003cSoffie.Huang@falconstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-09 10:18:27 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring FalconStor FSS storage driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_7b23c0a7","line":7,"range":{"start_line":7,"start_character":41,"end_line":7,"end_character":42},"in_reply_to":"3ac371cc_69b4acd0","updated":"2016-08-17 04:34:29.000000000","message":"Done","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fa86c57d32b25d18c40ff65f1baa37aff1db7e9c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_c927a010","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":40},"updated":"2016-08-16 20:01:47.000000000","message":"Can you explain why you are removing this function?","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_7b474077","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":40},"in_reply_to":"3ac371cc_c927a010","updated":"2016-08-17 04:34:29.000000000","message":"The inheritance class changed and the implementation layer at os_brick. FSS is not a NFS storage so we drop it.","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"08884caf83c8f84e3f2afd3a2034584f7100840f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_29e114d1","line":12,"updated":"2016-08-16 20:04:05.000000000","message":"Should have a DocImpact Tag because you are adding a new config option.","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_bb39b8d9","line":12,"in_reply_to":"3ac371cc_29e114d1","updated":"2016-08-17 04:34:29.000000000","message":"Done","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fa86c57d32b25d18c40ff65f1baa37aff1db7e9c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_c96e802e","line":14,"updated":"2016-08-16 20:01:47.000000000","message":"You need to add the DocImpact tag as you are adding a new option.","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3ac371cc_5b4fe46a","line":14,"in_reply_to":"3ac371cc_c96e802e","updated":"2016-08-17 04:34:29.000000000","message":"Done","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"964634a2422fb8bd3008bc687eb28f0aca35285e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"},{"line_number":15,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3ac371cc_8ae60113","line":14,"updated":"2016-08-17 16:26:42.000000000","message":"We need two bug reports with some more details in the bug description. Also, it is better to have two patches.","commit_id":"b635fb4cc074f78e9007d3c13392a0ab3bca7c28"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"30084c923d3d4fe40189f4cab20968bf20046279","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soffie Huang \u003cSoffie.Huang@falconstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 06:17:04 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactoring FalconStor FSS storage driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_3859e38e","line":7,"updated":"2016-08-18 14:18:36.000000000","message":"nit: this is not refactoring.\n\nThe following may be a better commit summary:\n\"FalconStor: Restore option \u003coption_name\u003e\"","commit_id":"1182350770f75972e7369115087939a6b278049b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"30084c923d3d4fe40189f4cab20968bf20046279","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactoring FalconStor FSS storage driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_389e0307","line":10,"updated":"2016-08-18 14:18:36.000000000","message":"We should also briefly mention what is the issue. In this case, it is better to mention the commit ID which accidentally removed this option.","commit_id":"1182350770f75972e7369115087939a6b278049b"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"30084c923d3d4fe40189f4cab20968bf20046279","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":14,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3ac371cc_b892f3f3","line":11,"updated":"2016-08-18 14:18:36.000000000","message":"Please mention the reason.","commit_id":"1182350770f75972e7369115087939a6b278049b"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"5ef5d41acb090eef581b5ce8107f99874b164d03","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soffie Huang \u003cSoffie.Huang@falconstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-12 02:56:34 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FalconStor: Restore option \"san_secondary_ip\" and drop the \"copy_image_to_volume\" feature"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This addressed two bugs,including:"},{"line_number":10,"context_line":"1. Add a missing option for iSCSI multipath"},{"line_number":11,"context_line":"The secondary ip address was missed when other code reviewer asked me empty the __init__.py file"},{"line_number":12,"context_line":"at Change #331579"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"2. Drop the copy_image_to_volume feature"},{"line_number":15,"context_line":"The inheritance class changed and the implementation layer at os_brick."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1ac06dbe_eef621d6","line":12,"range":{"start_line":7,"start_character":0,"end_line":12,"end_character":17},"updated":"2016-08-20 09:51:59.000000000","message":"The first line should be limited to 50 characters and should not end with a period.\nSubsequent lines should be wrapped at 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"5f4f16334feb53f893ce8c42acdc187bb7a479e2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62059d6f0f39ef1ee7ea702b8b69d44aeb92426b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Soffie Huang \u003cSoffie.Huang@falconstor.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-15 01:57:15 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"FalconStor: Restore option \"san_secondary_ip\" and"},{"line_number":8,"context_line":"drop the \"copy_image_to_volume\" feature"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"This addressed two bugs,including:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a95cdbc_d4f00294","line":7,"updated":"2016-10-06 19:39:10.000000000","message":"As Huyang mentioned in patch set 5, this does not follow the commit message guidelines. Please update it to one summary line, followed by a blank line, then the full description.","commit_id":"0e8212bdb128ac063ee73f837e396b893152041b"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"b5e51f79a90a71182b8e89b4af8af2d28fab0f2f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":20,"context_line":"Closes-Bug: #1613636"},{"line_number":21,"context_line":"Closes-Bug: #1614350"},{"line_number":22,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a95cdbc_6c2d9594","line":22,"updated":"2016-10-07 06:27:58.000000000","message":"Describe, why the change impacts documentation?","commit_id":"0e8212bdb128ac063ee73f837e396b893152041b"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"e1cd3fbe147f3852cc831c7942230ede8d9804af","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Change-Id: I302a54fd10cbb9079bd33d2d8f2d7275eb6492b6"},{"line_number":20,"context_line":"Closes-Bug: #1613636"},{"line_number":21,"context_line":"Closes-Bug: #1614350"},{"line_number":22,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba5da102_34dd1415","line":22,"in_reply_to":"1a95cdbc_6c2d9594","updated":"2016-10-27 10:19:25.000000000","message":"Hi Vijay, \nAs Erlon and Kendall suggestion, I add the DocImpact tag as I am adding a new option.","commit_id":"0e8212bdb128ac063ee73f837e396b893152041b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c01112b1abe5c0e1891f886f565582a5a133f920","unresolved":false,"context_lines":[{"line_number":7,"context_line":"FalconStor: Restore option \"san_secondary_ip\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add a missing option for iSCSI multipath"},{"line_number":10,"context_line":"The secondary ip address was missed when other code reviewer asked me"},{"line_number":11,"context_line":"empty the __init__.py file at Change #331579"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1613636"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba5da102_6e6430e5","line":10,"updated":"2016-11-04 12:32:40.000000000","message":"Please, add Change-ID here. Also, it would be good go get more clear commit message here","commit_id":"fa81e8a14d32b550b33bbf1b2484aab36cef9f9d"}],"cinder/volume/drivers/falconstor/fss_common.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fa86c57d32b25d18c40ff65f1baa37aff1db7e9c","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from cinder import exception"},{"line_number":30,"context_line":"from cinder.i18n import _, _LE, _LI, _LW"},{"line_number":31,"context_line":"from cinder.image import image_utils"},{"line_number":32,"context_line":"from cinder.volume.drivers.falconstor import rest_proxy"},{"line_number":33,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_a978642c","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":36},"updated":"2016-08-16 20:01:47.000000000","message":"Not used anymore.","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from cinder import exception"},{"line_number":30,"context_line":"from cinder.i18n import _, _LE, _LI, _LW"},{"line_number":31,"context_line":"from cinder.image import image_utils"},{"line_number":32,"context_line":"from cinder.volume.drivers.falconstor import rest_proxy"},{"line_number":33,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_291905d8","line":31,"range":{"start_line":31,"start_character":25,"end_line":31,"end_character":36},"in_reply_to":"3ac371cc_a978642c","updated":"2016-08-17 04:34:29.000000000","message":"Done","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"fa86c57d32b25d18c40ff65f1baa37aff1db7e9c","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _check_multipath(self):"},{"line_number":102,"context_line":"        if self.configuration.use_multipath_for_image_xfer:"},{"line_number":103,"context_line":"            if not self.configuration.san_secondary_ip:"},{"line_number":104,"context_line":"                msg \u003d (_(\u0027The san_secondary_ip param is null.\u0027))"},{"line_number":105,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":106,"context_line":"            output \u003d self.proxy._check_iocluster_state()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_89364850","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":54},"updated":"2016-08-16 20:01:47.000000000","message":"How did this worked if you are adding the option now?","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":17959,"name":"Sofie Huang","email":"Soffie.Huang@falconstor.com","username":"Soffie"},"change_message_id":"3cb2d49eb792ea14f4a8c2d7212b0f1d41e4ba5a","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _check_multipath(self):"},{"line_number":102,"context_line":"        if self.configuration.use_multipath_for_image_xfer:"},{"line_number":103,"context_line":"            if not self.configuration.san_secondary_ip:"},{"line_number":104,"context_line":"                msg \u003d (_(\u0027The san_secondary_ip param is null.\u0027))"},{"line_number":105,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":106,"context_line":"            output \u003d self.proxy._check_iocluster_state()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_3b06681d","line":103,"range":{"start_line":103,"start_character":19,"end_line":103,"end_character":54},"in_reply_to":"3ac371cc_89364850","updated":"2016-08-17 04:34:29.000000000","message":"It exist as usual but missed this option when code reviewer asked me empty the __init__.py file at previously submitted.","commit_id":"77e3288d4030d16665e0bc7aac6ec9b226d4018e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"964634a2422fb8bd3008bc687eb28f0aca35285e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"               help\u003d\u0027FSS pool id in which FalconStor volumes are stored.\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027san_secondary_ip\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027FSS san_secondary_ip\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027fss_debug\u0027,"},{"line_number":44,"context_line":"                default\u003dFalse,"},{"line_number":45,"context_line":"                help\u003d\"Enable HTTP debugging to FSS\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_eabcd507","line":42,"range":{"start_line":42,"start_character":25,"end_line":42,"end_character":41},"updated":"2016-08-17 16:26:42.000000000","message":"nit: FSS SAN secondary IP address","commit_id":"b635fb4cc074f78e9007d3c13392a0ab3bca7c28"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"62059d6f0f39ef1ee7ea702b8b69d44aeb92426b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    cfg.IntOpt(\u0027fss_pool\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027FSS pool id in which FalconStor volumes are stored.\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027san_secondary_ip\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027FSS SAN secondary IP address\u0027),"},{"line_number":43,"context_line":"    cfg.BoolOpt(\u0027fss_debug\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_d4048219","line":40,"updated":"2016-10-06 19:39:10.000000000","message":"This driver\u0027s use of san_ip and san_secondary_ip is really a little odd. For everything else, this would be the IP address that the driver is configured to use to talk to the the SAN for management, not the IP address for iSCSI traffic. That typically is retrieved from the SAN during initialize_connection via whatever control path is used (REST API, ssh, etc.).\n\nWhich is also odd, because doing a quick trace through the code, you are in fact calling list_iscsi_target_info() which I would assume by the name would get you whatever iSCSI targets are available.","commit_id":"0e8212bdb128ac063ee73f837e396b893152041b"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c01112b1abe5c0e1891f886f565582a5a133f920","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.proxy \u003d rest_proxy.RESTProxy(self.configuration)"},{"line_number":65,"context_line":"        self._backend_name \u003d ("},{"line_number":66,"context_line":"            self.configuration.safe_get(\u0027volume_backend_name\u0027) or \u0027FalconStor\u0027)"},{"line_number":67,"context_line":"        self._storage_protocol \u003d \u0027\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def do_setup(self, context):"},{"line_number":70,"context_line":"        self.proxy.do_setup()"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5da102_6e9270a1","line":67,"range":{"start_line":67,"start_character":15,"end_line":67,"end_character":16},"updated":"2016-11-04 12:32:40.000000000","message":"Empty value for \u0027storage_protolol\u0027 looks very confusing","commit_id":"fa81e8a14d32b550b33bbf1b2484aab36cef9f9d"}]}