)]}'
{"cinder/zonemanager/drivers/cisco/cisco_fc_zone_client_cli.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88b219b8f7acc52349b19782a54ee32264c4928d","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        :raises: CiscoZoningCliException"},{"line_number":228,"context_line":"        \"\"\""},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        LOG.debug((\"Update Zones - Operation: %(op)s - Zones \""},{"line_number":231,"context_line":"                   \"passed: %(zones)s\"),"},{"line_number":232,"context_line":"                  {\u0027op\u0027: operation, \u0027zones\u0027: zones})"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_1418101d","line":230,"range":{"start_line":230,"start_character":18,"end_line":230,"end_character":19},"updated":"2016-10-27 10:14:43.000000000","message":"This extra () around the string could be removed.","commit_id":"522e21326b244f231b0163a6e97eda1f6cec4c70"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"88b219b8f7acc52349b19782a54ee32264c4928d","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"            msg \u003d _(\"Updating and activating zone set failed: \""},{"line_number":258,"context_line":"                    \"(Zone set\u003d%(zoneset)s error\u003d%(err)s).\""},{"line_number":259,"context_line":"                    ), {\u0027zoneset\u0027: cfg_name, \u0027err\u0027: six.text_type(e)}"},{"line_number":260,"context_line":"            LOG.error(msg)"},{"line_number":261,"context_line":"            raise exception.CiscoZoningCliException(reason\u003dmsg)"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5da102_54a608c2","line":259,"range":{"start_line":259,"start_character":21,"end_line":259,"end_character":22},"updated":"2016-10-27 10:14:43.000000000","message":"Since this isn\u0027t in the log call itself you need to use % to actually do the string formatting immediately. Otherwise this just ends up being a tuple passed in to the logger and as the exception message.","commit_id":"522e21326b244f231b0163a6e97eda1f6cec4c70"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"6c6c4a8f3b71c513611a75ce727b6589f0944f1d","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        for zone, zone_members in zones.items():"},{"line_number":240,"context_line":"            zone_cmds.append([\u0027zone\u0027, \u0027name\u0027, zone])"},{"line_number":241,"context_line":"            for member in zone_members:"},{"line_number":242,"context_line":"                if operation \u003d\u003d ZoneConstant.ZONE_ADD:"},{"line_number":243,"context_line":"                    zone_cmds.append([\u0027member\u0027, \u0027pwwn\u0027, member])"},{"line_number":244,"context_line":"                elif operation \u003d\u003d ZoneConstant.ZONE_REMOVE:"},{"line_number":245,"context_line":"                    zone_cmds.append([\u0027no\u0027, \u0027member\u0027, \u0027pwwn\u0027, member])"},{"line_number":246,"context_line":"        zone_cmds.append([\u0027end\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_a079cc95","line":245,"range":{"start_line":241,"start_character":11,"end_line":245,"end_character":70},"updated":"2016-10-28 07:02:38.000000000","message":"It\u0027s better to move  this if statement outside of the \u0027for x in y\u0027 to reduce redundant comparisons.","commit_id":"dcd45be2ad3cb74b569ceac83b19604384fd4d81"},{"author":{"_account_id":15383,"name":"Yucong Feng","email":"yfeng@us.ibm.com","username":"yfeng"},"change_message_id":"d527fde0ad9c2c960e43dcd5a629302023f04849","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        for zone, zone_members in zones.items():"},{"line_number":240,"context_line":"            zone_cmds.append([\u0027zone\u0027, \u0027name\u0027, zone])"},{"line_number":241,"context_line":"            for member in zone_members:"},{"line_number":242,"context_line":"                if operation \u003d\u003d ZoneConstant.ZONE_ADD:"},{"line_number":243,"context_line":"                    zone_cmds.append([\u0027member\u0027, \u0027pwwn\u0027, member])"},{"line_number":244,"context_line":"                elif operation \u003d\u003d ZoneConstant.ZONE_REMOVE:"},{"line_number":245,"context_line":"                    zone_cmds.append([\u0027no\u0027, \u0027member\u0027, \u0027pwwn\u0027, member])"},{"line_number":246,"context_line":"        zone_cmds.append([\u0027end\u0027])"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_03b9b82e","line":245,"range":{"start_line":241,"start_character":11,"end_line":245,"end_character":70},"in_reply_to":"ba5da102_a079cc95","updated":"2016-11-21 19:53:22.000000000","message":"The time complexity would be the same even if it is moved outside of the loop. If this is a big sticking point, it can be moved out of the for loop","commit_id":"dcd45be2ad3cb74b569ceac83b19604384fd4d81"}]}