)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"abac013bd81be5a1681d979dc9166dd13eb71ce4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of volume should be converted InvalidVolumeMetadataSize"},{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_2c58d389","line":13,"updated":"2016-08-23 09:55:29.000000000","message":"-1: Missing API impact, since this changes response from 400 to 413.","commit_id":"75811a8f4086e52ce4fd59ada1b18924a530a8da"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"e589dd8bb9dab6ebfc6dd19ba7462eea22d40f91","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of volume should be converted InvalidVolumeMetadataSize"},{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_eab696f7","line":13,"in_reply_to":"1ac06dbe_2c58d389","updated":"2016-08-23 11:35:08.000000000","message":"Thanks Gorka,\nDone.","commit_id":"75811a8f4086e52ce4fd59ada1b18924a530a8da"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a82530e0d374af4712292b6ca11685c1e05c434f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of volume should be converted InvalidVolumeMetadataSize"},{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"DOCImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_a9978b46","line":13,"updated":"2016-08-23 12:02:33.000000000","message":"-1: APIImpact should contain a comment about why the change impacts a public HTTP API.  I think it would be enough to mention that on volume creation we\u0027ll now return 413 instead of 400 for invalid metadata sizes.","commit_id":"e631fdbd9d3d9739dac7c361e371b37528bb3b27"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"cc32786687f14c245608ceca690d8ac33bba7d1b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of volume should be converted InvalidVolumeMetadataSize"},{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"DOCImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_ec1b5171","line":13,"in_reply_to":"1ac06dbe_a9978b46","updated":"2016-08-23 12:08:47.000000000","message":"Thanks for your advice.","commit_id":"e631fdbd9d3d9739dac7c361e371b37528bb3b27"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a82530e0d374af4712292b6ca11685c1e05c434f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"DOCImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_495b77f6","line":14,"updated":"2016-08-23 12:02:33.000000000","message":"-1: I don\u0027t think DOCImpact is pertinent in this patch.","commit_id":"e631fdbd9d3d9739dac7c361e371b37528bb3b27"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"cc32786687f14c245608ceca690d8ac33bba7d1b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"APIImpact"},{"line_number":14,"context_line":"DOCImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I65cd35f96aa5a3cd4d0bbd72298c98599daad124"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_cc181578","line":14,"in_reply_to":"1ac06dbe_495b77f6","updated":"2016-08-23 12:08:47.000000000","message":"Done","commit_id":"e631fdbd9d3d9739dac7c361e371b37528bb3b27"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a077f521808c009b7ff71eaf187cc3cd6cc3af87","unresolved":false,"context_lines":[{"line_number":10,"context_line":"of volume should be converted InvalidVolumeMetadataSize"},{"line_number":11,"context_line":"exception to webob.exc.HTTPRequestEntityTooLarge as well."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Further, the volume creation we\u0027ll now return 413"},{"line_number":14,"context_line":"instead of 400 for invalid metadata sizes."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_06a7660b","line":13,"range":{"start_line":13,"start_character":1,"end_line":13,"end_character":45},"updated":"2016-08-24 09:25:26.000000000","message":"nit: Volume creation will now return","commit_id":"e57b85ce6518826bf1e3d2ef96895d36bc5cfe4a"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d32c010a325399fc6bc28059a28b73dfe873cd7b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                volume.get(\u0027display_description\u0027),"},{"line_number":274,"context_line":"                **kwargs)"},{"line_number":275,"context_line":"        except exception.InvalidVolumeMetadataSize as error:"},{"line_number":276,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003derror.msg)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        retval \u003d self._view_builder.detail(req, new_volume)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_bff7e289","line":276,"updated":"2016-08-22 21:07:31.000000000","message":"What is the change in HTTP response codes provided to the caller here?","commit_id":"75811a8f4086e52ce4fd59ada1b18924a530a8da"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"abac013bd81be5a1681d979dc9166dd13eb71ce4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                volume.get(\u0027display_description\u0027),"},{"line_number":274,"context_line":"                **kwargs)"},{"line_number":275,"context_line":"        except exception.InvalidVolumeMetadataSize as error:"},{"line_number":276,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003derror.msg)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        retval \u003d self._view_builder.detail(req, new_volume)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_8c710747","line":276,"in_reply_to":"1ac06dbe_0b8cf3d8","updated":"2016-08-23 09:55:29.000000000","message":"This is changed to return a consistent error with update method, L331 of this same file.","commit_id":"75811a8f4086e52ce4fd59ada1b18924a530a8da"},{"author":{"_account_id":16066,"name":"xiexs","email":"xiexs@cn.fujitsu.com","username":"simen"},"change_message_id":"75cb444a61b9f9326cbb8be811fee0cc746bbf25","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                volume.get(\u0027display_description\u0027),"},{"line_number":274,"context_line":"                **kwargs)"},{"line_number":275,"context_line":"        except exception.InvalidVolumeMetadataSize as error:"},{"line_number":276,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003derror.msg)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        retval \u003d self._view_builder.detail(req, new_volume)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_0b8cf3d8","line":276,"in_reply_to":"1ac06dbe_bff7e289","updated":"2016-08-23 01:13:25.000000000","message":"The code is changed from 400 to 413.","commit_id":"75811a8f4086e52ce4fd59ada1b18924a530a8da"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"983697b708ee5b772aaa6568591817bbc5b7c684","unresolved":false,"context_lines":[{"line_number":273,"context_line":"                volume.get(\u0027display_description\u0027),"},{"line_number":274,"context_line":"                **kwargs)"},{"line_number":275,"context_line":"        except exception.InvalidVolumeMetadataSize as error:"},{"line_number":276,"context_line":"            raise webob.exc.HTTPRequestEntityTooLarge(explanation\u003derror.msg)"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        retval \u003d self._view_builder.detail(req, new_volume)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_e57a3277","line":276,"updated":"2016-09-08 20:54:35.000000000","message":"This change needs a microversion bump because it changes the status code of a released API.  See doc here:\n\nhttps://github.com/openstack/cinder/blob/master/doc/source/devref/api_microversion_dev.rst","commit_id":"4fcb3d8ee63ed10f06890c93329e708243c4bfb3"}]}