)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"459770821c1a5a524e55c0c8ff8391210e854314","unresolved":false,"context_lines":[{"line_number":10,"context_line":"cinder/tests/unit/*.py."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I623b3b4bd27efc8e302e6bace011f9d807c2c64f"},{"line_number":13,"context_line":"Closes-Bug: #1614852"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_b873fdb3","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2016-08-19 12:01:35.000000000","message":"This is not a bug. So, you don\u0027t need this (also close the bug in LP).","commit_id":"355ff01b337fe4ca024e885b65c44a2aea1901bf"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"80196b3b6ddddb009f9c7c017489a31936100180","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 03:30:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases"},{"line_number":10,"context_line":"that use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_19cd5285","line":7,"updated":"2016-08-23 10:51:26.000000000","message":"-1: Title is misleading, since it suggests this patch will fix all cases, but it doesn\u0027t.\n\nWhy not fix all cases in this patch?","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4ed0024ee17f3dbec08e48d7e504bf640a08899f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-22 03:30:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases"},{"line_number":10,"context_line":"that use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_2b5a38f2","line":7,"in_reply_to":"1ac06dbe_19cd5285","updated":"2016-08-24 04:36:17.000000000","message":"Done","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bed71d413b72a11c1019616b73d17bc8efce4d6c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 10:52:40 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py tests (1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases"},{"line_number":10,"context_line":"that use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_d465fc44","line":7,"updated":"2016-08-24 08:07:37.000000000","message":"nit: (1/2)","commit_id":"522182ebf0482c9f25b45492d9992b2b8b87efab"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"96699f959eae0b583ae576f26a3654125ddce21c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-24 10:52:40 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Stop using mox in unit/*.py tests (1)"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As mox is not compatible with python 3, all test cases"},{"line_number":10,"context_line":"that use mox should be updated to use mock instead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_05848008","line":7,"in_reply_to":"1ac06dbe_d465fc44","updated":"2016-08-24 08:41:41.000000000","message":"Done","commit_id":"522182ebf0482c9f25b45492d9992b2b8b87efab"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bed71d413b72a11c1019616b73d17bc8efce4d6c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"cinder/tests/unit/*.py."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The remaining tests are fixed in another patch set at:"},{"line_number":16,"context_line":"https://review.openstack.org/#/c/355815/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I623b3b4bd27efc8e302e6bace011f9d807c2c64f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_9471c40e","line":16,"updated":"2016-08-24 08:07:37.000000000","message":"nit: There\u0027s no need to mention it here, this could have gone into a comment in gerrit.  And no comment would be needed if the other patch was dependent on this one.","commit_id":"522182ebf0482c9f25b45492d9992b2b8b87efab"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"96699f959eae0b583ae576f26a3654125ddce21c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"cinder/tests/unit/*.py."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The remaining tests are fixed in another patch set at:"},{"line_number":16,"context_line":"https://review.openstack.org/#/c/355815/"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I623b3b4bd27efc8e302e6bace011f9d807c2c64f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_a575ac32","line":16,"in_reply_to":"1ac06dbe_9471c40e","updated":"2016-08-24 08:41:41.000000000","message":"Done","commit_id":"522182ebf0482c9f25b45492d9992b2b8b87efab"}],"cinder/tests/unit/fake_notifier.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"80196b3b6ddddb009f9c7c017489a31936100180","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        del self.notifications[:]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def stub_notifier(testcase):"},{"line_number":68,"context_line":"    testcase.mock_object(messaging, \u0027Notifier\u0027, FakeNotifier)"},{"line_number":69,"context_line":"    if rpc.NOTIFIER:"},{"line_number":70,"context_line":"        serializer \u003d getattr(rpc.NOTIFIER, \u0027_serializer\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_f954b6fe","line":67,"updated":"2016-08-23 10:51:26.000000000","message":"-1: This should be renamed to mock_notifier","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4ed0024ee17f3dbec08e48d7e504bf640a08899f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        del self.notifications[:]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"def stub_notifier(testcase):"},{"line_number":68,"context_line":"    testcase.mock_object(messaging, \u0027Notifier\u0027, FakeNotifier)"},{"line_number":69,"context_line":"    if rpc.NOTIFIER:"},{"line_number":70,"context_line":"        serializer \u003d getattr(rpc.NOTIFIER, \u0027_serializer\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_2ba7d80b","line":67,"in_reply_to":"1ac06dbe_f954b6fe","updated":"2016-08-24 04:36:17.000000000","message":"Done","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"}],"cinder/tests/unit/fake_utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"80196b3b6ddddb009f9c7c017489a31936100180","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    return reply"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def stub_out_utils_execute(testcase):"},{"line_number":94,"context_line":"    fake_execute_set_repliers([])"},{"line_number":95,"context_line":"    fake_execute_clear_log()"},{"line_number":96,"context_line":"    testcase.mock_object(utils, \u0027execute\u0027, fake_execute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_7949e65f","line":93,"updated":"2016-08-23 10:51:26.000000000","message":"-1: This method is not used, so it should just be removed in another patch, and if it was being used it should be renamed to mock_utils_execute","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4ed0024ee17f3dbec08e48d7e504bf640a08899f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    return reply"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def stub_out_utils_execute(testcase):"},{"line_number":94,"context_line":"    fake_execute_set_repliers([])"},{"line_number":95,"context_line":"    fake_execute_clear_log()"},{"line_number":96,"context_line":"    testcase.mock_object(utils, \u0027execute\u0027, fake_execute)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_8828929b","line":93,"in_reply_to":"1ac06dbe_7949e65f","updated":"2016-08-24 04:36:17.000000000","message":"Done","commit_id":"8df4e2935c101d90cff702bf38ed401c2ca37f36"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bed71d413b72a11c1019616b73d17bc8efce4d6c","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Replicate the sleep call in the real function"},{"line_number":87,"context_line":"    greenthread.sleep(0)"},{"line_number":88,"context_line":"    return reply"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_74dec8dd","line":88,"updated":"2016-08-24 08:07:37.000000000","message":"-0.5: Removal of stub_out_utils_execute should be done on a different patch.","commit_id":"522182ebf0482c9f25b45492d9992b2b8b87efab"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"686a3754537aba6d13e3a69d44ef57bad5f76648","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Replicate the sleep call in the real function"},{"line_number":87,"context_line":"    greenthread.sleep(0)"},{"line_number":88,"context_line":"    return reply"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ac06dbe_26e6e2e7","line":88,"updated":"2016-08-24 09:30:09.000000000","message":"-0.5: Removal of stub_out_utils_execute should be done on a different patch.","commit_id":"4d2d048523e23ff41249d0f21b08c055d5718a60"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"c4fb2b82157a367e216623152386d37ff334f5fe","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    # Replicate the sleep call in the real function"},{"line_number":87,"context_line":"    greenthread.sleep(0)"},{"line_number":88,"context_line":"    return reply"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_1955ffc4","line":88,"in_reply_to":"1ac06dbe_26e6e2e7","updated":"2016-08-30 08:20:19.000000000","message":"Reversed. I fix that in another patch set at https://review.openstack.org/#/c/362686/.","commit_id":"4d2d048523e23ff41249d0f21b08c055d5718a60"}]}