)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"61f74c2ec4e0dc636c2f3766610680da408ec542","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The VNX driver experience some performance issue during initialize"},{"line_number":10,"context_line":"connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"After some analysis, we root caused the problem to two issue."},{"line_number":13,"context_line":"1. Storage group instance was retrieved every time it\u0027s needed.  Extra CLI"},{"line_number":14,"context_line":"calls were made to update the host LUN information in the storage group."},{"line_number":15,"context_line":"These CLI calls could be saved if we cache the storage group instance in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_15c202e9","line":12,"updated":"2016-08-30 15:34:24.000000000","message":"nit: issues","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"afac0bfe4655a75afdd9e03ba2ac630d9f2c720e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The VNX driver experience some performance issue during initialize"},{"line_number":10,"context_line":"connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"After some analysis, we root caused the problem to two issue."},{"line_number":13,"context_line":"1. Storage group instance was retrieved every time it\u0027s needed.  Extra CLI"},{"line_number":14,"context_line":"calls were made to update the host LUN information in the storage group."},{"line_number":15,"context_line":"These CLI calls could be saved if we cache the storage group instance in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_dcd3455e","line":12,"in_reply_to":"fa7ab95a_15c202e9","updated":"2016-08-31 02:27:11.000000000","message":"Updated.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"61f74c2ec4e0dc636c2f3766610680da408ec542","unresolved":false,"context_lines":[{"line_number":10,"context_line":"connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"After some analysis, we root caused the problem to two issue."},{"line_number":13,"context_line":"1. Storage group instance was retrieved every time it\u0027s needed.  Extra CLI"},{"line_number":14,"context_line":"calls were made to update the host LUN information in the storage group."},{"line_number":15,"context_line":"These CLI calls could be saved if we cache the storage group instance in"},{"line_number":16,"context_line":"the client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_556f2afb","line":13,"updated":"2016-08-30 15:34:24.000000000","message":"Please wrap the line to less than or equal to 72 chars.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"afac0bfe4655a75afdd9e03ba2ac630d9f2c720e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"connection."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"After some analysis, we root caused the problem to two issue."},{"line_number":13,"context_line":"1. Storage group instance was retrieved every time it\u0027s needed.  Extra CLI"},{"line_number":14,"context_line":"calls were made to update the host LUN information in the storage group."},{"line_number":15,"context_line":"These CLI calls could be saved if we cache the storage group instance in"},{"line_number":16,"context_line":"the client."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa7ab95a_3cc3518c","line":13,"in_reply_to":"fa7ab95a_556f2afb","updated":"2016-08-31 02:27:11.000000000","message":"Thanks.  Updated.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"}],"cinder/tests/unit/volume/drivers/emc/vnx/test_adapter.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"61f74c2ec4e0dc636c2f3766610680da408ec542","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":688,"context_line":"    def test_auto_register_initiator_no_port_to_reg("},{"line_number":689,"context_line":"            self, common_adapter, mocked_res, mocked_input):"},{"line_number":690,"context_line":"        common_adapter.client.register_initiator \u003d mock.Mock()"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        common_adapter.config.io_port_list \u003d [\u0027a-0-0\u0027]"},{"line_number":693,"context_line":"        allowed_ports \u003d mocked_res[\u0027allowed_ports\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_d5433aad","line":690,"updated":"2016-08-30 15:34:24.000000000","message":"Better to use \"with mock.patch.object\" or a decorator to mock the method.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"f2098ac677015031eeb16695cce370de796e80e5","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":688,"context_line":"    def test_auto_register_initiator_no_port_to_reg("},{"line_number":689,"context_line":"            self, common_adapter, mocked_res, mocked_input):"},{"line_number":690,"context_line":"        common_adapter.client.register_initiator \u003d mock.Mock()"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        common_adapter.config.io_port_list \u003d [\u0027a-0-0\u0027]"},{"line_number":693,"context_line":"        allowed_ports \u003d mocked_res[\u0027allowed_ports\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_70c3328b","line":690,"in_reply_to":"fa7ab95a_3f67c0eb","updated":"2016-08-31 07:47:41.000000000","message":"Thanks, Xing.  I think I understand it now.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"23a8f80d4af6d6eea8b0e5d208fff9a5461c404a","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":688,"context_line":"    def test_auto_register_initiator_no_port_to_reg("},{"line_number":689,"context_line":"            self, common_adapter, mocked_res, mocked_input):"},{"line_number":690,"context_line":"        common_adapter.client.register_initiator \u003d mock.Mock()"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        common_adapter.config.io_port_list \u003d [\u0027a-0-0\u0027]"},{"line_number":693,"context_line":"        allowed_ports \u003d mocked_res[\u0027allowed_ports\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_3f67c0eb","line":690,"in_reply_to":"fa7ab95a_69919652","updated":"2016-08-31 04:35:34.000000000","message":"I\u0027m not saying it is not safe.  See comments on the following patch:\n\nhttps://review.openstack.org/#/c/342300/11/cinder/tests/unit/volume/drivers/emc/test_emc_vmax.py@8117","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"e5ff0e49ef71e1c3957e3f9ac15d2dde44d7846b","unresolved":false,"context_lines":[{"line_number":687,"context_line":"    @res_mock.patch_common_adapter"},{"line_number":688,"context_line":"    def test_auto_register_initiator_no_port_to_reg("},{"line_number":689,"context_line":"            self, common_adapter, mocked_res, mocked_input):"},{"line_number":690,"context_line":"        common_adapter.client.register_initiator \u003d mock.Mock()"},{"line_number":691,"context_line":""},{"line_number":692,"context_line":"        common_adapter.config.io_port_list \u003d [\u0027a-0-0\u0027]"},{"line_number":693,"context_line":"        allowed_ports \u003d mocked_res[\u0027allowed_ports\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_69919652","line":690,"in_reply_to":"fa7ab95a_d5433aad","updated":"2016-08-31 03:43:28.000000000","message":"Hi Xing,\n\nwe provide a new adapter instance for each test case, so it\u0027s safe to use mock. let us know if you still have concern.\n\nThanks\nPeter","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"}],"cinder/volume/drivers/emc/vnx/client.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"61f74c2ec4e0dc636c2f3766610680da408ec542","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            return self.vnx.get_sg(name\u003dname)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def get_storage_group(self, name):"},{"line_number":407,"context_line":"        \"\"\"Retrieve the storage group by name"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Check the storage group instance cache first to save"},{"line_number":410,"context_line":"        CLI call."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_55eaca74","line":407,"updated":"2016-08-30 15:34:24.000000000","message":"nit: missing period at the end.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"},{"author":{"_account_id":13206,"name":"Cedric Zhuang","email":"cedric.zhuang@emc.com","username":"CedricZhuang"},"change_message_id":"afac0bfe4655a75afdd9e03ba2ac630d9f2c720e","unresolved":false,"context_lines":[{"line_number":404,"context_line":"            return self.vnx.get_sg(name\u003dname)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def get_storage_group(self, name):"},{"line_number":407,"context_line":"        \"\"\"Retrieve the storage group by name"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        Check the storage group instance cache first to save"},{"line_number":410,"context_line":"        CLI call."}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_9ced3df2","line":407,"in_reply_to":"fa7ab95a_55eaca74","updated":"2016-08-31 02:27:11.000000000","message":"Updated.  Thanks.","commit_id":"599ba4ece46383edf6eb8be288c211fbeda5548f"}]}