)]}'
{"tools/lintstack.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2dfb4436ff64bba027b5d0783a6d78776133bf2b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            obj \u003d cls.from_line(line)"},{"line_number":144,"context_line":"            if obj.is_ignored():"},{"line_number":145,"context_line":"                continue"},{"line_number":146,"context_line":"            print(line)"},{"line_number":147,"context_line":"            key \u003d obj.key()"},{"line_number":148,"context_line":"            if key not in result:"},{"line_number":149,"context_line":"                result[key] \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_8e6b6884","line":146,"updated":"2016-08-24 10:57:49.000000000","message":"-1: This is not the right place to do this, this method should have no stdout output, should just convert from msg to dict.\n\nAnd this will print messages even for know errors that are allowed exceptions (in tools/pylint_exceptions file).\n\nIf that\u0027s what we really want to do, *which I think we shouldn\u0027t do*, this should be changed in L237 replacing:\n\n if err_key not in known:\n     print(err.lintoutput)\n     print()\n     passed \u003d False\n\nWith\n\n print(err.lintoutput)\n\n if err_key not in known:\n     passed \u003d False\n\nBut if we do that we\u0027ll get a lot of known errors that will clutter the output.\n\nAn alternative solution is to allow specifying the known errors file, that way if we really want to see al messages, including those we already know of, we can just create an empty file and run lintstack with that know errors file.","commit_id":"0f6d0b3dd10960942b4d35975a13bef2aa04e3f4"}]}