)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eb25233c7ed70ff174bd7f3f998ae3f84fe4e297","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the Server OS type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The default is still Red Hat Linux 6.x."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I681c40beef56fb29b72cb673edc8eb43cfb553e4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_8fe60f13","line":14,"updated":"2016-08-23 12:28:10.000000000","message":"We\u0027ll need a DocImpact tag since this is adding a config option.","commit_id":"ca61962e83b30d80bc90f673244ea79e41a1cf92"}],"cinder/tests/unit/volume/drivers/dell/test_dellscapi.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"eb25233c7ed70ff174bd7f3f998ae3f84fe4e297","unresolved":false,"context_lines":[{"line_number":2690,"context_line":"                                         mock_close_connection,"},{"line_number":2691,"context_line":"                                         mock_open_connection,"},{"line_number":2692,"context_line":"                                         mock_init):"},{"line_number":2693,"context_line":"        res \u003d self.scapi.create_server(self.WWNS, \u0027Red Hat Linux 6.x\u0027)"},{"line_number":2694,"context_line":"        self.assertTrue(mock_create_server.called)"},{"line_number":2695,"context_line":"        self.assertTrue(mock_add_hba.called)"},{"line_number":2696,"context_line":"        self.assertEqual(self.SCSERVER, res, \u0027Unexpected ScServer\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_afd02b20","line":2693,"updated":"2016-08-23 12:28:10.000000000","message":"Might be good to define a constant for this string if you do an update.","commit_id":"ca61962e83b30d80bc90f673244ea79e41a1cf92"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"352ededbf35f5829d7bd7cb02f71a91cd1591a86","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"                                        mock_close_connection,"},{"line_number":2751,"context_line":"                                        mock_open_connection,"},{"line_number":2752,"context_line":"                                        mock_init):"},{"line_number":2753,"context_line":"        res \u003d self.scapi.create_server(self.IQN, \u0027Red Hat Binux 6.x\u0027)"},{"line_number":2754,"context_line":"        self.assertTrue(mock_find_serveros.called)"},{"line_number":2755,"context_line":"        self.assertEqual(self.SCSERVER, res, \u0027Unexpected ScServer\u0027)"},{"line_number":2756,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_30e05bcc","line":2753,"updated":"2016-09-01 16:07:35.000000000","message":"s/Binux/Linux\n\nSuggest that you create a constant for this to avoid typo.  This string is used in multiple places.","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"12f90b4d93865157c9dbb2e4d9887ddcb0d3ae1e","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"                                        mock_close_connection,"},{"line_number":2751,"context_line":"                                        mock_open_connection,"},{"line_number":2752,"context_line":"                                        mock_init):"},{"line_number":2753,"context_line":"        res \u003d self.scapi.create_server(self.IQN, \u0027Red Hat Binux 6.x\u0027)"},{"line_number":2754,"context_line":"        self.assertTrue(mock_find_serveros.called)"},{"line_number":2755,"context_line":"        self.assertEqual(self.SCSERVER, res, \u0027Unexpected ScServer\u0027)"},{"line_number":2756,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_f0f7d356","line":2753,"in_reply_to":"fa7ab95a_30e05bcc","updated":"2016-09-01 16:10:17.000000000","message":"Good catch!\n\nMight be worth making this a constant now that it\u0027s in multiple locations.","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"974576cec4be53eb415a9ab397d3429c43e821c8","unresolved":false,"context_lines":[{"line_number":2750,"context_line":"                                        mock_close_connection,"},{"line_number":2751,"context_line":"                                        mock_open_connection,"},{"line_number":2752,"context_line":"                                        mock_init):"},{"line_number":2753,"context_line":"        res \u003d self.scapi.create_server(self.IQN, \u0027Red Hat Binux 6.x\u0027)"},{"line_number":2754,"context_line":"        self.assertTrue(mock_find_serveros.called)"},{"line_number":2755,"context_line":"        self.assertEqual(self.SCSERVER, res, \u0027Unexpected ScServer\u0027)"},{"line_number":2756,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_231e42bb","line":2753,"in_reply_to":"fa7ab95a_f0f7d356","updated":"2016-09-01 22:44:06.000000000","message":"For this test Binux is correct.","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"}],"cinder/volume/drivers/dell/dell_storagecenter_api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"352ededbf35f5829d7bd7cb02f71a91cd1591a86","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        :param wwnlist: A list of FC WWNs or iSCSI IQNs associated with this"},{"line_number":1284,"context_line":"                        server."},{"line_number":1285,"context_line":"        :param serveros: Name of server OS to use when creating the server."},{"line_number":1286,"context_line":"        :returns: Dell server object."},{"line_number":1287,"context_line":"        \"\"\""},{"line_number":1288,"context_line":"        # Find our folder or make it"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_70858305","line":1285,"updated":"2016-09-01 16:07:35.000000000","message":"Can you add param ssn too?","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"974576cec4be53eb415a9ab397d3429c43e821c8","unresolved":false,"context_lines":[{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"        :param wwnlist: A list of FC WWNs or iSCSI IQNs associated with this"},{"line_number":1284,"context_line":"                        server."},{"line_number":1285,"context_line":"        :param serveros: Name of server OS to use when creating the server."},{"line_number":1286,"context_line":"        :returns: Dell server object."},{"line_number":1287,"context_line":"        \"\"\""},{"line_number":1288,"context_line":"        # Find our folder or make it"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_03d05ef5","line":1285,"in_reply_to":"fa7ab95a_70858305","updated":"2016-09-01 22:44:06.000000000","message":"Done","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":15011,"name":"Jeff Seiler","email":"jeff_seiler@dell.com","username":"jseiler"},"change_message_id":"0ee5b0c0423da9cd36f035cf29643af94aa52b55","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        payload[\u0027Notes\u0027] \u003d self.notes"},{"line_number":1313,"context_line":"        # We pick Red Hat Linux 6.x because it supports multipath and"},{"line_number":1314,"context_line":"        # will attach luns to paths as they are found."},{"line_number":1315,"context_line":"        scserveros \u003d self._find_serveros(serveros)"},{"line_number":1316,"context_line":"        if scserveros is not None:"},{"line_number":1317,"context_line":"            payload[\u0027OperatingSystem\u0027] \u003d scserveros"},{"line_number":1318,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c6f6e4f8","line":1315,"range":{"start_line":1315,"start_character":26,"end_line":1315,"end_character":40},"updated":"2016-08-24 12:08:52.000000000","message":"For all the _find_serveros usages. If the configured OS is not found, the server will be created using the user\u0027s default Server OS.  Is this OK? Should the configured OS type be checked in check_for_setup_error to ensure the configured server OS is valid?  Or, if the configured value is not found, would we want to default back to Red Hat Linux instead of the SC user default?","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"974576cec4be53eb415a9ab397d3429c43e821c8","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        payload[\u0027Notes\u0027] \u003d self.notes"},{"line_number":1313,"context_line":"        # We pick Red Hat Linux 6.x because it supports multipath and"},{"line_number":1314,"context_line":"        # will attach luns to paths as they are found."},{"line_number":1315,"context_line":"        scserveros \u003d self._find_serveros(serveros)"},{"line_number":1316,"context_line":"        if scserveros is not None:"},{"line_number":1317,"context_line":"            payload[\u0027OperatingSystem\u0027] \u003d scserveros"},{"line_number":1318,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_43ed06b6","line":1315,"range":{"start_line":1315,"start_character":26,"end_line":1315,"end_character":40},"in_reply_to":"1ac06dbe_c6f6e4f8","updated":"2016-09-01 22:44:06.000000000","message":"Ooo! Probably want to default to Red Hat.","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"}],"releasenotes/notes/Dell-SC-ServerOS-Config-Option-bd0e018319758e03.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"6175e7112a0103d6e0f66e0db76b9a424280b53b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - dell_server_os option added to the Dell SC driver."},{"line_number":4,"context_line":"    This option allows the selection of the server type"},{"line_number":5,"context_line":"    used when creating a server on the Dell DSM during"},{"line_number":6,"context_line":"    initializse connection. This is only used if the"},{"line_number":7,"context_line":"    server does not exist. Valid values are from the"},{"line_number":8,"context_line":"    Dell DSM create server list."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_9d909f97","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":15},"updated":"2016-08-31 19:06:41.000000000","message":"initialize\n\nTrying to mix US and UK English? :)","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"},{"author":{"_account_id":12112,"name":"Tom Swanson","email":"tom_swanson@dell.com","username":"tomswanson"},"change_message_id":"974576cec4be53eb415a9ab397d3429c43e821c8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - dell_server_os option added to the Dell SC driver."},{"line_number":4,"context_line":"    This option allows the selection of the server type"},{"line_number":5,"context_line":"    used when creating a server on the Dell DSM during"},{"line_number":6,"context_line":"    initializse connection. This is only used if the"},{"line_number":7,"context_line":"    server does not exist. Valid values are from the"},{"line_number":8,"context_line":"    Dell DSM create server list."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa7ab95a_434426b6","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":15},"in_reply_to":"fa7ab95a_9d909f97","updated":"2016-09-01 22:44:06.000000000","message":"Done","commit_id":"fc18bae0279e2625dff4a772397c4267ff477da0"}]}