)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"db49d77063f5c76b4dcc43620996410067045cbf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"select volume\u0027s host to create backup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I3e41ca855f9ff0fdb424bcf9850dfd83cd980daf"},{"line_number":16,"context_line":"Closes-Bug: #1616810"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ac06dbe_9495ed41","line":16,"updated":"2016-08-25 09:39:22.000000000","message":"nit: Bug report is incomplete, no explanation on what the issue is, as in, if I do this, then this is what and I get instead of that.","commit_id":"9845a95a2520a03e06c582a4a88ffcc6c3d5cf6d"}],"cinder/backup/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"db49d77063f5c76b4dcc43620996410067045cbf","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        previous_status \u003d volume[\u0027status\u0027]"},{"line_number":235,"context_line":"        volume_host \u003d volume_utils.extract_host(volume.host, \u0027host\u0027)"},{"line_number":236,"context_line":"        host \u003d self._get_available_backup_service_host("},{"line_number":237,"context_line":"            volume_host, volume.availability_zone)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        # Reserve a quota before setting volume status and backup status"},{"line_number":240,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_34f6b9f9","line":237,"updated":"2016-08-25 09:39:22.000000000","message":"This will work, but I think that the _get_available_backup_service_host method is a big mess, between the poor choice in parameter names, the missing docstring, and the code paths...\n\nWithout a docstring and following the parameter names of that method I would say: \"you should pass the volume_host in the volume_host argument\", but that wouldn\u0027t work, because that argument is used for something else...","commit_id":"9845a95a2520a03e06c582a4a88ffcc6c3d5cf6d"}],"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"db49d77063f5c76b4dcc43620996410067045cbf","unresolved":false,"context_lines":[{"line_number":1464,"context_line":"        self.override_config(\u0027backup_use_same_host\u0027, True)"},{"line_number":1465,"context_line":"        mock_is_enable.return_value \u003d True"},{"line_number":1466,"context_line":"        self.ctxt.user_id \u003d \u0027fake_user\u0027"},{"line_number":1467,"context_line":"        self.ctxt.project_id \u003d \u0027fake_project\u0027"},{"line_number":1468,"context_line":"        volume_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027,"},{"line_number":1469,"context_line":"                                                 host\u003d\u0027testhost#lvm\u0027,"},{"line_number":1470,"context_line":"                                                 size\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_b46749b6","line":1467,"updated":"2016-08-25 09:39:22.000000000","message":"nit: You shouldn\u0027t be doing this... You should create a new context if the admin context is not to your liking.  ;-)","commit_id":"9845a95a2520a03e06c582a4a88ffcc6c3d5cf6d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"db49d77063f5c76b4dcc43620996410067045cbf","unresolved":false,"context_lines":[{"line_number":1466,"context_line":"        self.ctxt.user_id \u003d \u0027fake_user\u0027"},{"line_number":1467,"context_line":"        self.ctxt.project_id \u003d \u0027fake_project\u0027"},{"line_number":1468,"context_line":"        volume_id \u003d self._create_volume_db_entry(status\u003d\u0027available\u0027,"},{"line_number":1469,"context_line":"                                                 host\u003d\u0027testhost#lvm\u0027,"},{"line_number":1470,"context_line":"                                                 size\u003d1)"},{"line_number":1471,"context_line":"        backup \u003d self.api.create(self.ctxt, None, None, volume_id, None)"},{"line_number":1472,"context_line":"        self.assertEqual(\u0027testhost\u0027, backup.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_94ce8d81","line":1469,"updated":"2016-08-25 09:39:22.000000000","message":"nit: This is missing the backend part of the host, and we are moving away from single backend configurations.","commit_id":"9845a95a2520a03e06c582a4a88ffcc6c3d5cf6d"}]}