)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"291bf02f3c90ab8ef16279f4e610060ea0b98a1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoqin Li \u003clixqin@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-25 18:03:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: remove SCSI LUN ID during volume attaching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VDisk-to-host mapping may be fail due to the SCSI LUN"},{"line_number":10,"context_line":"id is already uesed by other VDisk mapping to this host,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_f689aacb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2016-09-12 05:30:24.000000000","message":"commit header should be limited to 50 characters","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"92c0c62c936bf7f861b3caabe2130417ac1d831a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xiaoqin Li \u003clixqin@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-25 18:03:53 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: remove SCSI LUN ID during volume attaching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VDisk-to-host mapping may be fail due to the SCSI LUN"},{"line_number":10,"context_line":"id is already uesed by other VDisk mapping to this host,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_28c64b49","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"9a89bdaa_f689aacb","updated":"2016-09-12 08:28:45.000000000","message":"Hi Alon, thanks a lot for your review. It is addressed in new patch.","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"291bf02f3c90ab8ef16279f4e610060ea0b98a1d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: remove SCSI LUN ID during volume attaching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VDisk-to-host mapping may be fail due to the SCSI LUN"},{"line_number":10,"context_line":"id is already uesed by other VDisk mapping to this host,"},{"line_number":11,"context_line":"which is caused by serveral cinder volume nodes run"},{"line_number":12,"context_line":"parallelly and serveral volumes attaching parallelly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"storwize volume driver does not need to calculate SCSI LUN"},{"line_number":15,"context_line":"ID locally for volume attaching. The SCSI LUN ID can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_96669e27","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":53},"updated":"2016-09-12 05:30:24.000000000","message":"text/typo fixes:\nThe VDisk-to-host mapping may fail due to SCSI LUN id\nbeing used by another VDisk mapping to this host.\nThis is caused by several cinder volume nodes running\nin parallel and several volumes attaching in parallel.","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"92c0c62c936bf7f861b3caabe2130417ac1d831a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Storwize: remove SCSI LUN ID during volume attaching"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VDisk-to-host mapping may be fail due to the SCSI LUN"},{"line_number":10,"context_line":"id is already uesed by other VDisk mapping to this host,"},{"line_number":11,"context_line":"which is caused by serveral cinder volume nodes run"},{"line_number":12,"context_line":"parallelly and serveral volumes attaching parallelly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"storwize volume driver does not need to calculate SCSI LUN"},{"line_number":15,"context_line":"ID locally for volume attaching. The SCSI LUN ID can be"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_88dd9716","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":53},"in_reply_to":"9a89bdaa_96669e27","updated":"2016-09-12 08:28:45.000000000","message":"Thanks! It is addressed in new patch.","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"dabfa9c5235f7598e0aeec66aea9f7891ff55950","unresolved":false,"context_lines":[{"line_number":5216,"context_line":""},{"line_number":5217,"context_line":"        ret \u003d self.storwize_ssh.mkvdiskhostmap(\u0027HOST3\u0027, \u00279999\u0027, None, True)"},{"line_number":5218,"context_line":"        result_lun \u003d self.storwize_ssh.get_vdiskhostmapid(\u00279999\u0027, \u0027HOST3\u0027)"},{"line_number":5219,"context_line":"        self.assertEqual(result_lun, ret)"},{"line_number":5220,"context_line":""},{"line_number":5221,"context_line":"        with mock.patch.object("},{"line_number":5222,"context_line":"                storwize_svc_common.StorwizeSSH,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_7242eb11","line":5219,"updated":"2016-09-15 14:23:18.000000000","message":"ddt would be great here.\n\nBut more importantly, mkvdiskhostmap internally calls get_vdiskhostmapid, so it doesn\u0027t look like this is really testing anything. It would be better to call mkvdiskhostmap can verify that the result contains expected data. As long as you can do that in a way that is not just verifying that mock returns what you told it to mock.","commit_id":"0b67a7704fab0e47b226130ec68b3d19743b2df8"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"9b6609b20e312dc0980e224a6ac0744c8eeedc42","unresolved":false,"context_lines":[{"line_number":5216,"context_line":""},{"line_number":5217,"context_line":"        ret \u003d self.storwize_ssh.mkvdiskhostmap(\u0027HOST3\u0027, \u00279999\u0027, None, True)"},{"line_number":5218,"context_line":"        result_lun \u003d self.storwize_ssh.get_vdiskhostmapid(\u00279999\u0027, \u0027HOST3\u0027)"},{"line_number":5219,"context_line":"        self.assertEqual(result_lun, ret)"},{"line_number":5220,"context_line":""},{"line_number":5221,"context_line":"        with mock.patch.object("},{"line_number":5222,"context_line":"                storwize_svc_common.StorwizeSSH,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_9b1abdc4","line":5219,"in_reply_to":"7a8ec9b2_7242eb11","updated":"2016-09-19 08:55:41.000000000","message":"Hi Sean. Thanks a lot for your review. Yes. change the test to verify that the mkvdiskhostmap return value equals to expected value directly.\nddt is not used here due to we just want to fill data to _volumes_list and _hosts_list across the test, no matter how many times _volumes_list and _hosts_list are used, the value does not change.","commit_id":"0b67a7704fab0e47b226130ec68b3d19743b2df8"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"291bf02f3c90ab8ef16279f4e610060ea0b98a1d","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            if mapping_info[\u0027host_name\u0027] \u003d\u003d host:"},{"line_number":368,"context_line":"                lun_id \u003d mapping_info[\u0027SCSI_id\u0027]"},{"line_number":369,"context_line":"                return True, lun_id"},{"line_number":370,"context_line":"        return False, None"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def rmhost(self, host):"},{"line_number":373,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmhost\u0027, \u0027\"%s\"\u0027 % host]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_f93a7bcc","line":370,"range":{"start_line":370,"start_character":8,"end_line":370,"end_character":26},"updated":"2016-09-12 05:30:24.000000000","message":"No need for returning tuple in this function. if lun_id is returned then the function succeeded, right?","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"},{"author":{"_account_id":17045,"name":"xiaoqin","email":"xiaoqin.li@hotmail.com","username":"xiaoqin"},"change_message_id":"92c0c62c936bf7f861b3caabe2130417ac1d831a","unresolved":false,"context_lines":[{"line_number":367,"context_line":"            if mapping_info[\u0027host_name\u0027] \u003d\u003d host:"},{"line_number":368,"context_line":"                lun_id \u003d mapping_info[\u0027SCSI_id\u0027]"},{"line_number":369,"context_line":"                return True, lun_id"},{"line_number":370,"context_line":"        return False, None"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def rmhost(self, host):"},{"line_number":373,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027rmhost\u0027, \u0027\"%s\"\u0027 % host]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_481b8f1b","line":370,"range":{"start_line":370,"start_character":8,"end_line":370,"end_character":26},"in_reply_to":"9a89bdaa_f93a7bcc","updated":"2016-09-12 08:28:45.000000000","message":"Hi Alon, thanks a lot for your review. It is addressed in new patch.","commit_id":"8fb6eb6caccdaa8a60556f2d77678f4a1044fd5d"}]}