)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":22257,"name":"Manish","email":"deolalkar.manish@hpe.com","username":"manishd"},"change_message_id":"202e4052a8d10090e3e1d6e30f4ddb14912c3eec","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"                                                       volume.volume_type_id)"},{"line_number":1363,"context_line":"        migrate_availability_zone \u003d {\u0027availability_zone\u0027:"},{"line_number":1364,"context_line":"                                     dest_availability_zone}"},{"line_number":1365,"context_line":"        if migrate_availability_zone and CONF.enable_cross_az_migrate:"},{"line_number":1366,"context_line":"            volume.update(migrate_availability_zone)"},{"line_number":1367,"context_line":"        request_spec \u003d {\u0027volume_properties\u0027: volume,"},{"line_number":1368,"context_line":"                        \u0027volume_type\u0027: volume_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_f82a598f","line":1365,"range":{"start_line":1365,"start_character":11,"end_line":1365,"end_character":36},"updated":"2016-08-29 10:51:27.000000000","message":"\u0027if migrate_availability_zone\u0027  will always result to True as we are defining on the previous line. What is the expected behaviour here ?","commit_id":"6bf815ab055b4489f9c33e621d68ff8178103c68"},{"author":{"_account_id":12184,"name":"Weiwei Gu","email":"gu.weiwei@zte.com.cn","username":"guweiwei"},"change_message_id":"f4df18aeacd0b563680ed2d8970a5463b156d844","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"                                                       volume.volume_type_id)"},{"line_number":1363,"context_line":"        migrate_availability_zone \u003d {\u0027availability_zone\u0027:"},{"line_number":1364,"context_line":"                                     dest_availability_zone}"},{"line_number":1365,"context_line":"        if migrate_availability_zone and CONF.enable_cross_az_migrate:"},{"line_number":1366,"context_line":"            volume.update(migrate_availability_zone)"},{"line_number":1367,"context_line":"        request_spec \u003d {\u0027volume_properties\u0027: volume,"},{"line_number":1368,"context_line":"                        \u0027volume_type\u0027: volume_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_14116804","line":1365,"range":{"start_line":1365,"start_character":11,"end_line":1365,"end_character":36},"in_reply_to":"fa7ab95a_f82a598f","updated":"2016-09-02 08:53:30.000000000","message":"It will update the volume\u0027s migrate_availability_zone with dest_availability_zone.","commit_id":"6bf815ab055b4489f9c33e621d68ff8178103c68"},{"author":{"_account_id":22257,"name":"Manish","email":"deolalkar.manish@hpe.com","username":"manishd"},"change_message_id":"87c4f6d472775a527b556ddf4e925c982d2a35ad","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"                                                       volume.volume_type_id)"},{"line_number":1385,"context_line":"        migrate_availability_zone \u003d {\u0027availability_zone\u0027:"},{"line_number":1386,"context_line":"                                     dest_availability_zone}"},{"line_number":1387,"context_line":"        if migrate_availability_zone and CONF.enable_cross_az_migrate:"},{"line_number":1388,"context_line":"            volume.update(migrate_availability_zone)"},{"line_number":1389,"context_line":"        request_spec \u003d {\u0027volume_properties\u0027: volume,"},{"line_number":1390,"context_line":"                        \u0027volume_type\u0027: volume_type,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_d40c633d","line":1387,"range":{"start_line":1387,"start_character":0,"end_line":1387,"end_character":70},"updated":"2016-09-07 10:44:46.000000000","message":"\u0027if migrate_availability_zone\u0027 will always return True because you have assigned it in a dict on the previous line, so instead of this statement we can just write it as below: \n\nif CONF.enable_cross_az_migrate:\nOR\nif dest_availability_zone and CONF.enable_cross_az_migrate:\n    volume.update(migrate_availability_zone)","commit_id":"93abd0ed1fb5d6427ab344c45284a8f8ad3e05a7"}]}