)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5fae37b1624eddc836b3d7c4a45debd010b60134","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vinita \u003cVinita.Deshpande@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-29 15:58:39 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CoprHD: Handle create volume from snapshot error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix generates the appropriate error message when the user tries"},{"line_number":10,"context_line":"creating a volume from snapshot which is a part of a Consistency Group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_affa3e73","line":7,"updated":"2016-08-29 12:51:39.000000000","message":"Should probably call out that this is for the cgsnapshot case, and not the normal create volume from snapshot flow.","commit_id":"fc020893157cd50e1fe10f736081236e1d99ddc5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5d59a67d2c99e1a0d1fef649d8c9badf51fe3557","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     vinita \u003cVinita.Deshpande@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-29 19:22:29 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"CoprHD: Handle create volume from snapshot error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This fix generates the appropriate error message when the user tries"},{"line_number":10,"context_line":"creating a volume from snapshot which is a part of a Consistency Group."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_23056213","line":7,"updated":"2016-08-29 14:28:36.000000000","message":"Please mention this is for cgsnapshots in the summary line.","commit_id":"7044d6c703774da1087462099d41fa1fe7b68b52"}],"cinder/volume/drivers/coprhd/common.py":[{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"9309fb92935569dba4eecaac93eb8d653198a1ad","unresolved":false,"context_lines":[{"line_number":755,"context_line":"                raise coprhd_utils.CoprHdError("},{"line_number":756,"context_line":"                    coprhd_utils.CoprHdError.SOS_FAILURE_ERR,"},{"line_number":757,"context_line":"                    _(\"Volume cannot be created individually from a snapshot\""},{"line_number":758,"context_line":"                      \" that is part of a Consistency Group\"))"},{"line_number":759,"context_line":"        except KeyError as e:"},{"line_number":760,"context_line":"            pass"},{"line_number":761,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_a760a802","line":758,"range":{"start_line":758,"start_character":42,"end_line":758,"end_character":59},"updated":"2016-08-29 12:17:03.000000000","message":"Is there mean snapshot in cgsnapshot, not Consistency Group?","commit_id":"fc020893157cd50e1fe10f736081236e1d99ddc5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5fae37b1624eddc836b3d7c4a45debd010b60134","unresolved":false,"context_lines":[{"line_number":755,"context_line":"                raise coprhd_utils.CoprHdError("},{"line_number":756,"context_line":"                    coprhd_utils.CoprHdError.SOS_FAILURE_ERR,"},{"line_number":757,"context_line":"                    _(\"Volume cannot be created individually from a snapshot\""},{"line_number":758,"context_line":"                      \" that is part of a Consistency Group\"))"},{"line_number":759,"context_line":"        except KeyError as e:"},{"line_number":760,"context_line":"            pass"},{"line_number":761,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_8fb73af4","line":758,"range":{"start_line":758,"start_character":42,"end_line":758,"end_character":59},"in_reply_to":"fa7ab95a_a760a802","updated":"2016-08-29 12:51:39.000000000","message":"I think the wording here is fine as end users will be more familiar with the term \"consistency group\" than cgsnapshot.","commit_id":"fc020893157cd50e1fe10f736081236e1d99ddc5"},{"author":{"_account_id":18026,"name":"huanan","email":"huanan@huawei.com","username":"huanan"},"change_message_id":"9309fb92935569dba4eecaac93eb8d653198a1ad","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    _(\"Volume cannot be created individually from a snapshot\""},{"line_number":758,"context_line":"                      \" that is part of a Consistency Group\"))"},{"line_number":759,"context_line":"        except KeyError as e:"},{"line_number":760,"context_line":"            pass"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        src_snapshot_name \u003d None"},{"line_number":763,"context_line":"        src_vol_ref \u003d snapshot[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_99230ca7","line":760,"range":{"start_line":760,"start_character":11,"end_line":760,"end_character":16},"updated":"2016-08-29 12:17:03.000000000","message":"Here should add error log.","commit_id":"fc020893157cd50e1fe10f736081236e1d99ddc5"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5fae37b1624eddc836b3d7c4a45debd010b60134","unresolved":false,"context_lines":[{"line_number":757,"context_line":"                    _(\"Volume cannot be created individually from a snapshot\""},{"line_number":758,"context_line":"                      \" that is part of a Consistency Group\"))"},{"line_number":759,"context_line":"        except KeyError as e:"},{"line_number":760,"context_line":"            pass"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        src_snapshot_name \u003d None"},{"line_number":763,"context_line":"        src_vol_ref \u003d snapshot[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_afa5dea2","line":760,"range":{"start_line":760,"start_character":11,"end_line":760,"end_character":16},"in_reply_to":"fa7ab95a_99230ca7","updated":"2016-08-29 12:51:39.000000000","message":"It should be fine to pass without logging since cgsnapshot_id might not be there and if it is not, we don\u0027t really care.\n\nIt might clean things up a bit though if you change line 754 to be:\n\nif snapshot.get(\u0027cgsnapshot_id\u0027):\n\nThat would eliminate the need to have a try/except block for a KeyError.","commit_id":"fc020893157cd50e1fe10f736081236e1d99ddc5"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"ab79b37c8954af8116f64abeaec56a2db4a836a3","unresolved":false,"context_lines":[{"line_number":754,"context_line":"            raise coprhd_utils.CoprHdError("},{"line_number":755,"context_line":"                coprhd_utils.CoprHdError.SOS_FAILURE_ERR,"},{"line_number":756,"context_line":"                _(\"Volume cannot be created individually from a snapshot\""},{"line_number":757,"context_line":"                  \" that is part of a Consistency Group\"))"},{"line_number":758,"context_line":""},{"line_number":759,"context_line":"        src_snapshot_name \u003d None"},{"line_number":760,"context_line":"        src_vol_ref \u003d snapshot[\u0027volume\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_2338ec3c","line":757,"range":{"start_line":757,"start_character":19,"end_line":757,"end_character":20},"updated":"2016-08-29 19:30:00.000000000","message":"Nit: this space should be in the end of the string.","commit_id":"a8abea67eb3f2e8d35ee2798c16c394ba63d309e"}]}