)]}'
{"cinder/tests/unit/volume/drivers/netapp/eseries/test_library.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"827b77d0537922e3c58c33a852e358fa0a2a16a7","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"            bitset.set(i)"},{"line_number":2005,"context_line":"        snapshots.append(snap)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        filtered_snaps \u003d [x for x in snapshots if x[\u0027pitGroupRef\u0027] \u003d\u003d snap["},{"line_number":2008,"context_line":"            \u0027pitGroupRef\u0027]]"},{"line_number":2009,"context_line":""},{"line_number":2010,"context_line":"        self.mock_object(self.library, \u0027_get_volume\u0027, mock.Mock("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_e7d42ded","line":2007,"updated":"2016-08-30 09:38:46.000000000","message":"nit: This would be more readable written as:\n\n filtered_snaps \u003d [x for x in snapshots\n                   if x[\u0027pitGroupRef\u0027] \u003d\u003d snap[\u0027pitGroupRef\u0027]]","commit_id":"d27ba20f62663ac95f867808672b5c87a66abcb1"}],"cinder/volume/drivers/netapp/dataontap/utils/data_motion.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"827b77d0537922e3c58c33a852e358fa0a2a16a7","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        The \u0027slowest\u0027 mirror determines the best update that occurred on a"},{"line_number":550,"context_line":"        given replication target."},{"line_number":551,"context_line":"        \"\"\""},{"line_number":552,"context_line":"        filtered_mirrors \u003d ["},{"line_number":553,"context_line":"            x for x in mirrors if x.get(\u0027destination-volume\u0027) in flexvols"},{"line_number":554,"context_line":"        ]"},{"line_number":555,"context_line":"        sorted_mirrors \u003d sorted(filtered_mirrors,"},{"line_number":556,"context_line":"                                key\u003dlambda x: int(x.get(\u0027lag-time\u0027)),"},{"line_number":557,"context_line":"                                reverse\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_677c9dec","line":554,"range":{"start_line":552,"start_character":0,"end_line":554,"end_character":9},"updated":"2016-08-30 09:38:46.000000000","message":"nit: More readable form:\n\n filtered_mirrors \u003d [x for x in mirrors\n                     if x.get(\u0027destination-volume\u0027) in flexvols]","commit_id":"d27ba20f62663ac95f867808672b5c87a66abcb1"},{"author":{"_account_id":20191,"name":"Dinesh Bhor","email":"bhordinesh07@gmail.com","username":"dineshbhor"},"change_message_id":"a45d18a288236a43b4811918795e40a82b7d6587","unresolved":false,"context_lines":[{"line_number":547,"context_line":"        The \u0027slowest\u0027 mirror determines the best update that occurred on a"},{"line_number":548,"context_line":"        given replication target."},{"line_number":549,"context_line":"        \"\"\""},{"line_number":550,"context_line":"        filtered_mirrors \u003d [x for x in mirrors"},{"line_number":551,"context_line":"                            if x.get(\u0027destination-volume\u0027) in flexvols]"},{"line_number":552,"context_line":"        sorted_mirrors \u003d sorted(filtered_mirrors,"},{"line_number":553,"context_line":"                                key\u003dlambda x: int(x.get(\u0027lag-time\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_84f522ee","line":550,"range":{"start_line":550,"start_character":27,"end_line":550,"end_character":30},"updated":"2016-11-11 06:32:57.000000000","message":"I think there are more such occurrences where we need to make changes:\n\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/solidfire.py#L1923\n\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/solidfire.py#L1918\n\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/targets/scst.py#L267","commit_id":"0b098ee84d44f4a762a62b7270eb1a63b494e6aa"}]}