)]}'
{"cinder/volume/manager.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c6f81b7595380b4ecf5bd032400dbb6aa180f875","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        try:"},{"line_number":808,"context_line":"            LOG.info(_(\"volume %s: extending\"), volume_ref[\u0027name\u0027])"},{"line_number":809,"context_line":"            self.driver.extend_volume(volume_ref, new_size)"},{"line_number":810,"context_line":"        except Exception:"},{"line_number":811,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":812,"context_line":"                self.db.volume_update(context,"},{"line_number":813,"context_line":"                                      volume_ref[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F4uU%3D","line":810,"updated":"2013-07-09 19:24:00.000000000","message":"I wonder if it would be better to LOG.exception here and pass rather than dump the trace in the log files?","commit_id":"8894f6fa233ccda0ab35e2bf063b4255a182af04"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"cd10f09ed673514edaca1f6dda644cb69e9dbb52","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        try:"},{"line_number":808,"context_line":"            LOG.info(_(\"volume %s: extending\"), volume_ref[\u0027name\u0027])"},{"line_number":809,"context_line":"            self.driver.extend_volume(volume_ref, new_size)"},{"line_number":810,"context_line":"        except Exception:"},{"line_number":811,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":812,"context_line":"                self.db.volume_update(context,"},{"line_number":813,"context_line":"                                      volume_ref[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F4rw%3D","line":810,"in_reply_to":"AAAAP3%2F%2F4uU%3D","updated":"2013-07-09 19:34:45.000000000","message":"Done","commit_id":"8894f6fa233ccda0ab35e2bf063b4255a182af04"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"e5a3e6c2681b35cdc88b45694aab6b9e64923db7","unresolved":false,"context_lines":[{"line_number":812,"context_line":"                          volume_id)"},{"line_number":813,"context_line":"            self.db.volume_update(context, volume_ref[\u0027id\u0027],"},{"line_number":814,"context_line":"                                  {\u0027status\u0027: \u0027error_extending\u0027})"},{"line_number":815,"context_line":"            return"},{"line_number":816,"context_line":"        LOG.info(_(\"volume %s: extended successfully\"), volume_ref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2FvmA%3D","line":815,"updated":"2013-07-12 03:01:04.000000000","message":"This is a good case for using else instead of later having to return inside each catch block.","commit_id":"5439df9cde4944fac554164c33fa13957fd2ee51"}]}