)]}'
{"cinder/tests/test_solidfire.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0157815bdde6e25e2d7828e29762260c70972fda","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                   \u0027id\u0027: \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027}"},{"line_number":305,"context_line":"        sfv \u003d SolidFire(configuration\u003dself.configuration)"},{"line_number":306,"context_line":"        try:"},{"line_number":307,"context_line":"            sfv.extend_volume(testvol, 2)"},{"line_number":308,"context_line":"            self.fail(\"Should have thrown Error\")"},{"line_number":309,"context_line":"        except Exception:"},{"line_number":310,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F3Is%3D","line":307,"updated":"2013-07-10 09:13:44.000000000","message":"I don\u0027t think this test is doing what you want. What seems to be happening is that extend_volume() is not throwing, then self.fail() throws, that exception is being caught  at line 309 and not being reported.","commit_id":"7d4e0975601830067911e95a2a94b136613b4d40"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"ee66be34be474b1b2bad3624b16dc8c88b2b24d4","unresolved":false,"context_lines":[{"line_number":304,"context_line":"                   \u0027id\u0027: \u0027a720b3c0-d1f0-11e1-9b23-0800200c9a66\u0027}"},{"line_number":305,"context_line":"        sfv \u003d SolidFire(configuration\u003dself.configuration)"},{"line_number":306,"context_line":"        try:"},{"line_number":307,"context_line":"            sfv.extend_volume(testvol, 2)"},{"line_number":308,"context_line":"            self.fail(\"Should have thrown Error\")"},{"line_number":309,"context_line":"        except Exception:"},{"line_number":310,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F15M%3D","line":307,"in_reply_to":"AAAAP3%2F%2F3Is%3D","updated":"2013-07-10 15:25:54.000000000","message":"Done","commit_id":"7d4e0975601830067911e95a2a94b136613b4d40"}],"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"0157815bdde6e25e2d7828e29762260c70972fda","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                                       params, version\u003d\u00275.0\u0027)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if \u0027result\u0027 not in data:"},{"line_number":606,"context_line":"            raise exception.SolidFireAPIDataException(data\u003ddata)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        LOG.debug(_(\"Leaving SolidFire extend_volume\"))"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F3JM%3D","line":606,"updated":"2013-07-10 09:13:44.000000000","message":"Why not log an error before this raise, in the same way you did at line 594 above","commit_id":"7d4e0975601830067911e95a2a94b136613b4d40"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"ee66be34be474b1b2bad3624b16dc8c88b2b24d4","unresolved":false,"context_lines":[{"line_number":603,"context_line":"                                       params, version\u003d\u00275.0\u0027)"},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"        if \u0027result\u0027 not in data:"},{"line_number":606,"context_line":"            raise exception.SolidFireAPIDataException(data\u003ddata)"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        LOG.debug(_(\"Leaving SolidFire extend_volume\"))"},{"line_number":609,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F15A%3D","line":606,"in_reply_to":"AAAAP3%2F%2F3JM%3D","updated":"2013-07-10 15:25:54.000000000","message":"SolidFireAPIDataException are not logged in the driver. Should they be?","commit_id":"7d4e0975601830067911e95a2a94b136613b4d40"}]}