)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10ad15ebf7c82ca8cac446028f024839177922da","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Helen Walsh \u003chelen.walsh@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-31 10:58:45 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX driver - Snapshot naming convention fix."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver uses code in create_snapshot and"},{"line_number":10,"context_line":"delete_snapshot that is not conventional. The volumeid"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_eea48109","line":7,"updated":"2016-09-01 02:36:19.000000000","message":"VMAX driver - Retrieve volume from snapshot","commit_id":"13fbe2b17db9db42ea1979bc16ac1cc834269bf7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"10ad15ebf7c82ca8cac446028f024839177922da","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX driver - Snapshot naming convention fix."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver uses code in create_snapshot and"},{"line_number":10,"context_line":"delete_snapshot that is not conventional. The volumeid"},{"line_number":11,"context_line":"is not guaranteed to be in the volume name like that."},{"line_number":12,"context_line":"To fix the issue, the source volume should be retrieved"},{"line_number":13,"context_line":"from the snapshot object itself."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I99ebecb27d82d5a967369a04bf2c34158e6670ec"},{"line_number":16,"context_line":"Closes-Bug: #1616133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_ee6d61cd","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":32},"updated":"2016-09-01 02:36:19.000000000","message":"Please reword the above to the following:\n\nThe VMAX driver retrieves volume id from snapshot[\u0027volume_name\u0027] in create_snapshot and delete_snapshot and then gets volume from db using the volume id.  If the volume_name is changed, volume id may not be in it any more.  This is not a reliable way of getting volume id.  Also a driver should not access db directly.\n\nIn this patch, the source volume is retrieved from snapshot without parsing the volume name for volume id and accessing db.","commit_id":"13fbe2b17db9db42ea1979bc16ac1cc834269bf7"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"30f0e4a8aad904bedc1210505e021c29452feae4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMAX driver - Snapshot naming convention fix."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver uses code in create_snapshot and"},{"line_number":10,"context_line":"delete_snapshot that is not conventional. The volumeid"},{"line_number":11,"context_line":"is not guaranteed to be in the volume name like that."},{"line_number":12,"context_line":"To fix the issue, the source volume should be retrieved"},{"line_number":13,"context_line":"from the snapshot object itself."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I99ebecb27d82d5a967369a04bf2c34158e6670ec"},{"line_number":16,"context_line":"Closes-Bug: #1616133"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_6dbf7760","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":32},"in_reply_to":"fa7ab95a_ee6d61cd","updated":"2016-09-01 13:30:44.000000000","message":"Thanks Xing, we will change","commit_id":"13fbe2b17db9db42ea1979bc16ac1cc834269bf7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5e4beac157b39094d61243ade44ea28ead54b371","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The VMAX driver retrieves volume id from snapshot[\u0027volume_name\u0027] in"},{"line_number":10,"context_line":"create_snapshot and delete_snapshot and then gets volume from db using"},{"line_number":11,"context_line":"the volume id.  If the volume_name is changed, volume id may not be in"},{"line_number":12,"context_line":"it any more.  This is not a reliable way of getting volume id.  "},{"line_number":13,"context_line":"Also a driver should not access db directly. In this patch, the source"},{"line_number":14,"context_line":"volume is retrieved from snapshot without parsing the volume name for"},{"line_number":15,"context_line":"volume id and accessing db."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_f4933259","line":12,"updated":"2016-09-02 00:32:27.000000000","message":"Please remove blank space at the end.","commit_id":"a29a60f9fdb7c856458bd1b3ff91f5b7188e295c"}],"cinder/tests/unit/volume/drivers/emc/test_emc_vmax.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5e4beac157b39094d61243ade44ea28ead54b371","unresolved":false,"context_lines":[{"line_number":6061,"context_line":"        \u0027get_volume_type_extra_specs\u0027,"},{"line_number":6062,"context_line":"        return_value\u003d{\u0027volume_backend_name\u0027: \u0027V3_BE\u0027})"},{"line_number":6063,"context_line":"    def test_create_snapshot_v3_success("},{"line_number":6064,"context_line":"            self, mock_type, moke_pool):"},{"line_number":6065,"context_line":"        common \u003d self.driver.common"},{"line_number":6066,"context_line":"        common.provisionv3.utils.get_v3_default_sg_instance_name \u003d mock.Mock("},{"line_number":6067,"context_line":"            return_value\u003d(None, None, self.data.default_sg_instance_name))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa7ab95a_d4a46ea7","line":6064,"updated":"2016-09-02 00:32:27.000000000","message":"s/moke_pool/mock_pool","commit_id":"a29a60f9fdb7c856458bd1b3ff91f5b7188e295c"}]}