)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"698160daf3c211e04e4baa7e1a47b4d861e25038","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in a previouse fix."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6cefe55c4632f424f610f826a5bb62edc29d9127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_02f4fb84","line":9,"updated":"2016-09-01 12:45:43.000000000","message":"Please reference the patch that introduced this bug.\n\nAlso please open a bug report.","commit_id":"a160479856de37b2b1a211dbca55ccbd38b3eb7c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"868fed2de5d1dff00fd06657b7d3c22aa1e42e3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in a previouse fix."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I6cefe55c4632f424f610f826a5bb62edc29d9127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa7ab95a_04fde839","line":9,"in_reply_to":"fa7ab95a_02f4fb84","updated":"2016-09-01 13:24:11.000000000","message":"Done","commit_id":"a160479856de37b2b1a211dbca55ccbd38b3eb7c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1ca4b7f395ee6ca5fcbadc1b0bcb3c484160f8de","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in ://review.openstack.org/#/c/346831/"},{"line_number":10,"context_line":"- add unit test to prevent regression"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1619283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_2bd9a2f3","line":9,"updated":"2016-09-02 11:12:24.000000000","message":"-1: This is not telling what the bug does or what the fix is, and the LP bug says as little as this commit message does.","commit_id":"37364cc9da7ba46f4c1af30bbead68bac9a505c2"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"539d66cd2932d57157d922708a2c261443c8023d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in ://review.openstack.org/#/c/346831/"},{"line_number":10,"context_line":"- add unit test to prevent regression"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1619283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_70523a15","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":34},"updated":"2016-09-05 08:25:48.000000000","message":"trivial: missing https\n\nI agree with Gorka - something as simple as \"the client API is called with an incorrect parameter\" makes reviewing the change log much easier.","commit_id":"37364cc9da7ba46f4c1af30bbead68bac9a505c2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"57d6a38b5760c855d3df1daf93f5ce8c604b1d28","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in ://review.openstack.org/#/c/346831/"},{"line_number":10,"context_line":"- add unit test to prevent regression"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1619283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_966887f7","line":9,"in_reply_to":"9a89bdaa_3093485d","updated":"2016-09-05 13:59:09.000000000","message":"I agree, the fix is trivial, but commit messages and LP bugs should contain relevant information about bugs so they can be easily tracked/searched by anyone looking for a specific issue.","commit_id":"37364cc9da7ba46f4c1af30bbead68bac9a505c2"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"c763527be0db8d49a2b78dcbb9b12b293f2f8151","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in ://review.openstack.org/#/c/346831/"},{"line_number":10,"context_line":"- add unit test to prevent regression"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1619283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_50a0cc9f","line":9,"range":{"start_line":9,"start_character":31,"end_line":9,"end_character":34},"in_reply_to":"9a89bdaa_70523a15","updated":"2016-09-05 11:44:57.000000000","message":"Done","commit_id":"37364cc9da7ba46f4c1af30bbead68bac9a505c2"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"c763527be0db8d49a2b78dcbb9b12b293f2f8151","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- was introduced by mistake in ://review.openstack.org/#/c/346831/"},{"line_number":10,"context_line":"- add unit test to prevent regression"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1619283"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_3093485d","line":9,"in_reply_to":"fa7ab95a_2bd9a2f3","updated":"2016-09-05 11:44:57.000000000","message":"sorry, thought this was trivial","commit_id":"37364cc9da7ba46f4c1af30bbead68bac9a505c2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7a7705462f62b7f39cbdda01e69c51309998bd60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"XtremIO: fix bug deleting cgsnapshot"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the client API is called with method DELETED intead of DELETE"},{"line_number":10,"context_line":"- was introduced by mistake in https://review.openstack.org/#/c/346831/"},{"line_number":11,"context_line":"- add unit test to prevent regression"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a89bdaa_f602b33d","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":51},"updated":"2016-09-05 13:59:40.000000000","message":"nit: instead","commit_id":"4fb27ce20d222c239b5b247285436f1ac93599ee"}],"cinder/volume/drivers/emc/xtremio.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"698160daf3c211e04e4baa7e1a47b4d861e25038","unresolved":false,"context_lines":[{"line_number":783,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":784,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""},{"line_number":785,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, \u0027DELETE\u0027,"},{"line_number":786,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        return None, None"},{"line_number":789,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_22073f1d","line":786,"updated":"2016-09-01 12:45:43.000000000","message":"Can you add a small unit test for this to avoid regression? Something like this:\n\n# mock client.req\ndef test_delete_cgsnapshot(self, mock_delete):\n# Call delete_cgsnapshot\nmock_delete.assert_called_once_with(\u0027snapshot-sets\u0027, \u0027DELETE\u0027, ….)\n# Check return value of delete_cgsnapshot","commit_id":"a160479856de37b2b1a211dbca55ccbd38b3eb7c"},{"author":{"_account_id":11418,"name":"Shay Halsband","email":"shay.halsband@emc.com","username":"shyh"},"change_message_id":"868fed2de5d1dff00fd06657b7d3c22aa1e42e3d","unresolved":false,"context_lines":[{"line_number":783,"context_line":"    def delete_cgsnapshot(self, context, cgsnapshot, snapshots):"},{"line_number":784,"context_line":"        \"\"\"Deletes a cgsnapshot.\"\"\""},{"line_number":785,"context_line":"        self.client.req(\u0027snapshot-sets\u0027, \u0027DELETE\u0027,"},{"line_number":786,"context_line":"                        name\u003dself._get_cgsnap_name(cgsnapshot), ver\u003d\u0027v2\u0027)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        return None, None"},{"line_number":789,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_47a1b2a8","line":786,"in_reply_to":"fa7ab95a_22073f1d","updated":"2016-09-01 13:24:11.000000000","message":"Done","commit_id":"a160479856de37b2b1a211dbca55ccbd38b3eb7c"}]}