)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"fb9103213300928736890342dd68107f9d286d68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cao ShuFeng \u003ccaosf.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 06:55:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove doc about two removed API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cinder v2 api doesn\u0027t doesn\u0027t support this two api[1][2]."},{"line_number":10,"context_line":"These 2 api had been removed in this patch[3]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_bfbfacce","line":7,"updated":"2016-09-02 12:26:44.000000000","message":"I think you might as well be explicit:\nRemove doc for promote/reenable replica","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e96412874a022338e69fd480cffe487446682413","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Cao ShuFeng \u003ccaosf.fnst@cn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-02 06:55:29 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove doc about two removed API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cinder v2 api doesn\u0027t doesn\u0027t support this two api[1][2]."},{"line_number":10,"context_line":"These 2 api had been removed in this patch[3]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_05e2a4d5","line":7,"in_reply_to":"fa7ab95a_bfbfacce","updated":"2016-09-04 04:38:45.000000000","message":"Done","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"fb9103213300928736890342dd68107f9d286d68","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove doc about two removed API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cinder v2 api doesn\u0027t doesn\u0027t support this two api[1][2]."},{"line_number":10,"context_line":"These 2 api had been removed in this patch[3]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We should update the doc about it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_7f70c440","line":9,"updated":"2016-09-02 12:26:44.000000000","message":"And you can be explicit here:\nCinder v2 api no longer supports replication 1.0 and the apis\nfor os-promote-replica and os-reenable-replica [1][2].","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e96412874a022338e69fd480cffe487446682413","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove doc about two removed API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"cinder v2 api doesn\u0027t doesn\u0027t support this two api[1][2]."},{"line_number":10,"context_line":"These 2 api had been removed in this patch[3]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We should update the doc about it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_e5dce01a","line":9,"in_reply_to":"fa7ab95a_7f70c440","updated":"2016-09-04 04:38:45.000000000","message":"Done","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"fb9103213300928736890342dd68107f9d286d68","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We should update the doc about it."},{"line_number":13,"context_line":"Trivial Fix"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]: http://developer.openstack.org/api-ref-blockstorage-v2.html#promotereplicaVolume"},{"line_number":16,"context_line":"[2]: http://developer.openstack.org/api-ref-blockstorage-v2.html#reenablereplicaVolume"},{"line_number":17,"context_line":"[3]: https://review.openstack.org/#/c/275797/35/cinder/api/contrib/volume_replication.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa7ab95a_ffe854b5","line":14,"updated":"2016-09-02 12:26:44.000000000","message":"I actually noticed that that volume/rpcapi.py still has promote_replica. This could be removed in this patch and, if you do, you should mention that in this commit.","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"e96412874a022338e69fd480cffe487446682413","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"We should update the doc about it."},{"line_number":13,"context_line":"Trivial Fix"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"[1]: http://developer.openstack.org/api-ref-blockstorage-v2.html#promotereplicaVolume"},{"line_number":16,"context_line":"[2]: http://developer.openstack.org/api-ref-blockstorage-v2.html#reenablereplicaVolume"},{"line_number":17,"context_line":"[3]: https://review.openstack.org/#/c/275797/35/cinder/api/contrib/volume_replication.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_a5c49840","line":14,"in_reply_to":"fa7ab95a_ffe854b5","updated":"2016-09-04 04:38:45.000000000","message":"Thanks for reminding me of this.\nYes, I think we need another patch to remove promote_replica/reenable_replication rpcapi.\nBut, I don\u0027t known how to solve the backward compatibility issue in such case:\n       old cinder-api service with newer cinder-volume service.\nSo I report a bug about this[1], may be someone else will be able to remove this rpcapi.\n\n[1] https://bugs.launchpad.net/cinder/+bug/1620001","commit_id":"442a3cdbb538daf06d98bd993d5453951bf0902d"}]}