)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e29a3e72b3e37dd21660e8a876c64a4868418e7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"module (e.g. a volume driver) grouped together)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The reasons for doing the change here, instead of e.g. sorting the options"},{"line_number":17,"context_line":"in oslo-config-generator are:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"1. Other projects that maintain their opts.py file manually are already"},{"line_number":20,"context_line":"   keeping the options specifically ordered in some way. Sorting them in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8ec9b2_d21c9f15","line":17,"updated":"2016-09-15 14:27:14.000000000","message":"Thanks for this explanation.","commit_id":"15f2d18e3e3bfce2d40523e1dca55ef504e78107"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9e29a3e72b3e37dd21660e8a876c64a4868418e7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   that logically belong together split across the entire file."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Id7169a045928ee7bedafec35905e5710f2fd5146"},{"line_number":31,"context_line":"Closes-Bug: #1535589"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8ec9b2_b27d531e","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":20},"updated":"2016-09-15 14:27:14.000000000","message":"Please remove this. This is not a bug, it\u0027s an enhancement.\n\nI do think it is a good enhancement though, especially trying to compare config files changes between upgrades.","commit_id":"15f2d18e3e3bfce2d40523e1dca55ef504e78107"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"1fe059585d5bb98a72ac5fcf3bd1e9a73ff4ab01","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   that logically belong together split across the entire file."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Id7169a045928ee7bedafec35905e5710f2fd5146"},{"line_number":31,"context_line":"Closes-Bug: #1535589"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a8ec9b2_e50473c1","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":20},"in_reply_to":"7a8ec9b2_b27d531e","updated":"2016-09-15 14:40:44.000000000","message":"Done","commit_id":"15f2d18e3e3bfce2d40523e1dca55ef504e78107"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"bf25af61642e047f782aa4daff0e69454b25d526","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sort options in cinder.conf by module name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Up to know generate_cinder_opts put the options in a (more or less) random"},{"line_number":10,"context_line":"order into the generated config file. This makes e.g. diffing config files of"},{"line_number":11,"context_line":"different cinder releases pretty hard."},{"line_number":12,"context_line":"This commit ensures that the options are ordered by the name of the module"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_a0b77938","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":10},"updated":"2016-09-16 15:30:00.000000000","message":"to know -\u003e till now ?","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"7ff0a7b65a1372a4c3cf01ccab126b4c302db3a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sort options in cinder.conf by module name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Up to know generate_cinder_opts put the options in a (more or less) random"},{"line_number":10,"context_line":"order into the generated config file. This makes e.g. diffing config files of"},{"line_number":11,"context_line":"different cinder releases pretty hard."},{"line_number":12,"context_line":"This commit ensures that the options are ordered by the name of the module"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_71a87220","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":10},"in_reply_to":"7a8ec9b2_a0b77938","updated":"2016-10-05 12:01:56.000000000","message":"Done","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"bf25af61642e047f782aa4daff0e69454b25d526","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sort options in cinder.conf by module name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Up to know generate_cinder_opts put the options in a (more or less) random"},{"line_number":10,"context_line":"order into the generated config file. This makes e.g. diffing config files of"},{"line_number":11,"context_line":"different cinder releases pretty hard."},{"line_number":12,"context_line":"This commit ensures that the options are ordered by the name of the module"},{"line_number":13,"context_line":"which they were defined in. (i.e. it will keep options defined in the same"},{"line_number":14,"context_line":"module (e.g. a volume driver) grouped together)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The reasons for doing the change here, instead of e.g. sorting the options"},{"line_number":17,"context_line":"in oslo-config-generator are:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"1. Other projects that maintain their opts.py file manually are already"},{"line_number":20,"context_line":"   keeping the options specifically ordered in some way. Sorting them in"},{"line_number":21,"context_line":"   oslo-config-generator will likely break that manually sorted order."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2. Sorting it here in cinder will ensure that all the options of e.g. a"},{"line_number":24,"context_line":"   specific driver will be kepts together. It basically sorts the options by"},{"line_number":25,"context_line":"   the driver name (or more specifically by the name of the module they\u0027re"},{"line_number":26,"context_line":"   defined in).  Sorting in the config-generator will really sort all options"},{"line_number":27,"context_line":"   of a section e.g.  [DEFAULT] alphabetically, which might result in options"},{"line_number":28,"context_line":"   that logically belong together split across the entire file."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Id7169a045928ee7bedafec35905e5710f2fd5146"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a8ec9b2_407f9565","line":28,"range":{"start_line":9,"start_character":68,"end_line":28,"end_character":63},"updated":"2016-09-16 15:30:00.000000000","message":"Please wrap body lines at 72 characters. Thanks!","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"7ff0a7b65a1372a4c3cf01ccab126b4c302db3a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sort options in cinder.conf by module name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Up to know generate_cinder_opts put the options in a (more or less) random"},{"line_number":10,"context_line":"order into the generated config file. This makes e.g. diffing config files of"},{"line_number":11,"context_line":"different cinder releases pretty hard."},{"line_number":12,"context_line":"This commit ensures that the options are ordered by the name of the module"},{"line_number":13,"context_line":"which they were defined in. (i.e. it will keep options defined in the same"},{"line_number":14,"context_line":"module (e.g. a volume driver) grouped together)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The reasons for doing the change here, instead of e.g. sorting the options"},{"line_number":17,"context_line":"in oslo-config-generator are:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"1. Other projects that maintain their opts.py file manually are already"},{"line_number":20,"context_line":"   keeping the options specifically ordered in some way. Sorting them in"},{"line_number":21,"context_line":"   oslo-config-generator will likely break that manually sorted order."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"2. Sorting it here in cinder will ensure that all the options of e.g. a"},{"line_number":24,"context_line":"   specific driver will be kepts together. It basically sorts the options by"},{"line_number":25,"context_line":"   the driver name (or more specifically by the name of the module they\u0027re"},{"line_number":26,"context_line":"   defined in).  Sorting in the config-generator will really sort all options"},{"line_number":27,"context_line":"   of a section e.g.  [DEFAULT] alphabetically, which might result in options"},{"line_number":28,"context_line":"   that logically belong together split across the entire file."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: Id7169a045928ee7bedafec35905e5710f2fd5146"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_91633e1a","line":28,"range":{"start_line":9,"start_character":68,"end_line":28,"end_character":63},"in_reply_to":"7a8ec9b2_407f9565","updated":"2016-10-05 12:01:56.000000000","message":"Done","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"}],"cinder/config/generate_cinder_opts.py":[{"author":{"_account_id":13404,"name":"Alberto Planas","email":"aplanas@gmail.com","username":"aplanas"},"change_message_id":"96f82cd9c62a935899aa9a6bb03749ecb6f30c70","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                     \"cinder/volume/configuration.py\","},{"line_number":82,"context_line":"                     \"cinder/test.py\"]:"},{"line_number":83,"context_line":"            continue"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        dirs_list \u003d atree.split(\u0027/\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        import_module \u003d \"from \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_ee951332","side":"PARENT","line":84,"updated":"2016-09-02 08:20:12.000000000","message":"nip: I would not remove the line","commit_id":"29e00a3c63e15cd87d60e6f7cdc661646e4cb816"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"191c403dac5be3437ef72be68119f2611d566c9f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                     \"cinder/volume/configuration.py\","},{"line_number":82,"context_line":"                     \"cinder/test.py\"]:"},{"line_number":83,"context_line":"            continue"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        dirs_list \u003d atree.split(\u0027/\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        import_module \u003d \"from \""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_630af427","side":"PARENT","line":84,"in_reply_to":"fa7ab95a_ee951332","updated":"2016-09-02 10:16:11.000000000","message":"Oops. Fixed.","commit_id":"29e00a3c63e15cd87d60e6f7cdc661646e4cb816"}],"cinder/opts.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c12047b6ac999b1539c67a4d0aee6db3a58a323a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            )),"},{"line_number":201,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":202,"context_line":"            itertools.chain("},{"line_number":203,"context_line":"                cinder_api_common.api_common_opts,"},{"line_number":204,"context_line":"                [cinder_api_middleware_auth.use_forwarded_for_opt],"},{"line_number":205,"context_line":"                [cinder_api_middleware_sizelimit.max_request_body_size_opt],"},{"line_number":206,"context_line":"                cinder_api_views_versions.versions_opts,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_348f682b","line":203,"updated":"2016-09-15 16:48:10.000000000","message":"If you declare this list as a variable such as DEFAULT_OPTS in this file (rather than in this method) and pass it here, then we can write a simple unit test to enforce that it stays in alphabetical order when new items are added.","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"},{"author":{"_account_id":2062,"name":"Ralf Haferkamp","email":"rhafer@suse.com","username":"rhafer"},"change_message_id":"e7ad2357d86e319c853bb071f1ec8078c27a32c2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"            )),"},{"line_number":201,"context_line":"        (\u0027DEFAULT\u0027,"},{"line_number":202,"context_line":"            itertools.chain("},{"line_number":203,"context_line":"                cinder_api_common.api_common_opts,"},{"line_number":204,"context_line":"                [cinder_api_middleware_auth.use_forwarded_for_opt],"},{"line_number":205,"context_line":"                [cinder_api_middleware_sizelimit.max_request_body_size_opt],"},{"line_number":206,"context_line":"                cinder_api_views_versions.versions_opts,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_14e8fce1","line":203,"in_reply_to":"7a8ec9b2_348f682b","updated":"2016-10-05 12:07:58.000000000","message":"I am not sure I really understand this suggestiong. This file is generated (by cinder/config/generate_cinder_opts.py using e.g. \"tox -egenopts\"). So even when options are added to cinder this file isn\u0027t ever manually touched.\n\nBut I might be misunderstanding you. If that\u0027s the case, please clarify.","commit_id":"4eca13f724ff22481aa65c2509440446bf8a469c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2da6847e461e25e788a8145ff1f49c6df0443710","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                [cinder_volume_api.az_cache_time_opt],"},{"line_number":246,"context_line":"                cinder_volume_driver.volume_opts,"},{"line_number":247,"context_line":"                cinder_volume_driver.iser_opts,"},{"line_number":248,"context_line":"                cinder_volume_drivers_blockdevice.volume_opts,"},{"line_number":249,"context_line":"                cinder_volume_drivers_blockbridge.blockbridge_opts,"},{"line_number":250,"context_line":"                cinder_volume_drivers_cloudbyte_options."},{"line_number":251,"context_line":"                cloudbyte_add_qosgroup_opts,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_5f860614","line":248,"updated":"2016-10-05 18:21:54.000000000","message":"This is not in alphabetical order:  blockdevice vs blockbridge.","commit_id":"6632875d5677abe81d67d2aad73282580b9a1d6d"}]}