)]}'
{"cinder/scheduler/weights/capacity.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"31c1ae272a81bfa5de5b639005a21066b1d06014","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            # provisioned_capacity_gb to determine whether a volume can be"},{"line_number":120,"context_line":"            # provisioned. Instead free capacity will be used to evaluate."},{"line_number":121,"context_line":"            thin \u003d True"},{"line_number":122,"context_line":"            vol_type \u003d weight_properties.get(\u0027volume_type\u0027, {}) or {}"},{"line_number":123,"context_line":"            provision_type \u003d vol_type.get(\u0027extra_specs\u0027, {}).get("},{"line_number":124,"context_line":"                \u0027provisioning:type\u0027)"},{"line_number":125,"context_line":"            if provision_type \u003d\u003d \u0027thick\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_6e1498e8","line":122,"updated":"2016-09-02 11:26:52.000000000","message":"nit: I think it could just be:\n\n vol_type \u003d weight_properties.get(\u0027volume_type\u0027) or {}\n\nNo need to create 2 empty dicts","commit_id":"ebeb0bbc7ae64007ba65cedd2542876a328eb9fd"}],"cinder/tests/unit/scheduler/test_capacity_weigher.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"31c1ae272a81bfa5de5b639005a21066b1d06014","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # free \u003d free_space - math.floor(total * reserved)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    @ddt.data("},{"line_number":67,"context_line":"        {\u0027volume_type\u0027: {\u0027extra_specs\u0027: {\u0027provisioning:type\u0027: \u0027thin\u0027}},"},{"line_number":68,"context_line":"         \u0027winner\u0027: \u0027host2\u0027},"},{"line_number":69,"context_line":"        {\u0027volume_type\u0027: {\u0027extra_specs\u0027: {\u0027provisioning:type\u0027: \u0027thick\u0027}},"},{"line_number":70,"context_line":"         \u0027winner\u0027: \u0027host1\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_4e9c346a","line":67,"updated":"2016-09-02 11:26:52.000000000","message":"Wow, great readability improvement!!","commit_id":"ebeb0bbc7ae64007ba65cedd2542876a328eb9fd"}]}
