)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f3663e1fdc6cb6d50d3f78cb7459fccfc4a470d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     stack \u003cvijay.ladani@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-07 03:58:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correction in formatting syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Dictionary key used wrongly as \"dictionary.key\" instead of"},{"line_number":10,"context_line":"\"dictionary[\u0027key\u0027]\" in delete_consistencygroup function at"},{"line_number":11,"context_line":" assignment and at formatting log message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"New change, using object instead of dict"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e3d1c5ee9323dd86d856a269e4aef956a9496c4"},{"line_number":16,"context_line":"Closes-bug: #1619613"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_53f2f206","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":40},"updated":"2016-09-08 09:04:55.000000000","message":"-1: This description doesn\u0027t match current patch changes.","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"8511dca189c6cfa60808b136e9aa03fbf7c2ed16","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     stack \u003cvijay.ladani@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-07 03:58:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correction in formatting syntax"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Dictionary key used wrongly as \"dictionary.key\" instead of"},{"line_number":10,"context_line":"\"dictionary[\u0027key\u0027]\" in delete_consistencygroup function at"},{"line_number":11,"context_line":" assignment and at formatting log message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"New change, using object instead of dict"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e3d1c5ee9323dd86d856a269e4aef956a9496c4"},{"line_number":16,"context_line":"Closes-bug: #1619613"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_fa0b09d3","line":13,"range":{"start_line":7,"start_character":0,"end_line":13,"end_character":40},"in_reply_to":"9a89bdaa_53f2f206","updated":"2016-09-13 06:57:05.000000000","message":"Done","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f3663e1fdc6cb6d50d3f78cb7459fccfc4a470d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"New change, using object instead of dict"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e3d1c5ee9323dd86d856a269e4aef956a9496c4"},{"line_number":16,"context_line":"Closes-bug: #1619613"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_f3e1462b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"updated":"2016-09-08 09:04:55.000000000","message":"-1: This patch no longer closes this bug.","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"8511dca189c6cfa60808b136e9aa03fbf7c2ed16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"New change, using object instead of dict"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I7e3d1c5ee9323dd86d856a269e4aef956a9496c4"},{"line_number":16,"context_line":"Closes-bug: #1619613"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a89bdaa_1a28ad32","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":20},"in_reply_to":"9a89bdaa_f3e1462b","updated":"2016-09-13 06:57:05.000000000","message":"Removed bug from description","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"}],"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f3663e1fdc6cb6d50d3f78cb7459fccfc4a470d9","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            self.description \u003d \u0027cgsnapshot\u0027"},{"line_number":606,"context_line":"            self.readOnly \u003d False"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    class fake_volume_object(object):"},{"line_number":609,"context_line":"        def __init__(self, vol_id\u003d\u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027):"},{"line_number":610,"context_line":"            self.name \u003d \u0027volume-d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027"},{"line_number":611,"context_line":"            self.id \u003d vol_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5334b248","line":608,"updated":"2016-09-08 09:04:55.000000000","message":"-1: Please don\u0027t create a fake class, use a real cinder.objects.Volume instance:\n\n from cinder import objects\n\n\n define fake_volume_object(self, context, **kwargs):\n     vol \u003d objects.Volume(\n         context,\n         id\u003d\u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027,\n         _name_id\u003d\u0027volume-d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027,\n         display_name\u003d\u0027Foo Volume\u0027,\n         size\u003d2,\n         host\u003d\u0027fakehost@foo#OpenStackCPG\u0027,\n         volume_type\u003dNone,\n         volume_type_id\u003dNone)\n     vol.update(kwargs)\n     return vol","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"8511dca189c6cfa60808b136e9aa03fbf7c2ed16","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            self.description \u003d \u0027cgsnapshot\u0027"},{"line_number":606,"context_line":"            self.readOnly \u003d False"},{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    class fake_volume_object(object):"},{"line_number":609,"context_line":"        def __init__(self, vol_id\u003d\u0027d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027):"},{"line_number":610,"context_line":"            self.name \u003d \u0027volume-d03338a9-9115-48a3-8dfc-35cdfcdc15a7\u0027"},{"line_number":611,"context_line":"            self.id \u003d vol_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_5aa15593","line":608,"in_reply_to":"9a89bdaa_5334b248","updated":"2016-09-13 06:57:05.000000000","message":"I used fake_volume module already implemented at cinder/tests/unit. We can have it customized in local driver file when needed. As this moment, not needed. Thanks!","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f3663e1fdc6cb6d50d3f78cb7459fccfc4a470d9","unresolved":false,"context_lines":[{"line_number":3966,"context_line":"                expected +"},{"line_number":3967,"context_line":"                self.standard_logout)"},{"line_number":3968,"context_line":""},{"line_number":3969,"context_line":"            # mock HTTPServerError (array failure)"},{"line_number":3970,"context_line":"            mock_client.deleteVolumeSet.side_effect \u003d ("},{"line_number":3971,"context_line":"                hpeexceptions.HTTPConflict())"},{"line_number":3972,"context_line":"            # no exception should escape method"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_2e2c2598","line":3969,"updated":"2016-09-08 09:04:55.000000000","message":"nit: Maybe move these tests to a different method, we should only be testing 1 thing in each test anyway.","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"8511dca189c6cfa60808b136e9aa03fbf7c2ed16","unresolved":false,"context_lines":[{"line_number":3966,"context_line":"                expected +"},{"line_number":3967,"context_line":"                self.standard_logout)"},{"line_number":3968,"context_line":""},{"line_number":3969,"context_line":"            # mock HTTPServerError (array failure)"},{"line_number":3970,"context_line":"            mock_client.deleteVolumeSet.side_effect \u003d ("},{"line_number":3971,"context_line":"                hpeexceptions.HTTPConflict())"},{"line_number":3972,"context_line":"            # no exception should escape method"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_7aaa9972","line":3969,"in_reply_to":"9a89bdaa_2e2c2598","updated":"2016-09-13 06:57:05.000000000","message":"Done","commit_id":"05686377f452432b31e465d8b761cbc0c5b06469"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"03c1fca517a33fd4745bcec4bcf40e13935971ea","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        volume_model_updates \u003d []"},{"line_number":589,"context_line":"        for volume in volumes:"},{"line_number":590,"context_line":"            volume_update \u003d {\u0027id\u0027: volume.id}"},{"line_number":591,"context_line":"            try:"},{"line_number":592,"context_line":"                self.delete_volume(volume)"},{"line_number":593,"context_line":"                volume_update[\u0027status\u0027] \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"da7fb54a_4a79272f","side":"PARENT","line":590,"updated":"2016-09-02 16:08:51.000000000","message":"Did you really see an exception during testing or in logs?  If so, please provide logs.  volume.id is used in delete_consistencygroup in a number of other drivers and it has not caused problems.  I don\u0027t see a need to change this unless if you run into an exception.  It is true that the manager is not passing in this as a list of objects yet, but we want to move towards using objects in the future, so avoid the need to change this back and forth if this works.","commit_id":"29e00a3c63e15cd87d60e6f7cdc661646e4cb816"},{"author":{"_account_id":21406,"name":"Vijay Ladani","email":"vijay.ladani@hpe.com","username":"vladani"},"change_message_id":"f9ce75a9f8f2e79623ae6c0ba0877a9e6656a985","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"        volume_model_updates \u003d []"},{"line_number":589,"context_line":"        for volume in volumes:"},{"line_number":590,"context_line":"            volume_update \u003d {\u0027id\u0027: volume.id}"},{"line_number":591,"context_line":"            try:"},{"line_number":592,"context_line":"                self.delete_volume(volume)"},{"line_number":593,"context_line":"                volume_update[\u0027status\u0027] \u003d \u0027deleted\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_3403210f","side":"PARENT","line":590,"in_reply_to":"da7fb54a_4a79272f","updated":"2016-09-06 05:11:50.000000000","message":"Yes, I get below error while writing unit test for the function\n\nFAIL: cinder.tests.unit.volume.drivers.hpe.test_hpe3par.TestHPE3PARFCDriver.test_delete_consistency_group\ntags: worker-27\n----------------------------------------------------------------------\nEmpty attachments:\n  stderr\n  stdout\n\npythonlogging:\u0027\u0027: {{{\n2016-09-05 21:31:59,551 INFO [cinder.coordination] Coordination backend started successfully.\n2016-09-05 21:31:59,587 ERROR [cinder.volume.drivers.hpe.hpe_3par_common] Conflict detected in Virtual Volume Set vvs-YET.38iJR1KQDyA50kel3w: Conflict (HTTP 409)\n2016-09-05 21:31:59,590 WARNING [cinder.volume.drivers.hpe.hpe_3par_common] Virtual Volume Set \u0027vvs-YET.38iJR1KQDyA50kel3w\u0027 doesn\u0027t exist on array.\n2016-09-05 21:31:59,593 WARNING [cinder.volume.drivers.hpe.hpe_3par_common] Virtual Volume Set \u0027vvs-YET.38iJR1KQDyA50kel3w\u0027 doesn\u0027t exist on array.\n}}}\n\nTraceback (most recent call last):\n  File \"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py\", line 3977, in test_delete_consistency_group\n    group, volumes\u003d[self.volume])\n  File \"cinder/utils.py\", line 895, in trace_logging_wrapper\n    result \u003d f(*args, **kwargs)\n  File \"cinder/volume/drivers/hpe/hpe_3par_fc.py\", line 585, in delete_consistencygroup\n    return common.delete_consistencygroup(context, group, volumes)\n  File \"cinder/volume/drivers/hpe/hpe_3par_common.py\", line 590, in delete_consistencygroup\n    volume_update \u003d {\u0027id\u0027: volume.id}\nAttributeError: \u0027dict\u0027 object has no attribute \u0027id\u0027\n\n\nFor reference, you can check how dict is used in function on other drivers\ncinder/volume/drivers/netapp/eseries/library.py\ncinder/volume/drivers/prophetstor/dplcommon.py\ncinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py","commit_id":"29e00a3c63e15cd87d60e6f7cdc661646e4cb816"}]}