)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e970c82b4c6aaea1d1dcf956e28a75febcb9af3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"For those that are interested, this can also be done outside of"},{"line_number":27,"context_line":"cinder by setting the silence_logs variable in lvm.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This is made an optional configuration because it only applies to very specific"},{"line_number":30,"context_line":"environments.  If we were to make this global that would require a rootwrap/privsep"},{"line_number":31,"context_line":"update that could break compatability when trying to do rolling upgrades of the"},{"line_number":32,"context_line":"volume service."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I85612fa49475beea58d30330c8fe8352a2f91123"},{"line_number":35,"context_line":"Closes-Bug: #1619701"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a8ec9b2_2e539718","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":15},"updated":"2016-09-21 10:11:36.000000000","message":"This should be wrapped at 72 chars","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"43470a184a325b7a3d5ccaa0225e3e04c3854d96","unresolved":false,"context_lines":[{"line_number":26,"context_line":"For those that are interested, this can also be done outside of"},{"line_number":27,"context_line":"cinder by setting the silence_logs variable in lvm.conf"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This is made an optional configuration because it only applies to very specific"},{"line_number":30,"context_line":"environments.  If we were to make this global that would require a rootwrap/privsep"},{"line_number":31,"context_line":"update that could break compatability when trying to do rolling upgrades of the"},{"line_number":32,"context_line":"volume service."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Change-Id: I85612fa49475beea58d30330c8fe8352a2f91123"},{"line_number":35,"context_line":"Closes-Bug: #1619701"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a8ec9b2_83c5328f","line":32,"range":{"start_line":29,"start_character":0,"end_line":32,"end_character":15},"in_reply_to":"7a8ec9b2_2e539718","updated":"2016-09-21 23:14:07.000000000","message":"Done","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"94c5d4eed9d2df078c08c04d7de8982ef27bc70f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # where the specified lvm_conf file is located as the value."},{"line_number":79,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":80,"context_line":"            lvm_sys_dir \u003d os.path.dirname(lvm_conf)"},{"line_number":81,"context_line":"            # BUG(jdg): I believe if you were to set this and run without"},{"line_number":82,"context_line":"            # modifying rootwrap you would have problems because not all of the"},{"line_number":83,"context_line":"            # LVM commands that use the LVM_CMD_PREFIX have a rootwrap entry"},{"line_number":84,"context_line":"            # for LVM_SYSTEM_DIR."}],"source_content_type":"text/x-python","patch_set":9,"id":"7a8ec9b2_83f9b282","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":73},"updated":"2016-09-21 23:22:07.000000000","message":"Never mind, I see what I need to do to cover this","commit_id":"0ef7716b30c139b59aac829c1f3b75ca4e6d808a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"370c7c735dd687792c2b30283243a2557b52251c","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":86,"context_line":"            lvm_sys_dir \u003d os.path.dirname(lvm_conf)"},{"line_number":87,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if suppress_fd_warn:"},{"line_number":90,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SUPPRESS_FD_WARNINGS\u003d1\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_0227acca","line":87,"range":{"start_line":87,"start_character":1,"end_line":87,"end_character":69},"updated":"2016-09-23 15:27:29.000000000","message":"nit: No need to create a list to add one element:\n\n _lvm_cmd_prefix.append(\u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir)","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"76208d49f91d0dcabd89d5f4332a95c7bf6ad247","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":86,"context_line":"            lvm_sys_dir \u003d os.path.dirname(lvm_conf)"},{"line_number":87,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if suppress_fd_warn:"},{"line_number":90,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SUPPRESS_FD_WARNINGS\u003d1\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_25caed6d","line":87,"range":{"start_line":87,"start_character":1,"end_line":87,"end_character":69},"in_reply_to":"5a8bc5a2_0227acca","updated":"2016-09-23 17:02:21.000000000","message":"Done","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"370c7c735dd687792c2b30283243a2557b52251c","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if suppress_fd_warn:"},{"line_number":90,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SUPPRESS_FD_WARNINGS\u003d1\u0027])"},{"line_number":91,"context_line":"        LVM.LVM_CMD_PREFIX \u003d _lvm_cmd_prefix"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        if create_vg and physical_volumes is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_2222e8b9","line":90,"updated":"2016-09-23 15:27:29.000000000","message":"ditto","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"76208d49f91d0dcabd89d5f4332a95c7bf6ad247","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir])"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if suppress_fd_warn:"},{"line_number":90,"context_line":"            _lvm_cmd_prefix.extend([\u0027LVM_SUPPRESS_FD_WARNINGS\u003d1\u0027])"},{"line_number":91,"context_line":"        LVM.LVM_CMD_PREFIX \u003d _lvm_cmd_prefix"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        if create_vg and physical_volumes is not None:"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_45c53959","line":90,"in_reply_to":"5a8bc5a2_2222e8b9","updated":"2016-09-23 17:02:21.000000000","message":"Done","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"}],"cinder/tests/unit/brick/test_brick_lvm.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"370c7c735dd687792c2b30283243a2557b52251c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return (\"  LVM version:     2.02.100(2)-RHEL6 (2013-09-12)\\n\", \"\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fake_execute(obj, *cmd, **kwargs):  # noqa"},{"line_number":55,"context_line":"        _lvm_prefix \u003d \u0027env, LC_ALL\u003dC, \u0027"},{"line_number":56,"context_line":"        if obj.configuration.lvm_suppress_fd_warnings:"},{"line_number":57,"context_line":"            _lvm_prefix \u003d \u0027env, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, \u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        cmd_string \u003d \u0027, \u0027.join(cmd)"},{"line_number":60,"context_line":"        data \u003d \"\\n\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_a2999821","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":71},"updated":"2016-09-23 15:27:29.000000000","message":"nit: better as if ... else clause or just changing L57 to\n\n _lvm_prefix +\u003d \u0027LVM_SUPPRESS_FD_WARNINGS\u003d1, \u0027","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"76208d49f91d0dcabd89d5f4332a95c7bf6ad247","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        return (\"  LVM version:     2.02.100(2)-RHEL6 (2013-09-12)\\n\", \"\")"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def fake_execute(obj, *cmd, **kwargs):  # noqa"},{"line_number":55,"context_line":"        _lvm_prefix \u003d \u0027env, LC_ALL\u003dC, \u0027"},{"line_number":56,"context_line":"        if obj.configuration.lvm_suppress_fd_warnings:"},{"line_number":57,"context_line":"            _lvm_prefix \u003d \u0027env, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, \u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        cmd_string \u003d \u0027, \u0027.join(cmd)"},{"line_number":60,"context_line":"        data \u003d \"\\n\""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_451d39bc","line":57,"range":{"start_line":55,"start_character":0,"end_line":57,"end_character":71},"in_reply_to":"5a8bc5a2_a2999821","updated":"2016-09-23 17:02:21.000000000","message":"Done","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"}],"cinder/volume/drivers/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3cc7e021fe1e350177842ed6aab886101fb35729","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                      \u0027driver.  If set, this takes precedence over the \u0027"},{"line_number":71,"context_line":"                      \u0027general max_over_subscription_ratio option.  If \u0027"},{"line_number":72,"context_line":"                      \u0027None, the general option is used.\u0027),"},{"line_number":73,"context_line":"    cfg.BoolOpt(\u0027suppress_fd_warnings\u0027,"},{"line_number":74,"context_line":"                default\u003dFalse,"},{"line_number":75,"context_line":"                help\u003d\u0027Suppress leaked file descriptor warnings in LVM \u0027"},{"line_number":76,"context_line":"                     \u0027commands.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_d27df4e8","line":73,"updated":"2016-09-13 18:53:14.000000000","message":"This should be named \"lvm_suppress_fd_warnings\" since I don\u0027t think it will be applied to other commands called from Cinder.","commit_id":"6df6b56d02b24d70848fedb5f74b7f4bf148131a"}],"etc/cinder/rootwrap.d/volume.filters":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"72c0a24a49839ee31a474c457db083091d5a5118","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# cinder/brick/local_dev/lvm.py: \u0027lvcreate\u0027, \u0027-L\u0027, sizestr, \u0027-n\u0027, volume_name,.."},{"line_number":40,"context_line":"# cinder/brick/local_dev/lvm.py: \u0027lvcreate\u0027, \u0027-L\u0027, ..."},{"line_number":41,"context_line":"lvcreate: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, lvcreate"},{"line_number":42,"context_line":"lvcreate_lvmconf: EnvFilter, env, root, LVM_SYSTEM_DIR\u003d, LC_ALL\u003dC, lvcreate"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# cinder/volume/driver.py: \u0027dd\u0027, \u0027if\u003d%s\u0027 % srcstr, \u0027of\u003d%s\u0027 % deststr,..."},{"line_number":45,"context_line":"dd: CommandFilter, dd, root"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9a89bdaa_94c19231","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":75},"updated":"2016-09-03 00:16:01.000000000","message":"we shouldn\u0027t need to add to this second one I don\u0027t believe","commit_id":"3ad7f4a02c7696a4e12401b3b5436f22d72833fc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4f7cb4630e797b13f9adf4819abdc1f0b2497733","unresolved":false,"context_lines":[{"line_number":11,"context_line":"scstadmin: CommandFilter, scstadmin, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# LVM related show commands"},{"line_number":14,"context_line":"pvs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, pvs"},{"line_number":15,"context_line":"vgs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, vgs"},{"line_number":16,"context_line":"lvs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, lvs"},{"line_number":17,"context_line":"lvdisplay: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, lvdisplay"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a89bdaa_82f721f4","line":14,"updated":"2016-09-06 19:28:24.000000000","message":"According to the rootwrap docs, this is supposed to just \"LVM_SUPPRESS_FD_WARNINGS\u003d\" for the filter here.\n\n(Meaning the \"LC_ALL\u003dC\" should have been \"LC_ALL\u003d\", too.)","commit_id":"8e804dbc5c3fa58f17b552210cb2b5b9ec5584d2"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"31054dd2e9b136a659c1a19554641ff1e7b22a94","unresolved":false,"context_lines":[{"line_number":11,"context_line":"scstadmin: CommandFilter, scstadmin, root"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# LVM related show commands"},{"line_number":14,"context_line":"pvs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, pvs"},{"line_number":15,"context_line":"vgs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, vgs"},{"line_number":16,"context_line":"lvs: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, lvs"},{"line_number":17,"context_line":"lvdisplay: EnvFilter, env, root, LC_ALL\u003dC, LVM_SUPPRESS_FD_WARNINGS\u003d1, lvdisplay"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9a89bdaa_7d72bcae","line":14,"in_reply_to":"9a89bdaa_82f721f4","updated":"2016-09-06 19:51:39.000000000","message":"Ok, I\u0027ll take a look at fixing the introduction here then a follow up to go back and update LC_ALL.  \n\nThanks","commit_id":"8e804dbc5c3fa58f17b552210cb2b5b9ec5584d2"}],"releasenotes/notes/add-suppress-lvm-fd-warnings-option.402bebc03b0a9f00.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e970c82b4c6aaea1d1dcf956e28a75febcb9af3","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      commands result in file descriptor leak warning messages which in turn cause"},{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accomoadate these environments, and to maintain backward compatability"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      LVM_SUPPRESS_WARNINGS\u003d1."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_2e2c7798","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":20},"updated":"2016-09-21 10:11:36.000000000","message":"nit: accomodate","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"43470a184a325b7a3d5ccaa0225e3e04c3854d96","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      commands result in file descriptor leak warning messages which in turn cause"},{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accomoadate these environments, and to maintain backward compatability"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      LVM_SUPPRESS_WARNINGS\u003d1."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_03d12257","line":8,"range":{"start_line":8,"start_character":9,"end_line":8,"end_character":20},"in_reply_to":"7a8ec9b2_2e2c7798","updated":"2016-09-21 23:14:07.000000000","message":"Done","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3e970c82b4c6aaea1d1dcf956e28a75febcb9af3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accomoadate these environments, and to maintain backward compatability"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      LVM_SUPPRESS_WARNINGS\u003d1."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_94259fc3","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":43},"updated":"2016-09-21 10:11:36.000000000","message":"-1: The configuration option name has not been changed here, and it should use double back-ticks:\n\n ``lvm_suppress_fd_warnings``","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"43470a184a325b7a3d5ccaa0225e3e04c3854d96","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accomoadate these environments, and to maintain backward compatability"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      LVM_SUPPRESS_WARNINGS\u003d1."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a8ec9b2_23d61e4f","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":43},"in_reply_to":"7a8ec9b2_94259fc3","updated":"2016-09-21 23:14:07.000000000","message":"Done","commit_id":"864e80f472f6dcbd641fa7d6f4bbc689831906cc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"370c7c735dd687792c2b30283243a2557b52251c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accommodate these environments, and to maintain backward compatibility"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      ``` LVM_SUPPRESS_FD_WARNINGS\u003d1 ```."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_621dd0bc","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":43},"updated":"2016-09-23 15:27:29.000000000","message":"-1: ``suppress_fd_warnings``","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"76208d49f91d0dcabd89d5f4332a95c7bf6ad247","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      the process_execution method to raise and exception."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"      To accommodate these environments, and to maintain backward compatibility"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      ``` LVM_SUPPRESS_FD_WARNINGS\u003d1 ```."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_65615539","line":9,"range":{"start_line":9,"start_character":26,"end_line":9,"end_character":43},"in_reply_to":"5a8bc5a2_621dd0bc","updated":"2016-09-23 17:02:21.000000000","message":"Done","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"370c7c735dd687792c2b30283243a2557b52251c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      To accommodate these environments, and to maintain backward compatibility"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      ``` LVM_SUPPRESS_FD_WARNINGS\u003d1 ```."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      This is made an optional configuration because it only applies to very specific"},{"line_number":14,"context_line":"      environments.  If we were to make this global that would require a rootwrap/privsep"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_4279b4f5","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":41},"updated":"2016-09-23 15:27:29.000000000","message":"These should be double backticks afaik","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"76208d49f91d0dcabd89d5f4332a95c7bf6ad247","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      To accommodate these environments, and to maintain backward compatibility"},{"line_number":9,"context_line":"      in Newton we add a *suppress_fd_warn* bool config to the LVM driver."},{"line_number":10,"context_line":"      Setting this to True will append the LVM env vars to include the variable"},{"line_number":11,"context_line":"      ``` LVM_SUPPRESS_FD_WARNINGS\u003d1 ```."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"      This is made an optional configuration because it only applies to very specific"},{"line_number":14,"context_line":"      environments.  If we were to make this global that would require a rootwrap/privsep"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"5a8bc5a2_8564a149","line":11,"range":{"start_line":11,"start_character":6,"end_line":11,"end_character":41},"in_reply_to":"5a8bc5a2_4279b4f5","updated":"2016-09-23 17:02:21.000000000","message":"Done","commit_id":"e2afd021c7b699be90f582a18b5711bd0c5162cf"}]}