)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"volume attach, to the same host, will use the established target"},{"line_number":16,"context_line":"port."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Fixes but #1197036"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Icf8c28ea3f201e5e21c9a6ed00a2fbdda445c8b3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2F0kE%3D","line":18,"updated":"2013-07-10 22:11:24.000000000","message":"should be Fixes bug #1197036","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":15,"context_line":"volume attach, to the same host, will use the established target"},{"line_number":16,"context_line":"port."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Fixes but #1197036"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Icf8c28ea3f201e5e21c9a6ed00a2fbdda445c8b3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAP3%2F%2F0iQ%3D","line":18,"in_reply_to":"AAAAP3%2F%2F0kE%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done.","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"cbb7d1af8b49e5d3aee6a6901f36f1daf4ce5134","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jim Branen \u003cjames.branen@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-15 16:45:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds multiple iSCSI port support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support to the 3PAR iSCSI OpenStack driver to provide the"},{"line_number":10,"context_line":"ability to select the best fit target iSCSI port from a list of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAP3%2F%2Fl5E%3D","line":7,"updated":"2013-07-16 04:32:27.000000000","message":"Please add 3PAR to the title","commit_id":"edc7657a7fe7411588b3ea0ffdcd53ce73b1ee6a"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"fada6fe2492028829cc2309ab910cd7e985e545a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jim Branen \u003cjames.branen@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-07-15 16:45:36 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds multiple iSCSI port support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added support to the 3PAR iSCSI OpenStack driver to provide the"},{"line_number":10,"context_line":"ability to select the best fit target iSCSI port from a list of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAP3%2F%2Fjts%3D","line":7,"in_reply_to":"AAAAP3%2F%2Fl5E%3D","updated":"2013-07-16 15:50:36.000000000","message":"Done","commit_id":"edc7657a7fe7411588b3ea0ffdcd53ce73b1ee6a"}],"cinder/tests/test_hp3par.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"cbb7d1af8b49e5d3aee6a6901f36f1daf4ce5134","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def test_delete_volume(self):"},{"line_number":407,"context_line":"        self.flags(lock_path\u003dself.tempdir)"},{"line_number":408,"context_line":"        self.setup_fakes()"},{"line_number":409,"context_line":"        self.driver.delete_volume(self.volume)"},{"line_number":410,"context_line":"        self.assertRaises(hpexceptions.HTTPNotFound,"},{"line_number":411,"context_line":"                          self.driver.common.client.getVolume,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAP3%2F%2Fl4w%3D","line":408,"updated":"2013-07-16 04:32:27.000000000","message":"For all tests in this class, maybe move these two lines to a setUp function?","commit_id":"edc7657a7fe7411588b3ea0ffdcd53ce73b1ee6a"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"fada6fe2492028829cc2309ab910cd7e985e545a","unresolved":false,"context_lines":[{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    def test_delete_volume(self):"},{"line_number":407,"context_line":"        self.flags(lock_path\u003dself.tempdir)"},{"line_number":408,"context_line":"        self.setup_fakes()"},{"line_number":409,"context_line":"        self.driver.delete_volume(self.volume)"},{"line_number":410,"context_line":"        self.assertRaises(hpexceptions.HTTPNotFound,"},{"line_number":411,"context_line":"                          self.driver.common.client.getVolume,"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAP3%2F%2Fjtc%3D","line":408,"in_reply_to":"AAAAP3%2F%2Fl4w%3D","updated":"2013-07-16 15:50:36.000000000","message":"Done","commit_id":"edc7657a7fe7411588b3ea0ffdcd53ce73b1ee6a"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\"),"},{"line_number":100,"context_line":"    cfg.ListOpt(\u0027hp3par_iscsi_ips\u0027,"},{"line_number":101,"context_line":"                default\u003d[],"},{"line_number":102,"context_line":"                help\u003d\"List of iSCSI addresses to use.\")"},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0kU%3D","line":102,"updated":"2013-07-10 22:11:24.000000000","message":"should probably put \"List of target iSCSI...\"","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\"),"},{"line_number":100,"context_line":"    cfg.ListOpt(\u0027hp3par_iscsi_ips\u0027,"},{"line_number":101,"context_line":"                default\u003d[],"},{"line_number":102,"context_line":"                help\u003d\"List of iSCSI addresses to use.\")"},{"line_number":103,"context_line":"]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0iI%3D","line":102,"in_reply_to":"AAAAP3%2F%2F0kU%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"}],"cinder/volume/drivers/san/hp/hp_3par_iscsi.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.common.do_setup(context)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # make sure ssh works."},{"line_number":86,"context_line":"        self._iscsi_discover_target_iqn(self.configuration.iscsi_ip_address)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def check_for_setup_error(self):"},{"line_number":89,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0ko%3D","side":"PARENT","line":86,"updated":"2013-07-10 22:11:24.000000000","message":"this methods _iscsi_discover_target_iqn does not appear to be called anymore and can be removed altogether","commit_id":"2f5e26a247665f890cdf26773b5e7070890594d8"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        self.common.do_setup(context)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # make sure ssh works."},{"line_number":86,"context_line":"        self._iscsi_discover_target_iqn(self.configuration.iscsi_ip_address)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def check_for_setup_error(self):"},{"line_number":89,"context_line":"        \"\"\"Returns an error if prerequisites aren\u0027t met.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0iA%3D","side":"PARENT","line":86,"in_reply_to":"AAAAP3%2F%2F0ko%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done","commit_id":"2f5e26a247665f890cdf26773b5e7070890594d8"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        self.common.client_login()"},{"line_number":171,"context_line":"        # get the target_iqn on the 3par interface."},{"line_number":172,"context_line":"        target_iqn \u003d self._iscsi_discover_target_iqn("},{"line_number":173,"context_line":"            self.configuration.iscsi_ip_address)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # we have to make sure we have a host"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0kc%3D","side":"PARENT","line":172,"updated":"2013-07-10 22:11:24.000000000","message":"this methods _iscsi_discover_target_iqn does not appear to be called anymore and can be removed altogether","commit_id":"2f5e26a247665f890cdf26773b5e7070890594d8"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        self.common.client_login()"},{"line_number":171,"context_line":"        # get the target_iqn on the 3par interface."},{"line_number":172,"context_line":"        target_iqn \u003d self._iscsi_discover_target_iqn("},{"line_number":173,"context_line":"            self.configuration.iscsi_ip_address)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # we have to make sure we have a host"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0h8%3D","side":"PARENT","line":172,"in_reply_to":"AAAAP3%2F%2F0kc%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done","commit_id":"2f5e26a247665f890cdf26773b5e7070890594d8"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"import cinder.volume.driver"},{"line_number":39,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_common as hpcommon"},{"line_number":40,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":41,"context_line":"import sys"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"VERSION \u003d 1.0"},{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0mc%3D","line":41,"updated":"2013-07-10 22:11:24.000000000","message":"this should be in it\u0027s own block above cinder imports","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":38,"context_line":"import cinder.volume.driver"},{"line_number":39,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_common as hpcommon"},{"line_number":40,"context_line":"from cinder.volume.drivers.san import san"},{"line_number":41,"context_line":"import sys"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"VERSION \u003d 1.0"},{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2F0iE%3D","line":41,"in_reply_to":"AAAAP3%2F%2F0mc%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"fb20ac8587bed42530bd05707b36e4136fdbadb0","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        # when found, add the valid iSCSI ip, ip port, iqn and nsp"},{"line_number":115,"context_line":"        # to the iSCSI IP dictionary"},{"line_number":116,"context_line":"        # ...this will also make sure ssh works."},{"line_number":117,"context_line":"        result \u003d self.common._cli_run(\u0027showport -iscsiname\u0027, None)"},{"line_number":118,"context_line":"        if result:"},{"line_number":119,"context_line":"            # first line is header"},{"line_number":120,"context_line":"            result \u003d result[1:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2FwME%3D","line":117,"updated":"2013-07-11 22:57:41.000000000","message":"We should be using the hp_3par_common\u0027s get_ports() here instead of redoing the work here.","commit_id":"7e98b595361ae8769f0cd5bde4e28fc7fcb2e408"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"49aa4d7b8cc431330b951e0949bda3a54b1f63d6","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        pass"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _get_iscsi_ip(self, hostname):"},{"line_number":310,"context_line":"        \"\"\""},{"line_number":311,"context_line":"        Get an iSCSI IP address to use."},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        Steps to determine which IP address to use."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2FoKo%3D","line":310,"updated":"2013-07-15 17:16:08.000000000","message":"Doc string should be on the first line \"\"\"Get....","commit_id":"f15d109e1d4702a28026c359544abfe09cc5f29e"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"49aa4d7b8cc431330b951e0949bda3a54b1f63d6","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_least_used_nsp(self, nspss):"},{"line_number":360,"context_line":"        \"\"\"\"Return the nsp that has the fewest active vluns\"\"\""},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        # return only the nsp (node:server:port)"},{"line_number":363,"context_line":"        result \u003d self.common._cli_run(\u0027showvlun -a -showcols Port\u0027, None)"},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAP3%2F%2FoK8%3D","line":361,"updated":"2013-07-15 17:16:08.000000000","message":"remove this line","commit_id":"f15d109e1d4702a28026c359544abfe09cc5f29e"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"da56ea1d924e4f5ab73d52d4ae18e7184d308293","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        return self._get_ip_using_nsp(nsp)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _get_iscsi_nsps(self):"},{"line_number":335,"context_line":"        \"\"\"Return the list of candidate nsps\"\"\""},{"line_number":336,"context_line":"        nsps \u003d []"},{"line_number":337,"context_line":"        for value in self.iscsi_ips.values():"},{"line_number":338,"context_line":"            nsps.append(value[\u0027nsp\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmow%3D","line":335,"updated":"2013-07-15 23:14:09.000000000","message":"need a .","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"6eccd94d18d0871c25b4338d9800f9e9e40a1e75","unresolved":false,"context_lines":[{"line_number":332,"context_line":"        return self._get_ip_using_nsp(nsp)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _get_iscsi_nsps(self):"},{"line_number":335,"context_line":"        \"\"\"Return the list of candidate nsps\"\"\""},{"line_number":336,"context_line":"        nsps \u003d []"},{"line_number":337,"context_line":"        for value in self.iscsi_ips.values():"},{"line_number":338,"context_line":"            nsps.append(value[\u0027nsp\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmi4%3D","line":335,"in_reply_to":"AAAAP3%2F%2Fmow%3D","updated":"2013-07-15 23:31:57.000000000","message":"Done.","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"da56ea1d924e4f5ab73d52d4ae18e7184d308293","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                    return info[4]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def _get_least_used_nsp(self, nspss):"},{"line_number":359,"context_line":"        \"\"\"\"Return the nsp that has the fewest active vluns\"\"\""},{"line_number":360,"context_line":"        # return only the nsp (node:server:port)"},{"line_number":361,"context_line":"        result \u003d self.common._cli_run(\u0027showvlun -a -showcols Port\u0027, None)"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmo4%3D","line":359,"updated":"2013-07-15 23:14:09.000000000","message":"need a .","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"6eccd94d18d0871c25b4338d9800f9e9e40a1e75","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                    return info[4]"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def _get_least_used_nsp(self, nspss):"},{"line_number":359,"context_line":"        \"\"\"\"Return the nsp that has the fewest active vluns\"\"\""},{"line_number":360,"context_line":"        # return only the nsp (node:server:port)"},{"line_number":361,"context_line":"        result \u003d self.common._cli_run(\u0027showvlun -a -showcols Port\u0027, None)"},{"line_number":362,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmi0%3D","line":359,"in_reply_to":"AAAAP3%2F%2Fmo4%3D","updated":"2013-07-15 23:31:57.000000000","message":"Done.","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"da56ea1d924e4f5ab73d52d4ae18e7184d308293","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        # count the number of nsps (there is 1 for each active vlun)"},{"line_number":364,"context_line":"        nps_counts \u003d {}"},{"line_number":365,"context_line":"        for nps in nspss:"},{"line_number":366,"context_line":"            # initialize counts to zero"},{"line_number":367,"context_line":"            nps_counts[nps] \u003d 0"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2FmpI%3D","line":365,"updated":"2013-07-15 23:14:09.000000000","message":"nps -\u003e nsp","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"6eccd94d18d0871c25b4338d9800f9e9e40a1e75","unresolved":false,"context_lines":[{"line_number":362,"context_line":""},{"line_number":363,"context_line":"        # count the number of nsps (there is 1 for each active vlun)"},{"line_number":364,"context_line":"        nps_counts \u003d {}"},{"line_number":365,"context_line":"        for nps in nspss:"},{"line_number":366,"context_line":"            # initialize counts to zero"},{"line_number":367,"context_line":"            nps_counts[nps] \u003d 0"},{"line_number":368,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmiw%3D","line":365,"in_reply_to":"AAAAP3%2F%2FmpI%3D","updated":"2013-07-15 23:31:57.000000000","message":"Done.","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"da56ea1d924e4f5ab73d52d4ae18e7184d308293","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        nps_counts \u003d {}"},{"line_number":365,"context_line":"        for nps in nspss:"},{"line_number":366,"context_line":"            # initialize counts to zero"},{"line_number":367,"context_line":"            nps_counts[nps] \u003d 0"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if result:"},{"line_number":370,"context_line":"            # first line is header"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmoc%3D","line":367,"updated":"2013-07-15 23:14:09.000000000","message":"nsp_counts","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"6eccd94d18d0871c25b4338d9800f9e9e40a1e75","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        nps_counts \u003d {}"},{"line_number":365,"context_line":"        for nps in nspss:"},{"line_number":366,"context_line":"            # initialize counts to zero"},{"line_number":367,"context_line":"            nps_counts[nps] \u003d 0"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        if result:"},{"line_number":370,"context_line":"            # first line is header"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmis%3D","line":367,"in_reply_to":"AAAAP3%2F%2Fmoc%3D","updated":"2013-07-15 23:31:57.000000000","message":"Done.","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"da56ea1d924e4f5ab73d52d4ae18e7184d308293","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                    current_least_used_nsp \u003d nsp"},{"line_number":382,"context_line":"                    current_smallest_count \u003d count"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return current_least_used_nsp"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2FmpA%3D","line":384,"updated":"2013-07-15 23:14:09.000000000","message":"Need to initialize this to something.  if result is None, then what are we returning here?","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"6eccd94d18d0871c25b4338d9800f9e9e40a1e75","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                    current_least_used_nsp \u003d nsp"},{"line_number":382,"context_line":"                    current_smallest_count \u003d count"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        return current_least_used_nsp"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAP3%2F%2Fmio%3D","line":384,"in_reply_to":"AAAAP3%2F%2FmpA%3D","updated":"2013-07-15 23:31:57.000000000","message":"Done.","commit_id":"b087c867ce01fd71160186f6ce55d5b73e813f77"}],"etc/cinder/cinder.conf.sample":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"a99a81e4c8307db717ff3fb54eda5c38e8d48f8c","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"#hp3par_debug\u003dfalse"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"#List of iSCSI addresses to use (list value)"},{"line_number":1164,"context_line":"#hp3par_iscsi_ips"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAP3%2F%2F0mw%3D","line":1164,"updated":"2013-07-10 22:11:24.000000000","message":"this option should have an equal \"\u003d\" sign after it to match the rest.","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"},{"author":{"_account_id":7389,"name":"Jim Branen","email":"james.branen@hp.com","username":"jim_branen"},"change_message_id":"443974acbd92e845c3bd880d8fc5b7902a3c9e76","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"#hp3par_debug\u003dfalse"},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"#List of iSCSI addresses to use (list value)"},{"line_number":1164,"context_line":"#hp3par_iscsi_ips"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"#"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAP3%2F%2F0h4%3D","line":1164,"in_reply_to":"AAAAP3%2F%2F0mw%3D","updated":"2013-07-10 22:28:45.000000000","message":"Done","commit_id":"20c57c31f0ba73c3a0564e59ae7ff27f282691d5"}]}