)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"4dcdb9b1d86cd2ff408fde11770f1354021abbe5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver only supports creating a consistency group"},{"line_number":10,"context_line":"from a consistency group snapshot. The fix throws an"},{"line_number":11,"context_line":"exception stating that we don.t support creating a CG from"},{"line_number":12,"context_line":"a CG and fixes the inconsistent state the CG falls into as"},{"line_number":13,"context_line":"a result of it, so the user is able to delete it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a89bdaa_73ea0c11","line":11,"range":{"start_line":11,"start_character":26,"end_line":11,"end_character":31},"updated":"2016-09-06 11:45:36.000000000","message":"don\u0027t","commit_id":"de0ac4ac6f81663e8c24aeed817fc5699409f91a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8b572ca4587d78611a36b8b4cee5983aefdac748","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver only supports creating a consistency group"},{"line_number":10,"context_line":"from a consistency group snapshot. The fix throws an"},{"line_number":11,"context_line":"exception stating that we don.t support creating a CG from"},{"line_number":12,"context_line":"a CG and fixes the inconsistent state the CG falls into as"},{"line_number":13,"context_line":"a result of it, so the user is able to delete it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_562dc044","line":11,"updated":"2016-09-12 21:52:17.000000000","message":"nit: don\u0027t","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"047562b83d76250c3d2937db7faa5af79ef33f3e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The VMAX driver only supports creating a consistency group"},{"line_number":10,"context_line":"from a consistency group snapshot. The fix throws an"},{"line_number":11,"context_line":"exception stating that we don.t support creating a CG from"},{"line_number":12,"context_line":"a CG and fixes the inconsistent state the CG falls into as"},{"line_number":13,"context_line":"a result of it, so the user is able to delete it."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_d7561b5d","line":11,"in_reply_to":"9a89bdaa_562dc044","updated":"2016-09-13 08:31:53.000000000","message":"Thanks. we will change","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"}],"cinder/tests/unit/volume/drivers/emc/test_emc_vmax.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f40974f4682a329e0be7f1ed0ec23e1576968a13","unresolved":false,"context_lines":[{"line_number":8351,"context_line":"    def test_get_consistency_group_utils(self, mock_pool):"},{"line_number":8352,"context_line":"        common \u003d self.driver.common"},{"line_number":8353,"context_line":"        common.conn \u003d FakeEcomConnection()"},{"line_number":8354,"context_line":"        common._initial_setup \u003d mock.Mock(return_value\u003dself.data.extra_specs)"},{"line_number":8355,"context_line":"        replicationService, storageSystem, extraSpecs \u003d ("},{"line_number":8356,"context_line":"            common._get_consistency_group_utils("},{"line_number":8357,"context_line":"                common.conn, EMCVMAXCommonData.test_CG))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_5b7c9120","line":8354,"updated":"2016-09-14 03:39:26.000000000","message":"Same comments as in other patches.  Don\u0027t change the method directly.  Mock it.","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b38c9d24e16595515018db9a132096d0ea3b3ec0","unresolved":false,"context_lines":[{"line_number":8351,"context_line":"    def test_get_consistency_group_utils(self, mock_pool):"},{"line_number":8352,"context_line":"        common \u003d self.driver.common"},{"line_number":8353,"context_line":"        common.conn \u003d FakeEcomConnection()"},{"line_number":8354,"context_line":"        common._initial_setup \u003d mock.Mock(return_value\u003dself.data.extra_specs)"},{"line_number":8355,"context_line":"        replicationService, storageSystem, extraSpecs \u003d ("},{"line_number":8356,"context_line":"            common._get_consistency_group_utils("},{"line_number":8357,"context_line":"                common.conn, EMCVMAXCommonData.test_CG))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_eaec85c9","line":8354,"in_reply_to":"7a8ec9b2_5b7c9120","updated":"2016-09-14 14:04:49.000000000","message":"Ok","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"}],"cinder/volume/drivers/emc/emc_vmax_common.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8b572ca4587d78611a36b8b4cee5983aefdac748","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        cgName \u003d self.utils.truncate_string(group[\u0027id\u0027], 8)"},{"line_number":2516,"context_line":""},{"line_number":2517,"context_line":"        modelUpdate \u003d {}"},{"line_number":2518,"context_line":"        volumes_model_update \u003d {}"},{"line_number":2519,"context_line":"        if not self.conn:"},{"line_number":2520,"context_line":"            self.conn \u003d self._get_ecom_connection()"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_f6adf4e9","line":2518,"updated":"2016-09-12 21:52:17.000000000","message":"Wrong initialization.  volumes_model_update is a list.","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"047562b83d76250c3d2937db7faa5af79ef33f3e","unresolved":false,"context_lines":[{"line_number":2515,"context_line":"        cgName \u003d self.utils.truncate_string(group[\u0027id\u0027], 8)"},{"line_number":2516,"context_line":""},{"line_number":2517,"context_line":"        modelUpdate \u003d {}"},{"line_number":2518,"context_line":"        volumes_model_update \u003d {}"},{"line_number":2519,"context_line":"        if not self.conn:"},{"line_number":2520,"context_line":"            self.conn \u003d self._get_ecom_connection()"},{"line_number":2521,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_17dc03e3","line":2518,"in_reply_to":"9a89bdaa_f6adf4e9","updated":"2016-09-13 08:31:53.000000000","message":"Thanks.  We will change this","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8b572ca4587d78611a36b8b4cee5983aefdac748","unresolved":false,"context_lines":[{"line_number":4324,"context_line":"                  volumes_model_update is a list of dictionaries of volume"},{"line_number":4325,"context_line":"                  update"},{"line_number":4326,"context_line":"        \"\"\""},{"line_number":4327,"context_line":"        if source_cg or source_vols:"},{"line_number":4328,"context_line":"            raise NotImplementedError()"},{"line_number":4329,"context_line":"        LOG.debug(\"Enter EMCVMAXCommon::create_consistencygroup_from_src. \""},{"line_number":4330,"context_line":"                  \"Group to be created: %(cgId)s, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_165338e3","line":4327,"updated":"2016-09-12 21:52:17.000000000","message":"Please add an error message here saying this is not supported by VMAX driver.","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"047562b83d76250c3d2937db7faa5af79ef33f3e","unresolved":false,"context_lines":[{"line_number":4324,"context_line":"                  volumes_model_update is a list of dictionaries of volume"},{"line_number":4325,"context_line":"                  update"},{"line_number":4326,"context_line":"        \"\"\""},{"line_number":4327,"context_line":"        if source_cg or source_vols:"},{"line_number":4328,"context_line":"            raise NotImplementedError()"},{"line_number":4329,"context_line":"        LOG.debug(\"Enter EMCVMAXCommon::create_consistencygroup_from_src. \""},{"line_number":4330,"context_line":"                  \"Group to be created: %(cgId)s, \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_f7e95f80","line":4327,"in_reply_to":"9a89bdaa_165338e3","updated":"2016-09-13 08:31:53.000000000","message":"Will do","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8b572ca4587d78611a36b8b4cee5983aefdac748","unresolved":false,"context_lines":[{"line_number":4544,"context_line":"        return endpoint"},{"line_number":4545,"context_line":""},{"line_number":4546,"context_line":"    def _get_consistency_group_utils(self, conn, group):"},{"line_number":4547,"context_line":"        \"\"\"Standard utility for consistency group"},{"line_number":4548,"context_line":""},{"line_number":4549,"context_line":"        :param conn: ecom connection"},{"line_number":4550,"context_line":"        :param group: the consistency group object to be created"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_36675cb8","line":4547,"updated":"2016-09-12 21:52:17.000000000","message":"nit: Missing period.","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"047562b83d76250c3d2937db7faa5af79ef33f3e","unresolved":false,"context_lines":[{"line_number":4544,"context_line":"        return endpoint"},{"line_number":4545,"context_line":""},{"line_number":4546,"context_line":"    def _get_consistency_group_utils(self, conn, group):"},{"line_number":4547,"context_line":"        \"\"\"Standard utility for consistency group"},{"line_number":4548,"context_line":""},{"line_number":4549,"context_line":"        :param conn: ecom connection"},{"line_number":4550,"context_line":"        :param group: the consistency group object to be created"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_57f92b4d","line":4547,"in_reply_to":"9a89bdaa_36675cb8","updated":"2016-09-13 08:31:53.000000000","message":"ok","commit_id":"5762819c688c2b4c80353ca24b2543056f80b8b6"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"397446e45594f73601a6df5fb94517f2fa55d433","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"                replicationService, cgName)"},{"line_number":2543,"context_line":"            if cgInstanceName is None:"},{"line_number":2544,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2545,"context_line":"                                     cgName)"},{"line_number":2546,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":2547,"context_line":"                    data\u003dexception_message)"},{"line_number":2548,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_7306e221","side":"PARENT","line":2545,"updated":"2016-09-13 20:08:16.000000000","message":"This one also changes an existing string.  Here is what I suggest:\n\nPut lines 2544-2545 back.\n\nThen add the following: \n# NOTE: Don\u0027t touch the above message due to soft string freeze.\nLOG.error(exception_message)\n\nThis way we don\u0027t need to worry about string changes.","commit_id":"781475f1148d4c730c257a224c8f528ec312c9f7"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8a206b3bd962903c006ee298e9c06d40c711da00","unresolved":false,"context_lines":[{"line_number":2542,"context_line":"                replicationService, cgName)"},{"line_number":2543,"context_line":"            if cgInstanceName is None:"},{"line_number":2544,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2545,"context_line":"                                     cgName)"},{"line_number":2546,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":2547,"context_line":"                    data\u003dexception_message)"},{"line_number":2548,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_9b48e45d","side":"PARENT","line":2545,"in_reply_to":"7a8ec9b2_7306e221","updated":"2016-09-13 20:52:36.000000000","message":"ok","commit_id":"781475f1148d4c730c257a224c8f528ec312c9f7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"397446e45594f73601a6df5fb94517f2fa55d433","unresolved":false,"context_lines":[{"line_number":4325,"context_line":"                  update"},{"line_number":4326,"context_line":"        \"\"\""},{"line_number":4327,"context_line":"        if source_cg or source_vols:"},{"line_number":4328,"context_line":"            LOG.error(_LE(\"The VMAX driver does not support creating a \""},{"line_number":4329,"context_line":"                          \"consistency group from a consistency group in \""},{"line_number":4330,"context_line":"                          \"this version.\"))"},{"line_number":4331,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_85908197","line":4328,"updated":"2016-09-13 20:08:16.000000000","message":"Change this to a debug message to avoid the problem of string freeze restriction.","commit_id":"c50a1af505a3f2bf30c3ca6cb21515ce0ab7adcf"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8a206b3bd962903c006ee298e9c06d40c711da00","unresolved":false,"context_lines":[{"line_number":4325,"context_line":"                  update"},{"line_number":4326,"context_line":"        \"\"\""},{"line_number":4327,"context_line":"        if source_cg or source_vols:"},{"line_number":4328,"context_line":"            LOG.error(_LE(\"The VMAX driver does not support creating a \""},{"line_number":4329,"context_line":"                          \"consistency group from a consistency group in \""},{"line_number":4330,"context_line":"                          \"this version.\"))"},{"line_number":4331,"context_line":"            raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a8ec9b2_9bb6243c","line":4328,"in_reply_to":"7a8ec9b2_85908197","updated":"2016-09-13 20:52:36.000000000","message":"Sure","commit_id":"c50a1af505a3f2bf30c3ca6cb21515ce0ab7adcf"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f40974f4682a329e0be7f1ed0ec23e1576968a13","unresolved":false,"context_lines":[{"line_number":2531,"context_line":"            if cgInstanceName is None:"},{"line_number":2532,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2533,"context_line":"                                     cgName)"},{"line_number":2534,"context_line":"                LOG.error(exception_message)"},{"line_number":2535,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2536,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2537,"context_line":"                    volumes, group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_9b0379b8","line":2534,"updated":"2016-09-14 03:39:26.000000000","message":"Add a note before line 2534 to explain you are not touching the above message due to soft string freeze, otherwise you may get comments to use _LE.  But if you use _LE, people may think you are changing the string.  See my comments in the previous patch set.","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b38c9d24e16595515018db9a132096d0ea3b3ec0","unresolved":false,"context_lines":[{"line_number":2531,"context_line":"            if cgInstanceName is None:"},{"line_number":2532,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2533,"context_line":"                                     cgName)"},{"line_number":2534,"context_line":"                LOG.error(exception_message)"},{"line_number":2535,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2536,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2537,"context_line":"                    volumes, group[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_2a3d8d2b","line":2534,"in_reply_to":"7a8ec9b2_9b0379b8","updated":"2016-09-14 14:04:49.000000000","message":"Sure","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"f40974f4682a329e0be7f1ed0ec23e1576968a13","unresolved":false,"context_lines":[{"line_number":4567,"context_line":"                poolInstances.add(_poolInstanceName)"},{"line_number":4568,"context_line":""},{"line_number":4569,"context_line":"        if len(poolInstances) is not 1:"},{"line_number":4570,"context_line":"                raise exception"},{"line_number":4571,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4572,"context_line":"            conn, storageSystem)"},{"line_number":4573,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_fb62bdac","line":4570,"updated":"2016-09-14 03:39:26.000000000","message":"Please raise a specific exception.\n\nYou got a pylint error probably from here although the line # does not match.\n\nhttp://logs.openstack.org/39/365739/4/check/gate-cinder-pylint/d9f4108/console.html","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"b38c9d24e16595515018db9a132096d0ea3b3ec0","unresolved":false,"context_lines":[{"line_number":4567,"context_line":"                poolInstances.add(_poolInstanceName)"},{"line_number":4568,"context_line":""},{"line_number":4569,"context_line":"        if len(poolInstances) is not 1:"},{"line_number":4570,"context_line":"                raise exception"},{"line_number":4571,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4572,"context_line":"            conn, storageSystem)"},{"line_number":4573,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a8ec9b2_ea8805ea","line":4570,"in_reply_to":"7a8ec9b2_fb62bdac","updated":"2016-09-14 14:04:49.000000000","message":"Yes, this is incorrect.  We will fix this.","commit_id":"f68f1f65fc2cc529b543f0cde41deea6d552d181"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4905d2c01d55df338af3e493bb6018bc9c50dd67","unresolved":false,"context_lines":[{"line_number":2570,"context_line":"            cgInstanceName \u003d self._find_consistency_group("},{"line_number":2571,"context_line":"                replicationService, cgName)"},{"line_number":2572,"context_line":"            if cgInstanceName is None:"},{"line_number":2573,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2574,"context_line":"                                     cgName)"},{"line_number":2575,"context_line":"                LOG.error(exception_message)"},{"line_number":2576,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_1106fc85","line":2573,"range":{"start_line":2573,"start_character":16,"end_line":2573,"end_character":33},"updated":"2016-10-06 19:11:09.000000000","message":"This is only used in the LOG.error now, so change to _LE() and move to be in the logging call using , instead of %.","commit_id":"2660b03f44c8ea8f4f62c611d2a8eb4a24452e77"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c42b5d6fc74db39ce171ea271be3666f9a706857","unresolved":false,"context_lines":[{"line_number":2570,"context_line":"            cgInstanceName \u003d self._find_consistency_group("},{"line_number":2571,"context_line":"                replicationService, cgName)"},{"line_number":2572,"context_line":"            if cgInstanceName is None:"},{"line_number":2573,"context_line":"                exception_message \u003d (_(\"Cannot find CG group %s.\") %"},{"line_number":2574,"context_line":"                                     cgName)"},{"line_number":2575,"context_line":"                LOG.error(exception_message)"},{"line_number":2576,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_5e886dc5","line":2573,"range":{"start_line":2573,"start_character":16,"end_line":2573,"end_character":33},"in_reply_to":"1a95cdbc_1106fc85","updated":"2016-10-07 13:59:25.000000000","message":"Sure","commit_id":"2660b03f44c8ea8f4f62c611d2a8eb4a24452e77"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":2556,"context_line":"        cgName \u003d self.utils.truncate_string(group[\u0027id\u0027], 8)"},{"line_number":2557,"context_line":""},{"line_number":2558,"context_line":"        modelUpdate \u003d {}"},{"line_number":2559,"context_line":"        volumes_model_update \u003d []"},{"line_number":2560,"context_line":"        if not self.conn:"},{"line_number":2561,"context_line":"            self.conn \u003d self._get_ecom_connection()"},{"line_number":2562,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_e3808b8d","line":2559,"range":{"start_line":2559,"start_character":8,"end_line":2559,"end_character":33},"updated":"2016-10-10 10:49:40.000000000","message":"-1: This is unnecessary, since we are not adding, but creating a new list in L2576","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":2556,"context_line":"        cgName \u003d self.utils.truncate_string(group[\u0027id\u0027], 8)"},{"line_number":2557,"context_line":""},{"line_number":2558,"context_line":"        modelUpdate \u003d {}"},{"line_number":2559,"context_line":"        volumes_model_update \u003d []"},{"line_number":2560,"context_line":"        if not self.conn:"},{"line_number":2561,"context_line":"            self.conn \u003d self._get_ecom_connection()"},{"line_number":2562,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_ca26ef15","line":2559,"range":{"start_line":2559,"start_character":8,"end_line":2559,"end_character":33},"in_reply_to":"1a95cdbc_e3808b8d","updated":"2016-10-11 13:45:05.000000000","message":"Ok. We will remove this","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"                          {\u0027cgName\u0027: cgName})"},{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_8346e778","line":2577,"range":{"start_line":2577,"start_character":29,"end_line":2577,"end_character":40},"updated":"2016-10-10 10:49:40.000000000","message":"-1: group is an OVO instance, so it should be \"group.id\"","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"                          {\u0027cgName\u0027: cgName})"},{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_6a65e343","line":2577,"range":{"start_line":2577,"start_character":29,"end_line":2577,"end_character":40},"in_reply_to":"1a95cdbc_8346e778","updated":"2016-10-11 13:45:05.000000000","message":"Ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_03a57745","line":2578,"range":{"start_line":2578,"start_character":27,"end_line":2578,"end_character":64},"updated":"2016-10-10 10:49:40.000000000","message":"-1: We shouldn\u0027t be using a ConsistencyGroupStatus to update the volumes.  This should be \u0027deleted\u0027.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_2a4ccbc6","line":2578,"range":{"start_line":2578,"start_character":27,"end_line":2578,"end_character":64},"in_reply_to":"1a95cdbc_03a57745","updated":"2016-10-11 13:45:05.000000000","message":"Ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"1211a249d09eb36b1383808b21a6762c0ea8cfee","unresolved":false,"context_lines":[{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_f4a89522","line":2578,"range":{"start_line":2578,"start_character":27,"end_line":2578,"end_character":64},"in_reply_to":"fa6399be_2a4ccbc6","updated":"2016-10-13 13:08:38.000000000","message":"This is an error case and covers a scenario where the volume was never created to begin with. The actual deletion happens in line 2591 below","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6e4aae925f4e598787adde76f9843681e625bdda","unresolved":false,"context_lines":[{"line_number":2575,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2576,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2577,"context_line":"                    volumes, group[\u0027id\u0027],"},{"line_number":2578,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2579,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_6f88fcc5","line":2578,"range":{"start_line":2578,"start_character":27,"end_line":2578,"end_character":64},"in_reply_to":"fa6399be_f4a89522","updated":"2016-10-14 11:16:58.000000000","message":"I don\u0027t understand what you mean, I wasn\u0027t saying we shouldn\u0027t be setting the status to error, I was just saying that we shouldn\u0027t be using a status field value from ConsistencyGroup to update a volume status.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":2616,"context_line":"        :returns: list -- list of volume objects"},{"line_number":2617,"context_line":"        :returns: dict -- modelUpdate"},{"line_number":2618,"context_line":"        \"\"\""},{"line_number":2619,"context_line":"        modelUpdate \u003d {}"},{"line_number":2620,"context_line":"        try:"},{"line_number":2621,"context_line":"            controllerConfigurationService \u003d ("},{"line_number":2622,"context_line":"                self.utils.find_controller_configuration_service("}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_433dbf8d","line":2619,"updated":"2016-10-10 10:49:40.000000000","message":"nit: We don\u0027t really need to set a default here, we could just create the dictionaries when we assign the status.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":2616,"context_line":"        :returns: list -- list of volume objects"},{"line_number":2617,"context_line":"        :returns: dict -- modelUpdate"},{"line_number":2618,"context_line":"        \"\"\""},{"line_number":2619,"context_line":"        modelUpdate \u003d {}"},{"line_number":2620,"context_line":"        try:"},{"line_number":2621,"context_line":"            controllerConfigurationService \u003d ("},{"line_number":2622,"context_line":"                self.utils.find_controller_configuration_service("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_cadb4fec","line":2619,"in_reply_to":"1a95cdbc_433dbf8d","updated":"2016-10-11 13:45:05.000000000","message":"Ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":2633,"context_line":"                self.provision.delete_volume_from_pool("},{"line_number":2634,"context_line":"                    self.conn, storageConfigservice,"},{"line_number":2635,"context_line":"                    memberInstanceNames, None, extraSpecs)"},{"line_number":2636,"context_line":"            modelUpdate[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.DELETED"},{"line_number":2637,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2638,"context_line":"                volumes, group[\u0027id\u0027],"},{"line_number":2639,"context_line":"                status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2640,"context_line":"        except Exception:"},{"line_number":2641,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2642,"context_line":"                volumes, group[\u0027id\u0027],"},{"line_number":2643,"context_line":"                status\u003dfields.ConsistencyGroupStatus.ERROR_DELETING)"},{"line_number":2644,"context_line":"            modelUpdate[\u0027status\u0027] \u003d ("},{"line_number":2645,"context_line":"                fields.ConsistencyGroupStatus.ERROR_DELETING)"},{"line_number":2646,"context_line":""},{"line_number":2647,"context_line":"        return volumes_model_update, modelUpdate"},{"line_number":2648,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_43a13ff7","line":2645,"range":{"start_line":2636,"start_character":0,"end_line":2645,"end_character":61},"updated":"2016-10-10 10:49:40.000000000","message":"-1: If we are going to take the liberty of using the ConsistencyGroupStatus status to set the Volume OVO, we might as well simplify the code:\n\n     modelUpdate[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.DELETED\n except Exception:\n     modelUpdate[\u0027status\u0027] \u003d (\n         fields.ConsistencyGroupStatus.ERROR_DELETING)\n\n volumes_model_update \u003d self.utils.get_volume_model_updates(\n     volumes, group.id, status\u003dmodelUpdate[\u0027status\u0027])","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":2633,"context_line":"                self.provision.delete_volume_from_pool("},{"line_number":2634,"context_line":"                    self.conn, storageConfigservice,"},{"line_number":2635,"context_line":"                    memberInstanceNames, None, extraSpecs)"},{"line_number":2636,"context_line":"            modelUpdate[\u0027status\u0027] \u003d fields.ConsistencyGroupStatus.DELETED"},{"line_number":2637,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2638,"context_line":"                volumes, group[\u0027id\u0027],"},{"line_number":2639,"context_line":"                status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2640,"context_line":"        except Exception:"},{"line_number":2641,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2642,"context_line":"                volumes, group[\u0027id\u0027],"},{"line_number":2643,"context_line":"                status\u003dfields.ConsistencyGroupStatus.ERROR_DELETING)"},{"line_number":2644,"context_line":"            modelUpdate[\u0027status\u0027] \u003d ("},{"line_number":2645,"context_line":"                fields.ConsistencyGroupStatus.ERROR_DELETING)"},{"line_number":2646,"context_line":""},{"line_number":2647,"context_line":"        return volumes_model_update, modelUpdate"},{"line_number":2648,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_0a9467e0","line":2645,"range":{"start_line":2636,"start_character":0,"end_line":2645,"end_character":61},"in_reply_to":"1a95cdbc_43a13ff7","updated":"2016-10-11 13:45:05.000000000","message":"Ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":4596,"context_line":"        \"\"\""},{"line_number":4597,"context_line":"        storageSystems \u003d set()"},{"line_number":4598,"context_line":""},{"line_number":4599,"context_line":"        volumeTypeIds \u003d group[\u0027volume_type_id\u0027].split(\",\")"},{"line_number":4600,"context_line":""},{"line_number":4601,"context_line":"        for volumeTypeId in volumeTypeIds:"},{"line_number":4602,"context_line":"            if volumeTypeId:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_e3196b23","line":4599,"range":{"start_line":4599,"start_character":24,"end_line":4599,"end_character":47},"updated":"2016-10-10 10:49:40.000000000","message":"-1: Group is an OVO instance:\n\n group.volume_type_id","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":4596,"context_line":"        \"\"\""},{"line_number":4597,"context_line":"        storageSystems \u003d set()"},{"line_number":4598,"context_line":""},{"line_number":4599,"context_line":"        volumeTypeIds \u003d group[\u0027volume_type_id\u0027].split(\",\")"},{"line_number":4600,"context_line":""},{"line_number":4601,"context_line":"        for volumeTypeId in volumeTypeIds:"},{"line_number":4602,"context_line":"            if volumeTypeId:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_aabb7b71","line":4599,"range":{"start_line":4599,"start_character":24,"end_line":4599,"end_character":47},"in_reply_to":"1a95cdbc_e3196b23","updated":"2016-10-11 13:45:05.000000000","message":"Ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4609,"context_line":""},{"line_number":4610,"context_line":"        if len(storageSystems) is not 1:"},{"line_number":4611,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4612,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4613,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4614,"context_line":"            LOG.exception(exception_message)"},{"line_number":4615,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_e39ecb61","line":4614,"range":{"start_line":4611,"start_character":1,"end_line":4614,"end_character":1},"updated":"2016-10-10 10:49:40.000000000","message":"-1: group.id\n\nnit: Message is ambiguous, I know this may be intentional, but I think we should have different errors for not found, and for multiple found.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":4608,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4609,"context_line":""},{"line_number":4610,"context_line":"        if len(storageSystems) is not 1:"},{"line_number":4611,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4612,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4613,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4614,"context_line":"            LOG.exception(exception_message)"},{"line_number":4615,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_aa729be3","line":4614,"range":{"start_line":4611,"start_character":1,"end_line":4614,"end_character":1},"in_reply_to":"1a95cdbc_e39ecb61","updated":"2016-10-11 13:45:05.000000000","message":"Agreed.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":4614,"context_line":"            LOG.exception(exception_message)"},{"line_number":4615,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"},{"line_number":4618,"context_line":""},{"line_number":4619,"context_line":"        return replicationService, storageSystem, extraSpecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_a3cda367","line":4617,"range":{"start_line":4617,"start_character":18,"end_line":4617,"end_character":42},"updated":"2016-10-10 10:49:40.000000000","message":"-1: Since we only have 1 element we should just do: \"storageSystems.pop()\"","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":4614,"context_line":"            LOG.exception(exception_message)"},{"line_number":4615,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"},{"line_number":4618,"context_line":""},{"line_number":4619,"context_line":"        return replicationService, storageSystem, extraSpecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_aa49bb8d","line":4617,"range":{"start_line":4617,"start_character":18,"end_line":4617,"end_character":42},"in_reply_to":"1a95cdbc_a3cda367","updated":"2016-10-11 13:45:05.000000000","message":"ok","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d56e619d2dc82f4a687084bdabb3e9ab564139b","unresolved":false,"context_lines":[{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"},{"line_number":4618,"context_line":""},{"line_number":4619,"context_line":"        return replicationService, storageSystem, extraSpecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a95cdbc_e3488bce","line":4619,"range":{"start_line":4619,"start_character":35,"end_line":4619,"end_character":48},"updated":"2016-10-10 10:49:40.000000000","message":"-1: According to the check on 4607 this variable may be None even after it had a previous non None value.  And we wanted the non None value.  We should just change L4616-4617 to:\n\n storageSystem \u003d storageSystems.pop()\n replicationService \u003d self.utils.find_replication_service(\n            conn, storageSystem)\n\nThat way we make sure that storageSystem has the right value.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"559bf4a631b7b0496b8a4d1f0714ce05fbce9e6b","unresolved":false,"context_lines":[{"line_number":4616,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4617,"context_line":"            conn, list(storageSystems)[0])"},{"line_number":4618,"context_line":""},{"line_number":4619,"context_line":"        return replicationService, storageSystem, extraSpecs"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa6399be_0a30e700","line":4619,"range":{"start_line":4619,"start_character":35,"end_line":4619,"end_character":48},"in_reply_to":"1a95cdbc_e3488bce","updated":"2016-10-11 13:45:05.000000000","message":"Ok.  Thanks for the feedback.","commit_id":"f5b6e178004d9a3e0773a71c502e2fa1ecbde940"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2575,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2576,"context_line":"                    volumes, group.id,"},{"line_number":2577,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2578,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_b0a31eb1","line":2577,"updated":"2016-10-17 09:47:09.000000000","message":"nit: ConsistencyGroupStatus should only be used to update the status of CGs, here we are updating a volume, so it would be best if we didn\u0027t use it here.","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dee57c7f932613de8480b848dfc54123d5a89c4b","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"                modelUpdate \u003d {\u0027status\u0027: fields.ConsistencyGroupStatus.DELETED}"},{"line_number":2575,"context_line":"                volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2576,"context_line":"                    volumes, group.id,"},{"line_number":2577,"context_line":"                    status\u003dfields.ConsistencyGroupStatus.DELETED)"},{"line_number":2578,"context_line":"                return modelUpdate, volumes_model_update"},{"line_number":2579,"context_line":""},{"line_number":2580,"context_line":"            memberInstanceNames \u003d self._get_members_of_replication_group("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_7099541f","line":2577,"in_reply_to":"fa6399be_b0a31eb1","updated":"2016-10-18 10:27:43.000000000","message":"Will update.....Thanks","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":2637,"context_line":"        except Exception:"},{"line_number":2638,"context_line":"            modelUpdate \u003d {"},{"line_number":2639,"context_line":"                \u0027status\u0027: fields.ConsistencyGroupStatus.ERROR_DELETING}"},{"line_number":2640,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2641,"context_line":"                volumes, group[\u0027id\u0027], status\u003dmodelUpdate[\u0027status\u0027])"},{"line_number":2642,"context_line":""},{"line_number":2643,"context_line":"        return volumes_model_update, modelUpdate"},{"line_number":2644,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_90d53ae6","line":2641,"range":{"start_line":2640,"start_character":1,"end_line":2641,"end_character":67},"updated":"2016-10-17 09:47:09.000000000","message":"-1: This is the same as L2635, so we should just leave 1 of them and it should either be in a finally clause or just out of the whole try...except clause.","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dee57c7f932613de8480b848dfc54123d5a89c4b","unresolved":false,"context_lines":[{"line_number":2637,"context_line":"        except Exception:"},{"line_number":2638,"context_line":"            modelUpdate \u003d {"},{"line_number":2639,"context_line":"                \u0027status\u0027: fields.ConsistencyGroupStatus.ERROR_DELETING}"},{"line_number":2640,"context_line":"            volumes_model_update \u003d self.utils.get_volume_model_updates("},{"line_number":2641,"context_line":"                volumes, group[\u0027id\u0027], status\u003dmodelUpdate[\u0027status\u0027])"},{"line_number":2642,"context_line":""},{"line_number":2643,"context_line":"        return volumes_model_update, modelUpdate"},{"line_number":2644,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_9043486c","line":2641,"range":{"start_line":2640,"start_character":1,"end_line":2641,"end_character":67},"in_reply_to":"fa6399be_90d53ae6","updated":"2016-10-18 10:27:43.000000000","message":"Good point. Will update....Thanks","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4603,"context_line":"                if storageSystem:"},{"line_number":4604,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"        if len(storageSystems) \u003d\u003d 0:"},{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_7048a6cc","line":4606,"range":{"start_line":4606,"start_character":0,"end_line":4606,"end_character":36},"updated":"2016-10-17 09:47:09.000000000","message":"nit: This is not very pythonic:\n\n if not storageSystems:","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dee57c7f932613de8480b848dfc54123d5a89c4b","unresolved":false,"context_lines":[{"line_number":4603,"context_line":"                if storageSystem:"},{"line_number":4604,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"        if len(storageSystems) \u003d\u003d 0:"},{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_0b4b895a","line":4606,"range":{"start_line":4606,"start_character":0,"end_line":4606,"end_character":36},"in_reply_to":"fa6399be_7048a6cc","updated":"2016-10-18 10:27:43.000000000","message":"Will update and check in....Thanks","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4606,"context_line":"        if len(storageSystems) \u003d\u003d 0:"},{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4610,"context_line":"            LOG.exception(exception_message)"},{"line_number":4611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4612,"context_line":"        elif len(storageSystems) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_30de2edd","line":4609,"range":{"start_line":4609,"start_character":35,"end_line":4609,"end_character":46},"updated":"2016-10-17 09:47:09.000000000","message":"-1: group.id","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4610,"context_line":"            LOG.exception(exception_message)"},{"line_number":4611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4612,"context_line":"        elif len(storageSystems) \u003e 1:"},{"line_number":4613,"context_line":"            exception_message \u003d (_(\"There are multiple storage systems \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_d036d201","line":4610,"updated":"2016-10-17 09:47:09.000000000","message":"-1: You shouldn\u0027t be using exception method, since there is no exception to be logged.","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4612,"context_line":"        elif len(storageSystems) \u003e 1:"},{"line_number":4613,"context_line":"            exception_message \u003d (_(\"There are multiple storage systems \""},{"line_number":4614,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4615,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4616,"context_line":"            LOG.exception(exception_message)"},{"line_number":4617,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4618,"context_line":"        storageSystem \u003d storageSystems.pop()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_f0cf5626","line":4615,"range":{"start_line":4615,"start_character":35,"end_line":4615,"end_character":46},"updated":"2016-10-17 09:47:09.000000000","message":"-1: ditto","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4613,"context_line":"            exception_message \u003d (_(\"There are multiple storage systems \""},{"line_number":4614,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4615,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4616,"context_line":"            LOG.exception(exception_message)"},{"line_number":4617,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4618,"context_line":"        storageSystem \u003d storageSystems.pop()"},{"line_number":4619,"context_line":"        replicationService \u003d self.utils.find_replication_service("}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_f03916f3","line":4616,"updated":"2016-10-17 09:47:09.000000000","message":"-1: ditto","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"fd6b0386ad99dfa6a4f1e484deb1b2da69b9591d","unresolved":false,"context_lines":[{"line_number":4603,"context_line":"                if storageSystem:"},{"line_number":4604,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"        if len(storageSystems) \u003d\u003d 0:"},{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4610,"context_line":"            LOG.exception(exception_message)"},{"line_number":4611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4612,"context_line":"        elif len(storageSystems) \u003e 1:"},{"line_number":4613,"context_line":"            exception_message \u003d (_(\"There are multiple storage systems \""},{"line_number":4614,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4615,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4616,"context_line":"            LOG.exception(exception_message)"},{"line_number":4617,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4618,"context_line":"        storageSystem \u003d storageSystems.pop()"},{"line_number":4619,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4620,"context_line":"            conn, storageSystem)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_b0c95e28","line":4617,"range":{"start_line":4606,"start_character":1,"end_line":4617,"end_character":77},"updated":"2016-10-17 09:47:09.000000000","message":"nit: Since the only thing that changes is the message, why not do it in the same if?\n\n if len(storageSystems) !\u003d 1:\n     if not storageSystems:\n         msg \u003d _(\"Failed to get a single storage system \"\n                  \"associated with consistencygroup_id: %s.\")\n     else:\n         msg \u003d _(\"There are multiple storage systems \"\n                 \"associated with consistencygroup_id: %s.\")\n\n     LOG.error(msg, group.id)\n     raise exception.VolumeBackendAPIException(data\u003dmsg)","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"dee57c7f932613de8480b848dfc54123d5a89c4b","unresolved":false,"context_lines":[{"line_number":4603,"context_line":"                if storageSystem:"},{"line_number":4604,"context_line":"                    storageSystems.add(storageSystem)"},{"line_number":4605,"context_line":""},{"line_number":4606,"context_line":"        if len(storageSystems) \u003d\u003d 0:"},{"line_number":4607,"context_line":"            exception_message \u003d (_(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4610,"context_line":"            LOG.exception(exception_message)"},{"line_number":4611,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4612,"context_line":"        elif len(storageSystems) \u003e 1:"},{"line_number":4613,"context_line":"            exception_message \u003d (_(\"There are multiple storage systems \""},{"line_number":4614,"context_line":"                                   \"associated with consistencygroup_id: %s.\")"},{"line_number":4615,"context_line":"                                 % group[\u0027id\u0027])"},{"line_number":4616,"context_line":"            LOG.exception(exception_message)"},{"line_number":4617,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dexception_message)"},{"line_number":4618,"context_line":"        storageSystem \u003d storageSystems.pop()"},{"line_number":4619,"context_line":"        replicationService \u003d self.utils.find_replication_service("},{"line_number":4620,"context_line":"            conn, storageSystem)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_ebc0157f","line":4617,"range":{"start_line":4606,"start_character":1,"end_line":4617,"end_character":77},"in_reply_to":"fa6399be_b0c95e28","updated":"2016-10-18 10:27:43.000000000","message":"Will do","commit_id":"7831d83c2c9bded4fa6e918f2901ef32bd0868ff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"be758f6e619a41e35e8d48817f8bb65118314ba9","unresolved":false,"context_lines":[{"line_number":4604,"context_line":""},{"line_number":4605,"context_line":"        if len(storageSystems) !\u003d 1:"},{"line_number":4606,"context_line":"            if not storageSystems:"},{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_705c0326","line":4607,"updated":"2016-10-21 09:39:10.000000000","message":"-1: Sorry I missed this in previous reviews:  You should be using _LE method instead since this will be logged at error log level.","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"fe51a1c15d17a63976e1774536e5e7cb1e8480ea","unresolved":false,"context_lines":[{"line_number":4604,"context_line":""},{"line_number":4605,"context_line":"        if len(storageSystems) !\u003d 1:"},{"line_number":4606,"context_line":"            if not storageSystems:"},{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_46dd3c0d","line":4607,"in_reply_to":"da6895a0_284daa72","updated":"2016-10-25 10:04:39.000000000","message":"Thanks Sean, so to clarify, this does not need to be changed to _LE?","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"95f8688870c4e239175bf904a27bbe28ac000edb","unresolved":false,"context_lines":[{"line_number":4604,"context_line":""},{"line_number":4605,"context_line":"        if len(storageSystems) !\u003d 1:"},{"line_number":4606,"context_line":"            if not storageSystems:"},{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_e674d9fe","line":4607,"in_reply_to":"da6895a0_705c0326","updated":"2016-10-21 10:53:27.000000000","message":"Sure.  We will fix","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0e95cf5d00188eb79d2394c64b933d6f1893154c","unresolved":false,"context_lines":[{"line_number":4604,"context_line":""},{"line_number":4605,"context_line":"        if len(storageSystems) !\u003d 1:"},{"line_number":4606,"context_line":"            if not storageSystems:"},{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_284daa72","line":4607,"in_reply_to":"da6895a0_e674d9fe","updated":"2016-10-21 20:36:28.000000000","message":"_() is appropriate here since it is also used in the exception message.","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"be758f6e619a41e35e8d48817f8bb65118314ba9","unresolved":false,"context_lines":[{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""},{"line_number":4611,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4612,"context_line":"            LOG.error(msg, group.id)"},{"line_number":4613,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_9041973c","line":4610,"updated":"2016-10-21 09:39:10.000000000","message":"-1: ditto","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"95f8688870c4e239175bf904a27bbe28ac000edb","unresolved":false,"context_lines":[{"line_number":4607,"context_line":"                msg \u003d _(\"Failed to get a single storage system \""},{"line_number":4608,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4609,"context_line":"            else:"},{"line_number":4610,"context_line":"                msg \u003d _(\"There are multiple storage systems \""},{"line_number":4611,"context_line":"                        \"associated with consistencygroup_id: %s.\")"},{"line_number":4612,"context_line":"            LOG.error(msg, group.id)"},{"line_number":4613,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da6895a0_665fe972","line":4610,"in_reply_to":"da6895a0_9041973c","updated":"2016-10-21 10:53:27.000000000","message":"Sure.  As always, thank you for the great feedback","commit_id":"67d86a22c822971fb205f6046fb70bf3c0b82621"}],"cinder/volume/drivers/emc/emc_vmax_utils.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4905d2c01d55df338af3e493bb6018bc9c50dd67","unresolved":false,"context_lines":[{"line_number":2337,"context_line":"            self, volumes, cgId, status\u003d\u0027available\u0027):"},{"line_number":2338,"context_line":"        \"\"\"Update the volume model\u0027s status and return it."},{"line_number":2339,"context_line":""},{"line_number":2340,"context_line":"        :param context: the context"},{"line_number":2341,"context_line":"        :param volumes: volumes object api"},{"line_number":2342,"context_line":"        :param cgId: cg id"},{"line_number":2343,"context_line":"        :param status: string value reflects the status of the member volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_117b5cf6","line":2340,"range":{"start_line":2340,"start_character":15,"end_line":2340,"end_character":22},"updated":"2016-10-06 19:11:09.000000000","message":"Remove this docstring now.","commit_id":"2660b03f44c8ea8f4f62c611d2a8eb4a24452e77"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c42b5d6fc74db39ce171ea271be3666f9a706857","unresolved":false,"context_lines":[{"line_number":2337,"context_line":"            self, volumes, cgId, status\u003d\u0027available\u0027):"},{"line_number":2338,"context_line":"        \"\"\"Update the volume model\u0027s status and return it."},{"line_number":2339,"context_line":""},{"line_number":2340,"context_line":"        :param context: the context"},{"line_number":2341,"context_line":"        :param volumes: volumes object api"},{"line_number":2342,"context_line":"        :param cgId: cg id"},{"line_number":2343,"context_line":"        :param status: string value reflects the status of the member volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_dec2bde8","line":2340,"range":{"start_line":2340,"start_character":15,"end_line":2340,"end_character":22},"in_reply_to":"1a95cdbc_117b5cf6","updated":"2016-10-07 13:59:25.000000000","message":"will do. Thank you","commit_id":"2660b03f44c8ea8f4f62c611d2a8eb4a24452e77"}]}