)]}'
{"cinder/volume/drivers/kaminario/kaminario_common.py":[{"author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"change_message_id":"b28ef674ef675f6dbec65bc3bbaa79561663edef","unresolved":false,"context_lines":[{"line_number":653,"context_line":"                                              dest_attach_info)"},{"line_number":654,"context_line":"            self.terminate_connection(volume, properties)"},{"line_number":655,"context_line":"            self.terminate_connection(src_vref, properties)"},{"line_number":656,"context_line":"        except Exception as ex:"},{"line_number":657,"context_line":"            self._kaminario_disconnect_volume(src_attach_info,"},{"line_number":658,"context_line":"                                              dest_attach_info)"},{"line_number":659,"context_line":"            self.terminate_connection(src_vref, properties)"},{"line_number":660,"context_line":"            self.terminate_connection(volume, properties)"},{"line_number":661,"context_line":"            self.delete_volume(volume)"},{"line_number":662,"context_line":"            LOG.exception(_LE(\"Create a clone: %s failed.\"), clone_name)"},{"line_number":663,"context_line":"            raise exception.KaminarioCinderDriverException("},{"line_number":664,"context_line":"                reason\u003dsix.text_type(ex.message))"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"    @kaminario_logger"},{"line_number":667,"context_line":"    def delete_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_3493735c","line":664,"range":{"start_line":656,"start_character":8,"end_line":664,"end_character":49},"updated":"2016-09-08 17:53:48.000000000","message":"It\u0027s probably fine for now, you may want to look into a better way to handle errors with the attach/detach stuff in these methods. If the disconnect fails, or maybe the first terminate_connection, you wouldn\u0027t clean up everything and raise/log the nice error message.","commit_id":"084e11ed0d543c10715c4ca44c020e44c8402bf2"}]}