)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c1f8180b314e8a2c0f9ee634476e6d9d0c5046a0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"if is_uuid_like identity:"},{"line_number":13,"context_line":"   get_volume_type_by_name(identity)"},{"line_number":14,"context_line":"   else:"},{"line_number":15,"context_line":"       get_volume_type(identity)"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"we can combine these functions to clean code"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_cc457743","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":32},"updated":"2016-09-08 12:13:31.000000000","message":"nit: Indentation level is wrong","commit_id":"7979a0eab21b5cb53ec454e98f3f7d4b22ff5d29"}],"cinder/api/contrib/volume_manage.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2fbe84dc2d7175d1a60ef7364fcaf3d3d213186f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        req_volume_type \u003d volume.get(\u0027volume_type\u0027, None)"},{"line_number":120,"context_line":"        if req_volume_type:"},{"line_number":121,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":122,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_types.\\"},{"line_number":123,"context_line":"                get_by_name_or_id(context, req_volume_type)"},{"line_number":124,"context_line":"        else:"},{"line_number":125,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_b6ea8c72","line":122,"range":{"start_line":122,"start_character":49,"end_line":122,"end_character":50},"updated":"2016-09-12 22:02:06.000000000","message":"Since you are cleaning up the code, is there a way to do this without the \u0027/\u0027?","commit_id":"ae0ffa92ea2e487c85becb9011ac172093016610"}],"cinder/api/v1/volumes.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2fbe84dc2d7175d1a60ef7364fcaf3d3d213186f","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        req_volume_type \u003d volume.get(\u0027volume_type\u0027, None)"},{"line_number":227,"context_line":"        if req_volume_type:"},{"line_number":228,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":229,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_types.\\"},{"line_number":230,"context_line":"                get_by_name_or_id(context, req_volume_type)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        kwargs[\u0027metadata\u0027] \u003d volume.get(\u0027metadata\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_16fa5843","line":229,"range":{"start_line":229,"start_character":49,"end_line":229,"end_character":50},"updated":"2016-09-12 22:02:06.000000000","message":"Same comment.","commit_id":"ae0ffa92ea2e487c85becb9011ac172093016610"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2fbe84dc2d7175d1a60ef7364fcaf3d3d213186f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        req_volume_type \u003d volume.get(\u0027volume_type\u0027, None)"},{"line_number":197,"context_line":"        if req_volume_type:"},{"line_number":198,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":199,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_types.\\"},{"line_number":200,"context_line":"                get_by_name_or_id(context, req_volume_type)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        kwargs[\u0027metadata\u0027] \u003d volume.get(\u0027metadata\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_769ba418","line":199,"range":{"start_line":199,"start_character":49,"end_line":199,"end_character":50},"updated":"2016-09-12 22:02:06.000000000","message":"Same comment.","commit_id":"ae0ffa92ea2e487c85becb9011ac172093016610"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2fbe84dc2d7175d1a60ef7364fcaf3d3d213186f","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        req_volume_type \u003d volume.get(\u0027volume_type\u0027, None)"},{"line_number":154,"context_line":"        if req_volume_type:"},{"line_number":155,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":156,"context_line":"            kwargs[\u0027volume_type\u0027] \u003d volume_types.\\"},{"line_number":157,"context_line":"                get_by_name_or_id(context, req_volume_type)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        kwargs[\u0027metadata\u0027] \u003d volume.get(\u0027metadata\u0027, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_b6a1ac48","line":156,"range":{"start_line":156,"start_character":49,"end_line":156,"end_character":50},"updated":"2016-09-12 22:02:06.000000000","message":"Same comment.","commit_id":"ae0ffa92ea2e487c85becb9011ac172093016610"}],"cinder/volume/api.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2fbe84dc2d7175d1a60ef7364fcaf3d3d213186f","unresolved":false,"context_lines":[{"line_number":1454,"context_line":""},{"line_number":1455,"context_line":"        # Support specifying volume type by ID or name"},{"line_number":1456,"context_line":"        try:"},{"line_number":1457,"context_line":"            vol_type \u003d volume_types.\\"},{"line_number":1458,"context_line":"                get_by_name_or_id(context.elevated(), new_type)"},{"line_number":1459,"context_line":"        except exception.InvalidVolumeType:"},{"line_number":1460,"context_line":"            msg \u003d _(\u0027Invalid volume_type passed: %s.\u0027) % new_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_368e7cd0","line":1457,"range":{"start_line":1457,"start_character":36,"end_line":1457,"end_character":37},"updated":"2016-09-12 22:02:06.000000000","message":"Same comment.","commit_id":"ae0ffa92ea2e487c85becb9011ac172093016610"}],"cinder/volume/volume_types.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c1f8180b314e8a2c0f9ee634476e6d9d0c5046a0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    return db.volume_type_get(ctxt, id, expected_fields\u003dexpected_fields)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def get_vol_type_by_name_or_id(context, identity):"},{"line_number":135,"context_line":"    \"\"\"Retrieves volume type by id or name\"\"\""},{"line_number":136,"context_line":"    if not uuidutils.is_uuid_like(identity):"},{"line_number":137,"context_line":"        return get_volume_type_by_name(context, identity)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_acc75362","line":134,"updated":"2016-09-08 12:13:31.000000000","message":"I think this should be renamed get_by_name_or_id, since it\u0027s already inside volume_types it\u0027s very clear when you call it what you are doing:\n\n from cinder.volume import volume_types\n\n volume_types.get_by_name_or_id(...)","commit_id":"7979a0eab21b5cb53ec454e98f3f7d4b22ff5d29"}]}