)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5f27a2f7d2f7fea99fc6f3b70400fec49aa76a37","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add test_get_all_by_volume in objects/test_backup"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a get_all_by_volume in the backup, but it has no"},{"line_number":10,"context_line":"test_get_all_by_volume in the test_backuo.Therefore, I add it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I68109402dd354a3a3e03bd81240ad451b873bc10"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a89bdaa_b4e4ccac","line":10,"range":{"start_line":10,"start_character":35,"end_line":10,"end_character":41},"updated":"2016-09-09 05:52:43.000000000","message":"backup","commit_id":"b2cfd287a599bb858b46040400bba13dec01cf67"}],"cinder/tests/unit/objects/test_backup.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"5f27a2f7d2f7fea99fc6f3b70400fec49aa76a37","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        backups \u003d objects.BackupList.get_all_by_volume(self.context,"},{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"},{"line_number":238,"context_line":"        self.assertEqual(1, len(backups))"},{"line_number":239,"context_line":"        TestBackup._compare(self, fake_backup, backups[0])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_740b242c","line":238,"updated":"2016-09-09 05:52:43.000000000","message":"Also assert for the DB call.\n\nget_all_by_volume.assert_called_once_with(self.context, fake_volume_obj.id, None)","commit_id":"b2cfd287a599bb858b46040400bba13dec01cf67"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1cecc762500f8a16b1030299f2b70dcc51a54688","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @mock.patch(\u0027cinder.db.backup_get_all_by_host\u0027,"},{"line_number":215,"context_line":"                return_value\u003d[fake_backup])"},{"line_number":216,"context_line":"    def test_get_all_for_volume(self, get_all_by_host):"},{"line_number":217,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        backups \u003d objects.BackupList.get_all_by_host(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_f1dca21a","line":216,"range":{"start_line":216,"start_character":8,"end_line":216,"end_character":31},"updated":"2016-09-22 11:28:06.000000000","message":"Can you rename this test case to test_get_all_by_host? Looks like this naming mistake caused the fact we\u0027ve omitted the test.","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"c25447a0f10ad53778ad3df14e10e0015c38edc4","unresolved":false,"context_lines":[{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    @mock.patch(\u0027cinder.db.backup_get_all_by_host\u0027,"},{"line_number":215,"context_line":"                return_value\u003d[fake_backup])"},{"line_number":216,"context_line":"    def test_get_all_for_volume(self, get_all_by_host):"},{"line_number":217,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"        backups \u003d objects.BackupList.get_all_by_host(self.context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_bf1d81bf","line":216,"range":{"start_line":216,"start_character":8,"end_line":216,"end_character":31},"in_reply_to":"5a8bc5a2_f1dca21a","updated":"2016-09-22 12:11:05.000000000","message":"Done","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1cecc762500f8a16b1030299f2b70dcc51a54688","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    @mock.patch(\u0027cinder.db.backup_get_all_by_volume\u0027,"},{"line_number":232,"context_line":"                return_value\u003d[fake_backup])"},{"line_number":233,"context_line":"    def test_get_all_by_volume(self, get_all_by_volume):"},{"line_number":234,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        backups \u003d objects.BackupList.get_all_by_volume(self.context,"},{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_91cb5e72","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":67},"updated":"2016-09-22 11:28:06.000000000","message":"No need for that, because…","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"c25447a0f10ad53778ad3df14e10e0015c38edc4","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    @mock.patch(\u0027cinder.db.backup_get_all_by_volume\u0027,"},{"line_number":232,"context_line":"                return_value\u003d[fake_backup])"},{"line_number":233,"context_line":"    def test_get_all_by_volume(self, get_all_by_volume):"},{"line_number":234,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        backups \u003d objects.BackupList.get_all_by_volume(self.context,"},{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_5f6d5d31","line":234,"range":{"start_line":234,"start_character":0,"end_line":234,"end_character":67},"in_reply_to":"5a8bc5a2_91cb5e72","updated":"2016-09-22 12:11:05.000000000","message":"Done","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1cecc762500f8a16b1030299f2b70dcc51a54688","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        backups \u003d objects.BackupList.get_all_by_volume(self.context,"},{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"},{"line_number":238,"context_line":"        self.assertEqual(1, len(backups))"},{"line_number":239,"context_line":"        get_all_by_volume.assert_called_once_with(self.context,"},{"line_number":240,"context_line":"                                                  fake_volume_obj.id, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_31ab6a8b","line":237,"range":{"start_line":237,"start_character":55,"end_line":237,"end_character":73},"updated":"2016-09-22 11:28:06.000000000","message":"…you can use fake.VOLUME_ID here…","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"c25447a0f10ad53778ad3df14e10e0015c38edc4","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        fake_volume_obj \u003d fake_volume.fake_volume_obj(self.context)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        backups \u003d objects.BackupList.get_all_by_volume(self.context,"},{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"},{"line_number":238,"context_line":"        self.assertEqual(1, len(backups))"},{"line_number":239,"context_line":"        get_all_by_volume.assert_called_once_with(self.context,"},{"line_number":240,"context_line":"                                                  fake_volume_obj.id, None)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_9f77e501","line":237,"range":{"start_line":237,"start_character":55,"end_line":237,"end_character":73},"in_reply_to":"5a8bc5a2_31ab6a8b","updated":"2016-09-22 12:11:05.000000000","message":"Done","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"1cecc762500f8a16b1030299f2b70dcc51a54688","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"},{"line_number":238,"context_line":"        self.assertEqual(1, len(backups))"},{"line_number":239,"context_line":"        get_all_by_volume.assert_called_once_with(self.context,"},{"line_number":240,"context_line":"                                                  fake_volume_obj.id, None)"},{"line_number":241,"context_line":"        TestBackup._compare(self, fake_backup, backups[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_51b0f6f4","line":240,"range":{"start_line":240,"start_character":50,"end_line":240,"end_character":68},"updated":"2016-09-22 11:28:06.000000000","message":"…and here.","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"},{"author":{"_account_id":22059,"name":"zheng yin","email":"yin__zheng@163.com","username":"zy751713126"},"change_message_id":"c25447a0f10ad53778ad3df14e10e0015c38edc4","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                                                       fake_volume_obj.id)"},{"line_number":238,"context_line":"        self.assertEqual(1, len(backups))"},{"line_number":239,"context_line":"        get_all_by_volume.assert_called_once_with(self.context,"},{"line_number":240,"context_line":"                                                  fake_volume_obj.id, None)"},{"line_number":241,"context_line":"        TestBackup._compare(self, fake_backup, backups[0])"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_ff64694a","line":240,"range":{"start_line":240,"start_character":50,"end_line":240,"end_character":68},"in_reply_to":"5a8bc5a2_51b0f6f4","updated":"2016-09-22 12:11:05.000000000","message":"Done","commit_id":"4d1f18ce067da1e2cd57923595227ac25a509e6a"}]}
