)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"0a7dec0ec38cad4f9f11aef1307178a7c998dce2","unresolved":false,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"        return snapshot_list"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    def _create_snapshot_in_db_validate(self, context, volume):"},{"line_number":878,"context_line":"        check_policy(context, \u0027create_snapshot\u0027, volume)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if volume[\u0027status\u0027] \u003d\u003d \u0027maintenance\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_81a95127","line":877,"updated":"2016-09-09 01:43:02.000000000","message":"The three error branches should be all logged with:\n\nLOG.error(error_message)","commit_id":"acb86b6d488f2dc167029bb865e37cdeb80c4ca2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9117a88814abe58943abb779a8fdfeb9947e960e","unresolved":false,"context_lines":[{"line_number":874,"context_line":""},{"line_number":875,"context_line":"        return snapshot_list"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    def _create_snapshot_in_db_validate(self, context, volume):"},{"line_number":878,"context_line":"        check_policy(context, \u0027create_snapshot\u0027, volume)"},{"line_number":879,"context_line":""},{"line_number":880,"context_line":"        if volume[\u0027status\u0027] \u003d\u003d \u0027maintenance\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_6b6c1f37","line":877,"in_reply_to":"9a89bdaa_81a95127","updated":"2016-09-09 07:43:23.000000000","message":"I actually think they should all be logged with info level, as this is not an actual error that the admin would care about, and the user will be getting a proper error message.\n\nThis patch is only intended to cleanup this part of the code, so it should not be changing logging levels.","commit_id":"acb86b6d488f2dc167029bb865e37cdeb80c4ca2"}]}
