)]}'
{"cinder/utils.py":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"5c22a5855708856a139d1aca9f832eedc16d3364","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            if conn.get_transport().is_active():"},{"line_number":239,"context_line":"                return conn"},{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                conn.close()"},{"line_number":242,"context_line":"        return self.create()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def remove(self, ssh):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F2L8%3D","line":241,"updated":"2013-07-22 07:54:14.000000000","message":"Should this inactive connection be removed from the pool? Otherwise, all inactive connection will fill up the pool and no new connection will be able to create.\n\n    self.remove(conn)","commit_id":"cccf7b92c189bcadf6898019730d84bfd4fe70b6"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"8af061f119942ff63723c53d417d136ee099efbd","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            if conn.get_transport().is_active():"},{"line_number":239,"context_line":"                return conn"},{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                conn.close()"},{"line_number":242,"context_line":"        return self.create()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def remove(self, ssh):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FzG8%3D","line":241,"in_reply_to":"AAAAQn%2F%2F1JA%3D","updated":"2013-07-23 02:21:17.000000000","message":"make sense.","commit_id":"cccf7b92c189bcadf6898019730d84bfd4fe70b6"},{"author":{"_account_id":6939,"name":"Xiaoxi Chen","email":"superdebuger@gmail.com","username":"xiaoxi-chen"},"change_message_id":"6b1151ade45d9c60e237f3f54e272badad6b8251","unresolved":false,"context_lines":[{"line_number":238,"context_line":"            if conn.get_transport().is_active():"},{"line_number":239,"context_line":"                return conn"},{"line_number":240,"context_line":"            else:"},{"line_number":241,"context_line":"                conn.close()"},{"line_number":242,"context_line":"        return self.create()"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def remove(self, ssh):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F1JA%3D","line":241,"in_reply_to":"AAAAQn%2F%2F2L8%3D","updated":"2013-07-22 15:09:40.000000000","message":"The inactive connection is removed from the pool once the super.get() is called.\nThe remove function is not appear in the base class and only used by H3C iscsi driver, plan to re-factor the H3C driver in a different patch and clean up the remove function.","commit_id":"cccf7b92c189bcadf6898019730d84bfd4fe70b6"}]}