)]}'
{"cinder/tests/unit/volume/drivers/emc/test_emc_xtremio.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d8841049ffaa1dda6301bfc09a9b540ea80b496f","unresolved":false,"context_lines":[{"line_number":944,"context_line":"class EMCXIODriverTestCase(BaseEMCXIODriverTestCase):"},{"line_number":945,"context_line":"    # ##### XMS Client #####"},{"line_number":946,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027, mock.Mock(return_value\u003d0))"},{"line_number":947,"context_line":"    def test_retry_request(self, req):"},{"line_number":948,"context_line":"        busy_response \u003d mock.MagicMock()"},{"line_number":949,"context_line":"        busy_response.status_code \u003d 400"},{"line_number":950,"context_line":"        busy_response.json.return_value \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_00ff84aa","side":"PARENT","line":947,"updated":"2016-10-06 20:43:25.000000000","message":"IMO it doesn\u0027t make sense to retest the retrying behavior. Its already tested in the underlying tenacity package as well as in the test_utils UTs herein.","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hnas_backend.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d8841049ffaa1dda6301bfc09a9b540ea80b496f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"        self.assertIn(\u0027fs-cinder\u0027, out)"},{"line_number":277,"context_line":"        self.assertIn(\u0027WFS-2,128 DSBs\u0027, out)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_run_cmd_retry_exception(self):"},{"line_number":280,"context_line":"        self.hnas_backend.cluster_admin_ip0 \u003d \u0027172.24.44.11\u0027"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        exceptions \u003d [putils.ProcessExecutionError(stderr\u003d\u0027Connection reset\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_40334cab","side":"PARENT","line":279,"updated":"2016-10-06 20:43:25.000000000","message":"IMO it doesn\u0027t make sense to retest the retrying behavior. Its already tested in the underlying tenacity package as well as in the test_utils UTs herein.","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_base.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d8841049ffaa1dda6301bfc09a9b540ea80b496f","unresolved":false,"context_lines":[{"line_number":567,"context_line":"        self.client.send_request.assert_called_once_with("},{"line_number":568,"context_line":"            \u0027cg-commit\u0027, {\u0027cg-id\u0027: snapshot_commit[\u0027cg-id\u0027]})"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def test_wait_for_busy_snapshot_raise_exception(self):"},{"line_number":571,"context_line":"        BUSY_SNAPSHOT \u003d dict(fake.SNAPSHOT)"},{"line_number":572,"context_line":"        BUSY_SNAPSHOT[\u0027busy\u0027] \u003d True"},{"line_number":573,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a0225050","side":"PARENT","line":570,"updated":"2016-10-06 20:43:25.000000000","message":"IMO it doesn\u0027t make sense to retest the retrying behavior. Its already tested in the underlying tenacity package as well as in the test_utils UTs herein.","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d8841049ffaa1dda6301bfc09a9b540ea80b496f","unresolved":false,"context_lines":[{"line_number":3164,"context_line":"        mock_get_snapshot.assert_called_once_with(fake.FLEXVOL,"},{"line_number":3165,"context_line":"                                                  fake.SNAPSHOT_NAME)"},{"line_number":3166,"context_line":""},{"line_number":3167,"context_line":"    def test_wait_for_busy_snapshot_raise_exception(self):"},{"line_number":3168,"context_line":"        # Need to mock sleep as it is called by @utils.retry"},{"line_number":3169,"context_line":"        self.mock_object(time, \u0027sleep\u0027)"},{"line_number":3170,"context_line":"        BUSY_SNAPSHOT \u003d dict(fake.SNAPSHOT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_c01f5c06","side":"PARENT","line":3167,"updated":"2016-10-06 20:43:25.000000000","message":"IMO it doesn\u0027t make sense to retest the retrying behavior. Its already tested in the underlying tenacity package as well as in the test_utils UTs herein.","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e6a86af6c4f72accad00e1a91c43d37834d0118b","unresolved":false,"context_lines":[{"line_number":3164,"context_line":"        mock_get_snapshot.assert_called_once_with(fake.FLEXVOL,"},{"line_number":3165,"context_line":"                                                  fake.SNAPSHOT_NAME)"},{"line_number":3166,"context_line":""},{"line_number":3167,"context_line":"    def test_wait_for_busy_snapshot_raise_exception(self):"},{"line_number":3168,"context_line":"        # Need to mock sleep as it is called by @utils.retry"},{"line_number":3169,"context_line":"        self.mock_object(time, \u0027sleep\u0027)"},{"line_number":3170,"context_line":"        BUSY_SNAPSHOT \u003d dict(fake.SNAPSHOT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_7d55d31b","side":"PARENT","line":3167,"in_reply_to":"1a95cdbc_50e30333","updated":"2016-10-10 19:42:24.000000000","message":"Done","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"d9aef76d28cd40cf65872bd7353e1c46e19f3797","unresolved":false,"context_lines":[{"line_number":3164,"context_line":"        mock_get_snapshot.assert_called_once_with(fake.FLEXVOL,"},{"line_number":3165,"context_line":"                                                  fake.SNAPSHOT_NAME)"},{"line_number":3166,"context_line":""},{"line_number":3167,"context_line":"    def test_wait_for_busy_snapshot_raise_exception(self):"},{"line_number":3168,"context_line":"        # Need to mock sleep as it is called by @utils.retry"},{"line_number":3169,"context_line":"        self.mock_object(time, \u0027sleep\u0027)"},{"line_number":3170,"context_line":"        BUSY_SNAPSHOT \u003d dict(fake.SNAPSHOT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_50e30333","side":"PARENT","line":3167,"in_reply_to":"1a95cdbc_c01f5c06","updated":"2016-10-07 11:10:40.000000000","message":"IMO we shouldn\u0027t remove this because it is also covering lines 457-461 in wait_for_busy_snapshot and not just the retrying logic.\n\nhttps://github.com/openstack/cinder/blob/a15459a27777e98599d70392191b0a6f0288ff34/cinder/volume/drivers/netapp/dataontap/client/client_base.py#L457-L461\n\nWe should test if the snapshot is busy, then it finally raises SnapshotIsBusy.","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"}]}