)]}'
{"cinder/volume/drivers/emc/scaleio.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"38342924919cc81ced9010ad86e76d92782f1beb","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":1145,"context_line":"            response \u003d r.json()"},{"line_number":1146,"context_line":"            error_code \u003d response[\u0027errorCode\u0027]"},{"line_number":1147,"context_line":"            if ((error_code \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1148,"context_line":"                 error_code \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR or"},{"line_number":1149,"context_line":"                 error_code \u003d\u003d ILLEGAL_SYNTAX)):"},{"line_number":1150,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume \""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_f03fe522","line":1147,"updated":"2016-09-12 09:45:44.000000000","message":"nit: I\u0027m surprised that you don\u0027t check status_code for 400. If sio gateway returns 500 due to an internal error, this check of error_code will be invalid. Particularly the added check for 0 (ILLEGAL_SYNTAX) may lead to incorrect results, because those gateway 500 errors which i saw had error_code\u003d0.","commit_id":"2089e4e5e57ae32a26cbd06b35a57a186b8ee7b4"},{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"38342924919cc81ced9010ad86e76d92782f1beb","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            error_code \u003d response[\u0027errorCode\u0027]"},{"line_number":1147,"context_line":"            if ((error_code \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1148,"context_line":"                 error_code \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR or"},{"line_number":1149,"context_line":"                 error_code \u003d\u003d ILLEGAL_SYNTAX)):"},{"line_number":1150,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume \""},{"line_number":1151,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"},{"line_number":1152,"context_line":"                         {\u0027vol\u0027: vol_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_907cd9ec","line":1149,"updated":"2016-09-12 09:45:44.000000000","message":"\u0027in (...)\u0027 would be more readable, imho","commit_id":"2089e4e5e57ae32a26cbd06b35a57a186b8ee7b4"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cdc20962b52932193d49f36dd57b28b085c436e3","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"            error_code \u003d response[\u0027errorCode\u0027]"},{"line_number":1147,"context_line":"            if ((error_code \u003d\u003d VOLUME_NOT_FOUND_ERROR or"},{"line_number":1148,"context_line":"                 error_code \u003d\u003d OLD_VOLUME_NOT_FOUND_ERROR or"},{"line_number":1149,"context_line":"                 error_code \u003d\u003d ILLEGAL_SYNTAX)):"},{"line_number":1150,"context_line":"                LOG.info(_LI(\"Ignoring renaming action because the volume \""},{"line_number":1151,"context_line":"                             \"%(vol)s is not a ScaleIO volume.\"),"},{"line_number":1152,"context_line":"                         {\u0027vol\u0027: vol_id})"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a89bdaa_9658fa8b","line":1149,"in_reply_to":"9a89bdaa_907cd9ec","updated":"2016-09-13 14:36:32.000000000","message":"+1","commit_id":"2089e4e5e57ae32a26cbd06b35a57a186b8ee7b4"}]}