)]}'
{"cinder/quota.py":[{"author":{"_account_id":4159,"name":"Cory Stone","email":"corystone@gmail.com","username":"corystone"},"change_message_id":"0cd75a16f1b84ce74df45bcef5d4146272bad913","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        if not volume_type_id:"},{"line_number":881,"context_line":"            return"},{"line_number":882,"context_line":"        try:"},{"line_number":883,"context_line":"            volume_type \u003d db.volume_type_get(context, volume_type_id)"},{"line_number":884,"context_line":"        except exception.VolumeTypeNotFound:"},{"line_number":885,"context_line":"            volume_type \u003d None"},{"line_number":886,"context_line":"            volume_types \u003d db.volume_type_get_all(context, True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fo3E%3D","line":883,"updated":"2013-07-15 15:29:07.000000000","message":"Shouldn\u0027t we just add a volume_type_get_even_if_deleted kind of method to the db api? The try/except here seems unnecessary.","commit_id":"0df4ed5709fba648f48ee01480321e66dfd69f3e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d0829333dc6266b2c1f0f02ac2b72b29bf5891bc","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        if not volume_type_id:"},{"line_number":881,"context_line":"            return"},{"line_number":882,"context_line":"        try:"},{"line_number":883,"context_line":"            volume_type \u003d db.volume_type_get(context, volume_type_id)"},{"line_number":884,"context_line":"        except exception.VolumeTypeNotFound:"},{"line_number":885,"context_line":"            volume_type \u003d None"},{"line_number":886,"context_line":"            volume_types \u003d db.volume_type_get_all(context, True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fong%3D","line":883,"in_reply_to":"AAAAP3%2F%2Fo3E%3D","updated":"2013-07-15 15:39:13.000000000","message":"I like that idea, I\u0027ll take another round on this later.  Initially I preferred the route I took here just due to simplicity and assuming that deleting the type with volumes outstanding was in fact an *exceptional* case, but I do like the idea so I\u0027ll change it.","commit_id":"0df4ed5709fba648f48ee01480321e66dfd69f3e"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"6ed72c942c28ad011d237e4fac1440407734a0e4","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            volume_type \u003d db.volume_type_get(context, volume_type_id)"},{"line_number":884,"context_line":"        except exception.VolumeTypeNotFound:"},{"line_number":885,"context_line":"            volume_type \u003d None"},{"line_number":886,"context_line":"            volume_types \u003d db.volume_type_get_all(context, True)"},{"line_number":887,"context_line":"            for v_type in volume_types.values():"},{"line_number":888,"context_line":"                if v_type[\u0027id\u0027] \u003d\u003d volume_type_id:"},{"line_number":889,"context_line":"                    volume_type \u003d v_type"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fpq0%3D","line":886,"updated":"2013-07-15 09:56:34.000000000","message":"I think a comment here saying you\u0027re adding the options for a volume type that has been deleted wouldn\u0027t go amiss here. Unless you want to go with Huang\u0027s suggestion.","commit_id":"0df4ed5709fba648f48ee01480321e66dfd69f3e"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"2ab0c8c8dd7771bdb20e65e368bd22df5c325970","unresolved":false,"context_lines":[{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        # Volume type quotas."},{"line_number":919,"context_line":"        # NOTE(jdg): We also want to check deleted types here as well"},{"line_number":920,"context_line":"        # if we don\u0027t the _get_quotas resource len check on L# 239 will fail"},{"line_number":921,"context_line":"        volume_types \u003d db.volume_type_get_all(context.get_admin_context(),"},{"line_number":922,"context_line":"                                              True)"},{"line_number":923,"context_line":"        for volume_type in volume_types.values():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2FlLg%3D","line":920,"updated":"2013-07-16 09:53:57.000000000","message":"Please don\u0027t reference line numbers","commit_id":"4ee8e0f41dfdf9626a69b1d9252ccc692f654b5e"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a34103ca056456af30269a2aa642089f71a69bbe","unresolved":false,"context_lines":[{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        # Volume type quotas."},{"line_number":919,"context_line":"        # NOTE(jdg): We also want to check deleted types here as well"},{"line_number":920,"context_line":"        # if we don\u0027t the _get_quotas resource len check on L# 239 will fail"},{"line_number":921,"context_line":"        volume_types \u003d db.volume_type_get_all(context.get_admin_context(),"},{"line_number":922,"context_line":"                                              True)"},{"line_number":923,"context_line":"        for volume_type in volume_types.values():"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2Fi%2BU%3D","line":920,"in_reply_to":"AAAAP3%2F%2FlLg%3D","updated":"2013-07-16 18:45:23.000000000","message":"Done","commit_id":"4ee8e0f41dfdf9626a69b1d9252ccc692f654b5e"}]}