)]}'
{"cinder/volume/drivers/sheepdog.py":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"66de6a85f2ba39c0d7a4fc020a91ccf49bf339b4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if tmp_dir and not os.path.exists(tmp_dir):"},{"line_number":86,"context_line":"            os.makedirs(tmp_dir)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _resize(self, volume, **kwargs):"},{"line_number":89,"context_line":"        size \u003d kwargs.get(\u0027size\u0027, None)"},{"line_number":90,"context_line":"        if not size:"},{"line_number":91,"context_line":"            size \u003d int(volume[\u0027size\u0027]) * (1024 ** 3)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlEA%3D","line":88,"updated":"2013-07-16 10:42:24.000000000","message":"would it not be better (more \u0027Pythonic\u0027) to add size\u003dNone instead of **kwargs?","commit_id":"242a5d00d3a2fec5c374d5aa7792eece7282a269"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"66de6a85f2ba39c0d7a4fc020a91ccf49bf339b4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def _resize(self, volume, **kwargs):"},{"line_number":89,"context_line":"        size \u003d kwargs.get(\u0027size\u0027, None)"},{"line_number":90,"context_line":"        if not size:"},{"line_number":91,"context_line":"            size \u003d int(volume[\u0027size\u0027]) * (1024 ** 3)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self._try_execute(\u0027collie\u0027, \u0027vdi\u0027, \u0027resize\u0027,"},{"line_number":94,"context_line":"                          volume[\u0027name\u0027], size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAP3%2F%2FlD4%3D","line":91,"updated":"2013-07-16 10:42:24.000000000","message":"cinder has standard unit for MB, GB etc in cinder.units so please use these (as has already been done on line 190 ;))","commit_id":"242a5d00d3a2fec5c374d5aa7792eece7282a269"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"92f349e9541f024923e97a3d3b9667dad807117e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        LOG.debug(_(\"Extend volume from %(old_size) to %(new_size)\"),"},{"line_number":198,"context_line":"                  {\u0027old_size\u0027: old_size, \u0027new_size\u0027: new_size})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2FlAo%3D","line":198,"updated":"2013-07-16 10:55:32.000000000","message":"old_size here is in bytes, whereas new_size is in GB. Perhaps worth converting for sake of clarity?","commit_id":"c9b408f32e3c39936e4d0c3e81acb0f5e53284e5"},{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"6416dc562104f065f11480f8086fc26086f61de2","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        LOG.debug(_(\"Extend volume from %(old_size) to %(new_size)\"),"},{"line_number":198,"context_line":"                  {\u0027old_size\u0027: old_size, \u0027new_size\u0027: str(size)})"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAP3%2F%2Fk%2BA%3D","line":198,"updated":"2013-07-16 11:07:06.000000000","message":"Apologies, I realised my last comment was in error. old_size and new_size are actually both in bytes.","commit_id":"9367edd1bd8cba2c88261f910607360ebf2aca6c"}]}