)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Drop unused parameter in class ExtractSchedulerSpecTask."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this class and it\u0027s related modules have not found this"},{"line_number":10,"context_line":"unused db_api parameters.And i think function parameters in"},{"line_number":11,"context_line":"_populate_request_spec are got from taskflow."},{"line_number":12,"context_line":"So i think we can delete it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_c6ca68a1","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":44},"updated":"2016-09-29 08:13:23.000000000","message":"nit: I have","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Drop unused parameter in class ExtractSchedulerSpecTask."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this class and it\u0027s related modules have not found this"},{"line_number":10,"context_line":"unused db_api parameters.And i think function parameters in"},{"line_number":11,"context_line":"_populate_request_spec are got from taskflow."},{"line_number":12,"context_line":"So i think we can delete it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_a6ee3c20","line":10,"range":{"start_line":10,"start_character":29,"end_line":10,"end_character":30},"updated":"2016-09-29 08:13:23.000000000","message":"nit: I","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Drop unused parameter in class ExtractSchedulerSpecTask."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this class and it\u0027s related modules have not found this"},{"line_number":10,"context_line":"unused db_api parameters.And i think function parameters in"},{"line_number":11,"context_line":"_populate_request_spec are got from taskflow."},{"line_number":12,"context_line":"So i think we can delete it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_e6f844e8","line":10,"range":{"start_line":10,"start_character":23,"end_line":10,"end_character":26},"updated":"2016-09-29 08:13:23.000000000","message":"nit: Missing space","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this class and it\u0027s related modules have not found this"},{"line_number":10,"context_line":"unused db_api parameters.And i think function parameters in"},{"line_number":11,"context_line":"_populate_request_spec are got from taskflow."},{"line_number":12,"context_line":"So i think we can delete it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0a6d6f471e4fe2b98f0646b12a2cf84ed392f750"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a98d1f4_06c5308d","line":12,"range":{"start_line":12,"start_character":3,"end_line":12,"end_character":4},"updated":"2016-09-29 08:13:23.000000000","message":"nit: I","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"}],"cinder/scheduler/flows/create_volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    \"\"\""},{"line_number":87,"context_line":"    FAILURE_TOPIC \u003d \"scheduler.create_volume\""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def __init__(self, db_api, driver_api, **kwargs):"},{"line_number":90,"context_line":"        super(ScheduleCreateVolumeTask, self).__init__(addons\u003d[ACTION],"},{"line_number":91,"context_line":"                                                       **kwargs)"},{"line_number":92,"context_line":"        self.db_api \u003d db_api"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_e6aa04d4","line":89,"range":{"start_line":89,"start_character":23,"end_line":89,"end_character":29},"updated":"2016-09-29 08:13:23.000000000","message":"-1: This should also be removed","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def __init__(self, db_api, driver_api, **kwargs):"},{"line_number":90,"context_line":"        super(ScheduleCreateVolumeTask, self).__init__(addons\u003d[ACTION],"},{"line_number":91,"context_line":"                                                       **kwargs)"},{"line_number":92,"context_line":"        self.db_api \u003d db_api"},{"line_number":93,"context_line":"        self.driver_api \u003d driver_api"},{"line_number":94,"context_line":"        self.message_api \u003d message_api.API()"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_06b0d042","line":92,"updated":"2016-09-29 08:13:23.000000000","message":"-1: This should also be removed","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                    common.error_out(volume, reason\u003de)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def get_flow(context, db_api, driver_api, request_spec\u003dNone,"},{"line_number":146,"context_line":"             filter_properties\u003dNone,"},{"line_number":147,"context_line":"             volume\u003dNone, snapshot_id\u003dNone, image_id\u003dNone):"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_2666aced","line":145,"range":{"start_line":145,"start_character":21,"end_line":145,"end_character":30},"updated":"2016-09-29 08:13:23.000000000","message":"-1: This should also be removed as well as all callers to this method so they don\u0027t pass it.","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ec5ac347943268534a91991d168239770f67e8a2","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    # This will activate the desired scheduler driver (and handle any"},{"line_number":175,"context_line":"    # driver related failures appropriately)."},{"line_number":176,"context_line":"    scheduler_flow.add(ScheduleCreateVolumeTask(db_api, driver_api))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    # Now load (but do not run) the flow using the provided initial data."},{"line_number":179,"context_line":"    return taskflow.engines.load(scheduler_flow, store\u003dcreate_what)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a98d1f4_c657c800","line":176,"range":{"start_line":176,"start_character":48,"end_line":176,"end_character":54},"updated":"2016-09-29 08:13:23.000000000","message":"-1: This should also be removed","commit_id":"45daeb78250ad2ae47dbf750caaefb3015a24111"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b983cfb3aa426e9d3f3e08a7f1734e05b2700cdb","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(ExtractSchedulerSpecTask, self).__init__(addons\u003d[ACTION],"},{"line_number":43,"context_line":"                                                       **kwargs)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _populate_request_spec(self, volume, snapshot_id, image_id):"},{"line_number":46,"context_line":"        # Create the full request spec using the volume object."},{"line_number":47,"context_line":"        #"},{"line_number":48,"context_line":"        # NOTE(dulek): At this point, a volume can be deleted before it gets"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a98d1f4_a4ec3490","line":45,"updated":"2016-09-30 08:26:54.000000000","message":"nit: This change is unnecessary for this patch, it\u0027s a good policy not mixing functional changes with aesthetic ones.  I\u0027m sometimes guilty of this myself.  ;-)","commit_id":"7abd20f06135d9d767215577ee41b8ad55e8b735"}]}