)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ae446ceb3cb438e81b4b5c57763a49f84218bb28","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Return bad request response if shapshot id has a bad format."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ifa216e73d62b772de7aa0ae43d8472c4284fc92b"},{"line_number":12,"context_line":"Closes-Bug: #1626474"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a8bc5a2_6ed18dfb","line":11,"updated":"2016-09-22 11:12:33.000000000","message":"Please, add APIImpact flag to the commit message","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"}],"cinder/api/v1/volumes.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"886cb220bceceffb2acea259e1723a9c489ac431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a8bc5a2_ee9afdc4","updated":"2016-09-22 11:04:37.000000000","message":"Please do not modify v1 API. It\u0027s deprecated and we\u0027re not actively developing it.","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"acb3f9704c5170612a04ca95e3e9252c2c4d6ac5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a8bc5a2_ae771501","in_reply_to":"5a8bc5a2_6eca6d51","updated":"2016-09-22 11:14:41.000000000","message":"Hm, yeah, Ivan is right here. Sorry, I haven\u0027t thought this through enough.","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ae446ceb3cb438e81b4b5c57763a49f84218bb28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5a8bc5a2_6eca6d51","in_reply_to":"5a8bc5a2_ee9afdc4","updated":"2016-09-22 11:12:33.000000000","message":"Michal, you\u0027re right about modifications to API v2 and v2. We\u0027re allowed to fix errors in deprecated APIs if we don\u0027t change API itself\n\nBut bugfixes are still allowed and we have to add APIImpact flag to the commit message for such fixes.","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"886cb220bceceffb2acea259e1723a9c489ac431","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"The volumes api.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"from oslo_utils import uuidutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_8eac19ef","side":"PARENT","line":18,"updated":"2016-09-22 11:04:37.000000000","message":"This change is not required.","commit_id":"c240eafa0af7dfb0a534c9c03243d91801a06ebd"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"886cb220bceceffb2acea259e1723a9c489ac431","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        snapshot_id \u003d volume.get(\u0027snapshot_id\u0027)"},{"line_number":209,"context_line":"        if snapshot_id is not None:"},{"line_number":210,"context_line":"            if not uuidutils.is_uuid_like(snapshot_id):"},{"line_number":211,"context_line":"                msg \u003d _(\"Invalid type of snapshot id provided.\")"},{"line_number":212,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":213,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":214,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d self.volume_api.get_snapshot(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_8e9339a3","line":211,"range":{"start_line":211,"start_character":24,"end_line":211,"end_character":63},"updated":"2016-09-22 11:04:37.000000000","message":"I would rephrase it to something like \"Snapshot ID must be in UUID form\".","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"886cb220bceceffb2acea259e1723a9c489ac431","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        snapshot_id \u003d volume.get(\u0027snapshot_id\u0027)"},{"line_number":168,"context_line":"        if snapshot_id is not None:"},{"line_number":169,"context_line":"            if not uuidutils.is_uuid_like(snapshot_id):"},{"line_number":170,"context_line":"                msg \u003d _(\"Invalid type of snapshot id provided.\")"},{"line_number":171,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":172,"context_line":"            # Not found exception will be handled at the wsgi level"},{"line_number":173,"context_line":"            kwargs[\u0027snapshot\u0027] \u003d self.volume_api.get_snapshot(context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_eee83d19","line":170,"range":{"start_line":170,"start_character":24,"end_line":170,"end_character":63},"updated":"2016-09-22 11:04:37.000000000","message":"Same here.","commit_id":"4727814d987f062eedcb2d7974f231303079bfb4"}]}