)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"015c1a3276deb4e428aae2c6376300462021352f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Channel types change to LAN \u0026 Fibre in GS Series, add support for it."},{"line_number":10,"context_line":"Change folder name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also fix some bugs:"},{"line_number":13,"context_line":"  - FC should return connection info no matter fc lookup service."},{"line_number":14,"context_line":"  - FC should return empty data instead of None in terminate connection call."},{"line_number":15,"context_line":"  - Check mapping before iSCSI delete the host iqn."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id7373c586c8e98ad4b42aa6ad0e679d9101ed3e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_c156bdd1","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":51},"updated":"2016-09-23 07:47:03.000000000","message":"I\u0027d like you to split the bug changes from this patch and report a bug on launchpad before you upload the bug one","commit_id":"b1f6435b0dcecf1867e235b10ee659a542e51acd"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"ee8392c68edcddfd8d7423d728c1626d78b5284a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Channel types change to LAN \u0026 Fibre in GS Series, add support for it."},{"line_number":10,"context_line":"Change folder name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also fix some bugs:"},{"line_number":13,"context_line":"  - FC should return connection info no matter fc lookup service."},{"line_number":14,"context_line":"  - FC should return empty data instead of None in terminate connection call."},{"line_number":15,"context_line":"  - Check mapping before iSCSI delete the host iqn."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id7373c586c8e98ad4b42aa6ad0e679d9101ed3e6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a8bc5a2_7414c943","line":15,"range":{"start_line":12,"start_character":0,"end_line":15,"end_character":51},"in_reply_to":"5a8bc5a2_c156bdd1","updated":"2016-09-23 08:11:04.000000000","message":"It\u0027s my fault, the word \"bug\" may not that suitable for here.\n\nThe changes are to avoid warning messages from RemoveFCZone in cinder.zonemanager.utils.\n\"Driver didn\u0027t return connection info from terminate_connection call.\"\n\nShould I still need to split them? Thanks.","commit_id":"b1f6435b0dcecf1867e235b10ee659a542e51acd"}],"cinder/volume/drivers/infortrend/raidcmd_cli/common_cli.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f26ee3f3576f369eb9e910ec1225dde3dbb9470a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                    self.map_dict[slot_key][ch].remove(int(lun))"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"    def _check_initiator_has_lun_map(self, initiator_info, map_info):"},{"line_number":334,"context_line":"        if isinstance(initiator_info, list):"},{"line_number":335,"context_line":"            for initiator_wwn in initiator_info:"},{"line_number":336,"context_line":"                for entry in map_info:"},{"line_number":337,"context_line":"                    if initiator_wwn.lower() \u003d\u003d entry[\u0027Host-ID\u0027].lower():"},{"line_number":338,"context_line":"                        return True"},{"line_number":339,"context_line":"        else:"},{"line_number":340,"context_line":"            for entry in map_info:"},{"line_number":341,"context_line":"                if initiator_info.lower() \u003d\u003d entry[\u0027Host-ID\u0027].lower():"},{"line_number":342,"context_line":"                    return True"},{"line_number":343,"context_line":"        return False"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    @log_func"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_dd48c7b5","line":342,"range":{"start_line":334,"start_character":0,"end_line":342,"end_character":31},"updated":"2016-09-27 10:33:20.000000000","message":"nit: This could be simplified:\n\n if not isinstance(initiator_info, list):\n     initiator_info \u003d initiator_info,\n\n for initiator_wwn in initiator_info:\n     for entry in map_info:\n         if initiator_wwn.lower() \u003d\u003d entry[\u0027Host-ID\u0027].lower():\n             return True","commit_id":"fc18a104a96b08c87549e124ecb53008da34088a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f26ee3f3576f369eb9e910ec1225dde3dbb9470a","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            self, channel_info, controller\u003d\u0027slot_a\u0027, multipath\u003dFalse):"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if self.protocol \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":350,"context_line":"            check_channel_type \u003d [\u0027NETWORK\u0027, \u0027LAN\u0027]"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            check_channel_type \u003d [\u0027FIBRE\u0027, \u0027Fibre\u0027]"},{"line_number":353,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_1dbcefb9","line":350,"updated":"2016-09-27 10:33:20.000000000","message":"nit: It\u0027s better to use a tuple (\u0027NETWORK\u0027, \u0027LAN\u0027)","commit_id":"fc18a104a96b08c87549e124ecb53008da34088a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f26ee3f3576f369eb9e910ec1225dde3dbb9470a","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        if self.protocol \u003d\u003d \u0027iSCSI\u0027:"},{"line_number":350,"context_line":"            check_channel_type \u003d [\u0027NETWORK\u0027, \u0027LAN\u0027]"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            check_channel_type \u003d [\u0027FIBRE\u0027, \u0027Fibre\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        for entry in channel_info:"},{"line_number":355,"context_line":"            if entry[\u0027Type\u0027] in check_channel_type:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_5db2f7e5","line":352,"updated":"2016-09-27 10:33:20.000000000","message":"ditto","commit_id":"fc18a104a96b08c87549e124ecb53008da34088a"}]}