)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"1538bdf5ac936cd58fcafe38a08094e801d89b24","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes should be made to the following groups:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"a) service_available_group - We don\u0027t need this group in plugin code because"},{"line_number":15,"context_line":"it is already being registered in tempest code and service availability is"},{"line_number":16,"context_line":"being checked for in the /tempest/api/volume/base.py and the test cases in"},{"line_number":17,"context_line":"plugin code inherits this base.py"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"b) cinder group - Instead of registering a new cinder group for plugin tests"},{"line_number":20,"context_line":"we can add plugin specific configuration options in the existing volume group"},{"line_number":21,"context_line":"as the same conf object from tempest is being passed on to the plugin"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ie0ca52ec389c581ca47db3e9bbb0793a2bb47fdf"},{"line_number":24,"context_line":"Closes-Bug: #1626575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a8bc5a2_d776b105","line":21,"range":{"start_line":14,"start_character":0,"end_line":21,"end_character":69},"updated":"2016-09-28 06:17:56.000000000","message":"several lines exceed the line\u0027s max length","commit_id":"cc8a1b34c545d3bf0888f17eafd63d51b90b9056"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"b9f3002f22f0f22cc6fafcdd1588004012cf26ca","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Changes should be made to the following groups:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"a) service_available_group - We don\u0027t need this group in plugin code because"},{"line_number":15,"context_line":"it is already being registered in tempest code and service availability is"},{"line_number":16,"context_line":"being checked for in the /tempest/api/volume/base.py and the test cases in"},{"line_number":17,"context_line":"plugin code inherits this base.py"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"b) cinder group - Instead of registering a new cinder group for plugin tests"},{"line_number":20,"context_line":"we can add plugin specific configuration options in the existing volume group"},{"line_number":21,"context_line":"as the same conf object from tempest is being passed on to the plugin"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ie0ca52ec389c581ca47db3e9bbb0793a2bb47fdf"},{"line_number":24,"context_line":"Closes-Bug: #1626575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a8bc5a2_0a738cb5","line":21,"range":{"start_line":14,"start_character":0,"end_line":21,"end_character":69},"in_reply_to":"5a8bc5a2_d776b105","updated":"2016-09-28 06:27:31.000000000","message":"Done","commit_id":"cc8a1b34c545d3bf0888f17eafd63d51b90b9056"}],"cinder/tests/tempest/api/volume/test_consistencygroups.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d5878bb89c6e3910c9c821473dc199008ab127f9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(ConsistencyGroupsV2Test, cls).skip_checks()"},{"line_number":43,"context_line":"        if not CONF.volume.consistency_group:"},{"line_number":44,"context_line":"            raise cls.skipException(\"Cinder consistency group \""},{"line_number":45,"context_line":"                                    \"feature disabled\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_dc1392b6","line":43,"updated":"2016-09-26 17:59:55.000000000","message":"If this were going to be re-done to use the [volume] section from tempest, and require config changes, this should be a check against volume_feature_enabled instead of a separate option.","commit_id":"9a91956a284f6d0008426576d3955b7fff4eb09e"},{"author":{"_account_id":22259,"name":"Nishant Kumar","email":"nishant.e.kumar@att.com","username":"nishant.e.kumar"},"change_message_id":"3f5fcd7a90076e6aa68652a3af5951a8778d28e7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @classmethod"},{"line_number":41,"context_line":"    def skip_checks(cls):"},{"line_number":42,"context_line":"        super(ConsistencyGroupsV2Test, cls).skip_checks()"},{"line_number":43,"context_line":"        if not CONF.volume.consistency_group:"},{"line_number":44,"context_line":"            raise cls.skipException(\"Cinder consistency group \""},{"line_number":45,"context_line":"                                    \"feature disabled\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a8bc5a2_c5de52dc","line":43,"in_reply_to":"5a8bc5a2_dc1392b6","updated":"2016-09-26 18:45:02.000000000","message":"I will fix this in my next patch","commit_id":"9a91956a284f6d0008426576d3955b7fff4eb09e"}]}