)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e659150457d9f54fa6080ec6000086c59dcd4204","unresolved":false,"context_lines":[{"line_number":2871,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027)"},{"line_number":2872,"context_line":"    def setUp(self, mock_sleep):"},{"line_number":2873,"context_line":"        super(StorwizeSVCCommonDriverTestCase, self).setUp()"},{"line_number":2874,"context_line":"        self.USESIM \u003d True"},{"line_number":2875,"context_line":"        if self.USESIM:"},{"line_number":2876,"context_line":"            self._def_flags \u003d {\u0027san_ip\u0027: \u0027hostname\u0027,"},{"line_number":2877,"context_line":"                               \u0027storwize_san_secondary_ip\u0027: \u0027secondaryname\u0027,"},{"line_number":2878,"context_line":"                               \u0027san_login\u0027: \u0027user\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_7898a178","line":2875,"range":{"start_line":2874,"start_character":0,"end_line":2875,"end_character":23},"updated":"2016-09-27 10:45:25.000000000","message":"Unrelated to this patch, but this is weird.","commit_id":"4ab7e7c87c120178bacaed53fb392e6861b506c8"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"fef0602eaf7b967aa2f3ac06460c8b51b7bd8ce8","unresolved":false,"context_lines":[{"line_number":2871,"context_line":"    @mock.patch.object(time, \u0027sleep\u0027)"},{"line_number":2872,"context_line":"    def setUp(self, mock_sleep):"},{"line_number":2873,"context_line":"        super(StorwizeSVCCommonDriverTestCase, self).setUp()"},{"line_number":2874,"context_line":"        self.USESIM \u003d True"},{"line_number":2875,"context_line":"        if self.USESIM:"},{"line_number":2876,"context_line":"            self._def_flags \u003d {\u0027san_ip\u0027: \u0027hostname\u0027,"},{"line_number":2877,"context_line":"                               \u0027storwize_san_secondary_ip\u0027: \u0027secondaryname\u0027,"},{"line_number":2878,"context_line":"                               \u0027san_login\u0027: \u0027user\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_dba24f9a","line":2875,"range":{"start_line":2874,"start_character":0,"end_line":2875,"end_character":23},"in_reply_to":"5a8bc5a2_7898a178","updated":"2016-09-28 10:53:27.000000000","message":"I fully agree with you. It\u0027s weird and after searching through cinder project, USESIM attr uses only in this file and it\u0027s always True. So i\u0027ll also clean up this file in next patch not to change the sense of this one","commit_id":"4ab7e7c87c120178bacaed53fb392e6861b506c8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e659150457d9f54fa6080ec6000086c59dcd4204","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"                configuration\u003dconfig)"},{"line_number":2890,"context_line":"            self._driver \u003d storwize_svc_iscsi.StorwizeSVCISCSIDriver("},{"line_number":2891,"context_line":"                configuration\u003dconfig)"},{"line_number":2892,"context_line":"            self._driver.DEFAULT_GR_SLEEP \u003d 0"},{"line_number":2893,"context_line":"            wwpns \u003d ["},{"line_number":2894,"context_line":"                six.text_type(random.randint(0, 9999999999999999)).zfill(16),"},{"line_number":2895,"context_line":"                six.text_type(random.randint(0, 9999999999999999)).zfill(16)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_985c8d4c","line":2892,"updated":"2016-09-27 10:45:25.000000000","message":"-1: I think we should be mocking the class instead, similar to what we were doing before, but mocking the right class and doing the cleanup.  This can be achieved in the same place as the previous mock:\n\n self.mock_object(storwize_svc_iscsi.StorwizeSVCISCSIDriver,\n                  \u0027DEFAULT_GR_SLEEP\u0027, 0)","commit_id":"4ab7e7c87c120178bacaed53fb392e6861b506c8"},{"author":{"_account_id":23602,"name":"Michael Dovgal","email":"dovgalmichael@gmail.com","username":"mdovgal"},"change_message_id":"fef0602eaf7b967aa2f3ac06460c8b51b7bd8ce8","unresolved":false,"context_lines":[{"line_number":2889,"context_line":"                configuration\u003dconfig)"},{"line_number":2890,"context_line":"            self._driver \u003d storwize_svc_iscsi.StorwizeSVCISCSIDriver("},{"line_number":2891,"context_line":"                configuration\u003dconfig)"},{"line_number":2892,"context_line":"            self._driver.DEFAULT_GR_SLEEP \u003d 0"},{"line_number":2893,"context_line":"            wwpns \u003d ["},{"line_number":2894,"context_line":"                six.text_type(random.randint(0, 9999999999999999)).zfill(16),"},{"line_number":2895,"context_line":"                six.text_type(random.randint(0, 9999999999999999)).zfill(16)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_d66786e8","line":2892,"in_reply_to":"5a8bc5a2_985c8d4c","updated":"2016-09-28 10:53:27.000000000","message":"Yes, it\u0027s seems it\u0027s really better decision for this case","commit_id":"4ab7e7c87c120178bacaed53fb392e6861b506c8"}]}