)]}'
{"cinder/tests/test_storwize_svc.py":[{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"43d75a1fc93ebd8765c0cf524949601a0e003837","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            if (v[\u0027lun\u0027] \u003d\u003d mapping_info[\u0027lun\u0027]) and (\u0027force\u0027 not in kwargs):"},{"line_number":890,"context_line":"                return self._errors[\u0027CMMVC6071E\u0027]"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        else:"},{"line_number":893,"context_line":"            self._mappings_list[mapping_info[\u0027id\u0027]] \u003d mapping_info"},{"line_number":894,"context_line":"            return (\u0027Virtual Disk to Host map, id [%s], successfully created\u0027"},{"line_number":895,"context_line":"                    % (mapping_info[\u0027id\u0027]), \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F9W0%3D","line":892,"updated":"2013-07-18 14:17:28.000000000","message":"Is this else really necessary? Looks like it\u0027s an overhang from when there was an if statement instead of a for statement. As far as I can see the code flow will be the same with or without the else.","commit_id":"74830cddecfb5354ff8237a463bb1c93ca09d9ff"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"c7402d9c67d8835b3fe962a0cd3f8d802cbef469","unresolved":false,"context_lines":[{"line_number":889,"context_line":"            if (v[\u0027lun\u0027] \u003d\u003d mapping_info[\u0027lun\u0027]) and (\u0027force\u0027 not in kwargs):"},{"line_number":890,"context_line":"                return self._errors[\u0027CMMVC6071E\u0027]"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"        else:"},{"line_number":893,"context_line":"            self._mappings_list[mapping_info[\u0027id\u0027]] \u003d mapping_info"},{"line_number":894,"context_line":"            return (\u0027Virtual Disk to Host map, id [%s], successfully created\u0027"},{"line_number":895,"context_line":"                    % (mapping_info[\u0027id\u0027]), \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F9O4%3D","line":892,"in_reply_to":"AAAAQn%2F%2F9W0%3D","updated":"2013-07-18 14:43:05.000000000","message":"good catch, thanks!","commit_id":"74830cddecfb5354ff8237a463bb1c93ca09d9ff"}],"cinder/volume/drivers/storwize_svc.py":[{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"14a38cd141d5ec931b765a0d89a69581dd4d6f17","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"                                 \u0027mapping %(src)s -\u003e %(tgt)s\u0027) %"},{"line_number":1241,"context_line":"                               {\u0027name\u0027: name, \u0027src\u0027: source, \u0027tgt\u0027: target})"},{"line_number":1242,"context_line":"                        self._driver_assert(target \u003d\u003d name, msg)"},{"line_number":1243,"context_line":"                        if status in [\u0027copying\u0027, \u0027prepared\u0027]:"},{"line_number":1244,"context_line":"                            self._run_ssh(\u0027svctask stopfcmap %s\u0027 % map_id)"},{"line_number":1245,"context_line":"                        elif status \u003d\u003d \u0027stopping\u0027 or status \u003d\u003d \u0027preparing\u0027:"},{"line_number":1246,"context_line":"                            wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F990%3D","line":1243,"updated":"2013-07-18 09:59:41.000000000","message":"why not follow the format used here?","commit_id":"ab38a85361a40ce91acea0c231f089d6c608b911"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"93923e6c4351a630d3c354ae28d1e28f152a9eac","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"                                 \u0027mapping %(src)s -\u003e %(tgt)s\u0027) %"},{"line_number":1241,"context_line":"                               {\u0027name\u0027: name, \u0027src\u0027: source, \u0027tgt\u0027: target})"},{"line_number":1242,"context_line":"                        self._driver_assert(target \u003d\u003d name, msg)"},{"line_number":1243,"context_line":"                        if status in [\u0027copying\u0027, \u0027prepared\u0027]:"},{"line_number":1244,"context_line":"                            self._run_ssh(\u0027svctask stopfcmap %s\u0027 % map_id)"},{"line_number":1245,"context_line":"                        elif status \u003d\u003d \u0027stopping\u0027 or status \u003d\u003d \u0027preparing\u0027:"},{"line_number":1246,"context_line":"                            wait_for_copy \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F978%3D","line":1243,"in_reply_to":"AAAAQn%2F%2F990%3D","updated":"2013-07-18 10:13:03.000000000","message":"Good call. Done.","commit_id":"ab38a85361a40ce91acea0c231f089d6c608b911"}]}