)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e722f86d31fc00eecb161ddea0dbfd5102915fe1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Cinder migrate_volume_completion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before accessing the attachment list, check if the variable is not None. This"},{"line_number":10,"context_line":"was causing the function to throw a NoneType error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a95cdbc_9600de35","line":10,"range":{"start_line":9,"start_character":71,"end_line":10,"end_character":51},"updated":"2016-10-10 12:43:45.000000000","message":"comment message\u0027s length exceeded~","commit_id":"686c10d412ba1f05e0ae80eac980ef3df6bf298e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"8e6cd569e835a3515b3c19f00e9bad61b84d4916","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Cinder migrate_volume_completion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before accessing the attachment list, check if the variable is not None. This"},{"line_number":10,"context_line":"was causing the function to throw a NoneType error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa6399be_5efa9343","line":10,"range":{"start_line":9,"start_character":71,"end_line":10,"end_character":51},"in_reply_to":"1a95cdbc_9600de35","updated":"2016-10-11 20:16:27.000000000","message":"Done","commit_id":"686c10d412ba1f05e0ae80eac980ef3df6bf298e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"51bf2709e5906314f3cb125212bd78e55c9276e1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix Cinder migrate_volume_completion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Before accessing the attachment list, check if the variable is not"},{"line_number":10,"context_line":"None. This was causing the function to throw a NoneType error."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TrivialFix"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa6399be_ad2a757c","line":10,"range":{"start_line":9,"start_character":38,"end_line":10,"end_character":5},"updated":"2016-10-12 17:59:34.000000000","message":"That explicit check is now removed.","commit_id":"89b5991c6d15ac4f40a9b03d16d01f4236a6da2d"}],"cinder/volume/manager.py":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"8e9354f81dbed158259bd76754afbe366b002852","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        else:"},{"line_number":1851,"context_line":"            attachments \u003d None"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        if attachments:"},{"line_number":1854,"context_line":"            try:"},{"line_number":1855,"context_line":"                for attachment in attachments:"},{"line_number":1856,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_52d66b4f","line":1853,"updated":"2016-10-10 09:29:12.000000000","message":"We can change this to:\n\nif orig_volume_status \u003d\u003d \u0027in-use\u0027:\n\nfor consistency. See line 1877.","commit_id":"5bc53c32f92c29db115fec9f7d82824844592abc"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"71ce810a2d2f7f952af40932382bfaf227ea1e00","unresolved":false,"context_lines":[{"line_number":1850,"context_line":"        else:"},{"line_number":1851,"context_line":"            attachments \u003d None"},{"line_number":1852,"context_line":""},{"line_number":1853,"context_line":"        if attachments:"},{"line_number":1854,"context_line":"            try:"},{"line_number":1855,"context_line":"                for attachment in attachments:"},{"line_number":1856,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_4d5c097d","line":1853,"in_reply_to":"1a95cdbc_52d66b4f","updated":"2016-10-10 11:49:21.000000000","message":"Done","commit_id":"5bc53c32f92c29db115fec9f7d82824844592abc"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"e722f86d31fc00eecb161ddea0dbfd5102915fe1","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment[\u0027id\u0027])"},{"line_number":1853,"context_line":"            except Exception as ex:"},{"line_number":1854,"context_line":"                LOG.error(_LE(\"Detach migration source volume failed: \""},{"line_number":1855,"context_line":"                              \"%(err)s\"), {\u0027err\u0027: ex}, resource\u003dvolume)"},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            attachments \u003d None"},{"line_number":1858,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a95cdbc_610b8e24","line":1855,"range":{"start_line":1855,"start_character":49,"end_line":1855,"end_character":52},"updated":"2016-10-10 12:43:45.000000000","message":"please use six.text_type to wrap the error messages","commit_id":"686c10d412ba1f05e0ae80eac980ef3df6bf298e"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"8e6cd569e835a3515b3c19f00e9bad61b84d4916","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment[\u0027id\u0027])"},{"line_number":1853,"context_line":"            except Exception as ex:"},{"line_number":1854,"context_line":"                LOG.error(_LE(\"Detach migration source volume failed: \""},{"line_number":1855,"context_line":"                              \"%(err)s\"), {\u0027err\u0027: ex}, resource\u003dvolume)"},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            attachments \u003d None"},{"line_number":1858,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_9e9a6b13","line":1855,"range":{"start_line":1855,"start_character":49,"end_line":1855,"end_character":52},"in_reply_to":"1a95cdbc_610b8e24","updated":"2016-10-11 20:16:27.000000000","message":"Done","commit_id":"686c10d412ba1f05e0ae80eac980ef3df6bf298e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"b6274ffa8255f40390ded9d8daa61d76c102a8fe","unresolved":false,"context_lines":[{"line_number":1852,"context_line":"                    self.detach_volume(ctxt, volume.id, attachment[\u0027id\u0027])"},{"line_number":1853,"context_line":"            except Exception as ex:"},{"line_number":1854,"context_line":"                LOG.error(_LE(\"Detach migration source volume failed: \""},{"line_number":1855,"context_line":"                              \"%(err)s\"), {\u0027err\u0027: ex}, resource\u003dvolume)"},{"line_number":1856,"context_line":"        else:"},{"line_number":1857,"context_line":"            attachments \u003d None"},{"line_number":1858,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_b24e5494","line":1855,"range":{"start_line":1855,"start_character":49,"end_line":1855,"end_character":52},"in_reply_to":"1a95cdbc_610b8e24","updated":"2016-10-12 17:59:43.000000000","message":"Looks like it is not needed.\n\nSee the second example (new style) here:\nhttp://docs.openstack.org/developer/oslo.log/migration.html#no-more-implicit-conversion-to-unicode-str","commit_id":"686c10d412ba1f05e0ae80eac980ef3df6bf298e"}]}