)]}'
{"cinder/tests/unit/volume/drivers/emc/test_emc_vmax.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7307098dac83221e4758fd9afcb998e93c3facbd","unresolved":false,"context_lines":[{"line_number":8155,"context_line":"                conn, maskingViewDict, extraSpecs)"},{"line_number":8156,"context_line":"            (masking._check_if_rollback_action_for_masking_required."},{"line_number":8157,"context_line":"             assert_not_called())"},{"line_number":8158,"context_line":"            self.assertEqual(deviceDict, rollbackDict)"},{"line_number":8159,"context_line":"        # path 2: masking view creation or retrieval is unsuccessful"},{"line_number":8160,"context_line":"        with mock.patch.object(masking, \"_get_port_group_name_from_mv\","},{"line_number":8161,"context_line":"                               return_value\u003d(None, \"error_message\")):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_8c66624f","line":8158,"range":{"start_line":8158,"start_character":29,"end_line":8158,"end_character":53},"updated":"2016-12-11 21:53:14.000000000","message":"Please swap these so the order is (expected_value, actual_value)","commit_id":"5a62ffd7adcc624b6b48b95aa9c3475399ec1c18"}],"cinder/volume/drivers/emc/emc_vmax_masking.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ac09961bbd71faaf478f8a47db542d821daab67b","unresolved":false,"context_lines":[{"line_number":2721,"context_line":"            except Exception:"},{"line_number":2722,"context_line":"                errorMessage \u003d (_("},{"line_number":2723,"context_line":"                    \"Cannot get port group name.\"))"},{"line_number":2724,"context_line":"                LOG.error(errorMessage)"},{"line_number":2725,"context_line":"        return portGroupName, errorMessage"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_93451819","line":2724,"updated":"2016-11-14 14:25:18.000000000","message":"Is this errorMessage thrown in an exception by the caller?  If so, please add a note so it is clear why you use _ instead of _LE.","commit_id":"405421de0706e04edef01d5e8747e2deaf2da156"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"7307098dac83221e4758fd9afcb998e93c3facbd","unresolved":false,"context_lines":[{"line_number":2732,"context_line":"            self._get_port_group_from_masking_view("},{"line_number":2733,"context_line":"                conn, maskingViewName, storageSystemName))"},{"line_number":2734,"context_line":"        if portGroupInstanceName is None:"},{"line_number":2735,"context_line":"            errorMessage \u003d (_("},{"line_number":2736,"context_line":"                \"Cannot get port group from masking view: \""},{"line_number":2737,"context_line":"                \"%(maskingViewName)s. \")"},{"line_number":2738,"context_line":"                % {\u0027maskingViewName\u0027: maskingViewName})"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a71b18c_0c53326c","line":2735,"range":{"start_line":2735,"start_character":28,"end_line":2735,"end_character":29},"updated":"2016-12-11 21:53:14.000000000","message":"This and the next one are only used in the LOG.error call. Switch to use _LE() translation and move the args into the call to the logger to allow the logger to perform the string formatting when needed (change % to ,).","commit_id":"5a62ffd7adcc624b6b48b95aa9c3475399ec1c18"}],"cinder/volume/drivers/emc/emc_vmax_provision.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ac09961bbd71faaf478f8a47db542d821daab67b","unresolved":false,"context_lines":[{"line_number":309,"context_line":"                                                                 extraSpecs)"},{"line_number":310,"context_line":"                if rc !\u003d 0:"},{"line_number":311,"context_line":"                    exceptionMessage \u003d (_("},{"line_number":312,"context_line":"                        \"Error removing volume %(vol)s from %(sg). %(error)s.\")"},{"line_number":313,"context_line":"                        % {\u0027vol\u0027: volumeName,"},{"line_number":314,"context_line":"                           \u0027sg\u0027: storageGroupInstance[\u0027ElementName\u0027],"},{"line_number":315,"context_line":"                           \u0027error\u0027: errorDesc})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_73a40408","line":312,"updated":"2016-11-14 14:25:18.000000000","message":"This change is wrong.  \"s\" should not be removed.\n\n%(sg)s","commit_id":"405421de0706e04edef01d5e8747e2deaf2da156"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ac09961bbd71faaf478f8a47db542d821daab67b","unresolved":false,"context_lines":[{"line_number":361,"context_line":"                                                                 extraSpecs)"},{"line_number":362,"context_line":"                if rc !\u003d 0:"},{"line_number":363,"context_line":"                    exceptionMessage \u003d (_("},{"line_number":364,"context_line":"                        \"Error adding volume %(vol)s to %(sg). %(error)s.\")"},{"line_number":365,"context_line":"                        % {\u0027vol\u0027: volumeName,"},{"line_number":366,"context_line":"                           \u0027sg\u0027: storageGroupInstance[\u0027ElementName\u0027],"},{"line_number":367,"context_line":"                           \u0027error\u0027: errordesc})"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a629dbe_b3ae9ce5","line":364,"updated":"2016-11-14 14:25:18.000000000","message":"Same\n\n%(sg)s","commit_id":"405421de0706e04edef01d5e8747e2deaf2da156"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"908b105edc0b93a6943dabc16fd3a7cca0dec918","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                                                 extraSpecs)"},{"line_number":363,"context_line":"                if rc !\u003d 0:"},{"line_number":364,"context_line":"                    exceptionMessage \u003d (_("},{"line_number":365,"context_line":"                        \"Error adding volume %(vol)s to %(sg). %(error)s.\")"},{"line_number":366,"context_line":"                        % {\u0027vol\u0027: volumeName,"},{"line_number":367,"context_line":"                           \u0027sg\u0027: storageGroupInstance[\u0027ElementName\u0027],"},{"line_number":368,"context_line":"                           \u0027error\u0027: errordesc})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_f2b74f82","line":365,"updated":"2016-11-29 15:35:32.000000000","message":"This is a wrong change.  It should be %(sg)s as on the left.","commit_id":"d76041bb82a3e112cf4ac9d3c22edd2eeaff922c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"0858e37ba4ab60b23a83d1b1dfa56cdf0c1c1029","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                                                 extraSpecs)"},{"line_number":363,"context_line":"                if rc !\u003d 0:"},{"line_number":364,"context_line":"                    exceptionMessage \u003d (_("},{"line_number":365,"context_line":"                        \"Error adding volume %(vol)s to %(sg). %(error)s.\")"},{"line_number":366,"context_line":"                        % {\u0027vol\u0027: volumeName,"},{"line_number":367,"context_line":"                           \u0027sg\u0027: storageGroupInstance[\u0027ElementName\u0027],"},{"line_number":368,"context_line":"                           \u0027error\u0027: errordesc})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_f3d9ec84","line":365,"in_reply_to":"5a74a57a_f2b74f82","updated":"2016-11-30 09:38:50.000000000","message":"Sure.  We will fix this.  Thanks","commit_id":"d76041bb82a3e112cf4ac9d3c22edd2eeaff922c"}]}