)]}'
{"id":"openstack%2Fcinder~37997","triplet_id":"openstack%2Fcinder~master~Ib9577ac160596a6878d1729f6022885b6cfa90e2","project":"openstack/cinder","branch":"master","topic":"add_create_and_attach_to_sf_attributes","hashtags":[],"change_id":"Ib9577ac160596a6878d1729f6022885b6cfa90e2","subject":"Add create \u0026 attach times to SolidFire attributes.","status":"MERGED","created":"2013-07-19 23:09:19.000000000","updated":"2013-07-23 18:24:44.000000000","submitted":"2013-07-23 18:24:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"72eaf095c420eef37ce4176a140ddf3f74a51575","_number":37997,"virtual_id_number":37997,"owner":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":2,"date":"2013-07-23 18:24:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"recommended":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"all":[{"value":1,"date":"2013-07-22 18:49:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":2,"date":"2013-07-23 17:24:30.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":2,"date":"2013-07-23 06:41:25.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"all":[{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":1,"date":"2013-07-23 17:24:30.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"date":"2013-07-23 04:19:49.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-07-22 18:49:52.000000000","updated_by":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"reviewer":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"state":"REVIEWER"},{"updated":"2013-07-23 04:19:49.000000000","updated_by":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"reviewer":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"state":"REVIEWER"},{"updated":"2013-07-23 17:24:30.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2013-07-23 18:24:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"81a727f3269e8bff93d7e0c5c157d723ed5f8b7e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-20 00:06:45.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/97/37997/1/check/gate-cinder-pep8/5166 : SUCCESS in 2m 05s\n- http://docs-draft.openstack.org/97/37997/1/check/gate-cinder-docs/5060/doc/build/html/ : SUCCESS in 4m 13s\n- http://logs.openstack.org/97/37997/1/check/gate-cinder-python26/5060 : SUCCESS in 5m 47s\n- http://logs.openstack.org/97/37997/1/check/gate-cinder-python27/5091 : SUCCESS in 3m 29s\n- http://logs.openstack.org/97/37997/1/check/gate-cinder-pylint/1154 : FAILURE in 3m 32s (non-voting)\n- http://logs.openstack.org/97/37997/1/check/gate-tempest-devstack-vm-full/34002 : SUCCESS in 47m 13s\n- http://logs.openstack.org/97/37997/1/check/gate-tempest-devstack-vm-cells-full/1656 : FAILURE in 15m 32s (non-voting)\n- http://logs.openstack.org/97/37997/1/check/gate-tempest-devstack-vm-testr-full/507 : SUCCESS in 30m 08s (non-voting)\n- http://logs.openstack.org/97/37997/1/check/gate-tempest-devstack-vm-postgres-full/33692 : SUCCESS in 57m 16s\n- http://logs.openstack.org/97/37997/1/check/gate-tempest-devstack-vm-neutron/5784 : SUCCESS in 18m 43s (non-voting)\n- http://logs.openstack.org/97/37997/1/check/gate-grenade-devstack-vm/19722 : SUCCESS in 21m 20s\n","accounts_in_message":[],"_revision_number":1},{"id":"2a2ce950192578eaf8e1d5c0e2cbeea045d776c2","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2013-07-20 06:15:59.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nThanks for the first response on that one! Will make sure to test it next week.\n\nSee inline comments for concerns and questions.","accounts_in_message":[],"_revision_number":1},{"id":"76e4b6d42b9620d4c0ac7524ef660da0914be951","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-07-20 13:40:20.000000000","message":"Patch Set 1: (5 inline comments)\n\nmark this as WIP and clean a bit.","accounts_in_message":[],"_revision_number":1},{"id":"5b7489e8a22376ca3684c381c9177f4b24dd06fb","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-07-20 13:40:37.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"d169c6b767c6398c110119e7125f423ee0b4484a","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2013-07-22 15:06:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"829fff2220600ae14ebdd2f37e9bca283677df69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-22 17:40:04.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-pep8/5203 : SUCCESS in 3m 14s\n- http://docs-draft.openstack.org/97/37997/2/check/gate-cinder-docs/5097/doc/build/html/ : SUCCESS in 5m 24s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-python26/5097 : SUCCESS in 5m 52s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-python27/5128 : SUCCESS in 3m 33s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-pylint/1189 : SUCCESS in 3m 42s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-full/34422 : SUCCESS in 47m 52s\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-cells-full/1997 : FAILURE in 19m 51s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-testr-full/843 : SUCCESS in 29m 36s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-postgres-full/34112 : UNSTABLE in 47m 41s\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-neutron/6236 : FAILURE in 24m 06s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-grenade-devstack-vm/20109 : SUCCESS in 25m 24s\n","accounts_in_message":[],"_revision_number":2},{"id":"c7f274371ba958f00f056604b6d0b02a7cfba3aa","author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"date":"2013-07-22 18:49:52.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nLGTM, tested with Grizzly (backported)","accounts_in_message":[],"_revision_number":2},{"id":"82e4058aae83d94f02abeb89bfc0b7834cbd13fa","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2013-07-23 04:19:49.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"71c765afe57ef8e087da036505c98e852c13f12f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 05:10:52.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-pep8/5228 : SUCCESS in 2m 15s\n- http://docs-draft.openstack.org/97/37997/2/check/gate-cinder-docs/5122/doc/build/html/ : SUCCESS in 4m 05s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-python26/5122 : SUCCESS in 5m 35s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-python27/5153 : SUCCESS in 3m 17s\n- http://logs.openstack.org/97/37997/2/check/gate-cinder-pylint/1209 : SUCCESS in 3m 37s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-full/34650 : SUCCESS in 46m 15s\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-cells-full/2166 : FAILURE in 16m 40s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-testr-full/1011 : FAILURE in 27m 06s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-postgres-full/34340 : SUCCESS in 50m 56s\n- http://logs.openstack.org/97/37997/2/check/gate-tempest-devstack-vm-neutron/6489 : SUCCESS in 18m 02s (non-voting)\n- http://logs.openstack.org/97/37997/2/check/gate-grenade-devstack-vm/20322 : SUCCESS in 22m 44s\n","accounts_in_message":[],"_revision_number":2},{"id":"f409dfa9315fb1c2cdf3fb23d576f7b9fb16bc1d","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2013-07-23 06:41:25.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"d87a206c64b4a55de6a0e7773e03aad3da3f2d71","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2013-07-23 17:24:30.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"8d57cd5f9f66eb82181f3271eeb35624fd4f5fc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 17:24:32.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"002d7cb5db44921454d25a2c0d873173e21c0d72","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 18:24:44.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"759de63ec3e3ae94f8a14b1dbc4b4082c9865f00","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-07-23 18:24:44.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/97/37997/2/gate/gate-cinder-docs/5143/doc/build/html/ : SUCCESS in 4m 12s\n- http://logs.openstack.org/97/37997/2/gate/gate-cinder-pep8/5249 : SUCCESS in 3m 32s\n- http://logs.openstack.org/97/37997/2/gate/gate-cinder-python26/5143 : SUCCESS in 5m 22s\n- http://logs.openstack.org/97/37997/2/gate/gate-cinder-python27/5174 : SUCCESS in 3m 26s\n- http://logs.openstack.org/97/37997/2/gate/gate-tempest-devstack-vm-full/34819 : SUCCESS in 1h 00m 06s\n- http://logs.openstack.org/97/37997/2/gate/gate-tempest-devstack-vm-postgres-full/34509 : SUCCESS in 49m 13s\n- http://logs.openstack.org/97/37997/2/gate/gate-tempest-devstack-vm-neutron/6679 : SUCCESS in 21m 45s (non-voting)\n- http://logs.openstack.org/97/37997/2/gate/gate-grenade-devstack-vm/20474 : SUCCESS in 23m 35s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5d8a457c4e91a7cfe1ab5a09cdb2ca48ec6aa977","revisions":{"1f229bbec0ef851371c04e6597f116d89f31a446":{"kind":"REWORK","_number":1,"created":"2013-07-19 23:09:19.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/97/37997/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/97/37997/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/97/37997/1"}}},"commit":{"parents":[{"commit":"6e95e1ab3e737d1de356b4542d9f408e5bce2324","subject":"Merge \"Sync gettextutils from oslo\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/6e95e1ab3e737d1de356b4542d9f408e5bce2324"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2013-07-19 23:05:55.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2013-07-19 23:09:18.000000000","tz":-360},"subject":"Add create \u0026 attach times to SolidFire attributes.","message":"Add create \u0026 attach times to SolidFire attributes.\n\nThis change simply adds create_time and attach_time to\nthe SolidFire devices attributes.\n\nTimes are taken from the volume-ref object, attach_time\nis only set/present after an attach, and is also removed\nfrom the attributes list on a detach.\n\nThis also required that we actually set attach_time on the\nvolume in the db.  We have the column, but we weren\u0027t actually\nsetting it, so this change required that be fixed.\n\nIn the future we should also look at changing the attach_time\nfrom a string to a proper date-time object.\n\nChange-Id: Ib9577ac160596a6878d1729f6022885b6cfa90e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/1f229bbec0ef851371c04e6597f116d89f31a446"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/1f229bbec0ef851371c04e6597f116d89f31a446"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6e95e1ab3e737d1de356b4542d9f408e5bce2324","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"5d8a457c4e91a7cfe1ab5a09cdb2ca48ec6aa977":{"kind":"REWORK","_number":2,"created":"2013-07-22 15:06:32.000000000","uploader":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"ref":"refs/changes/97/37997/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/cinder","ref":"refs/changes/97/37997/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/cinder refs/changes/97/37997/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/cinder refs/changes/97/37997/2"}}},"commit":{"parents":[{"commit":"6e95e1ab3e737d1de356b4542d9f408e5bce2324","subject":"Merge \"Sync gettextutils from oslo\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/6e95e1ab3e737d1de356b4542d9f408e5bce2324"}]}],"author":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2013-07-19 23:05:55.000000000","tz":-360},"committer":{"name":"John Griffith","email":"john.griffith@solidfire.com","date":"2013-07-22 15:06:00.000000000","tz":-360},"subject":"Add create \u0026 attach times to SolidFire attributes.","message":"Add create \u0026 attach times to SolidFire attributes.\n\nThis change simply adds create_time and attach_time to\nthe SolidFire devices attributes.\n\nTimes are taken from the volume-ref object, attach_time\nis only set/present after an attach, and is also removed\nfrom the attributes list on a detach.\n\nThis also required that we actually set attach_time on the\nvolume in the db.  We have the column, but we weren\u0027t actually\nsetting it, so this change required that be fixed.\n\nIn the future we should also look at changing the attach_time\nfrom a string to a proper date-time object.\n\nChange-Id: Ib9577ac160596a6878d1729f6022885b6cfa90e2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/5d8a457c4e91a7cfe1ab5a09cdb2ca48ec6aa977"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/cinder/commit/5d8a457c4e91a7cfe1ab5a09cdb2ca48ec6aa977"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6e95e1ab3e737d1de356b4542d9f408e5bce2324","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}