)]}'
{"cinder/api/v1/volumes.py":[{"author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"change_message_id":"c7ffa323d532f7d0ee525f0e16998e0182d3e806","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        search_opts \u003d {}"},{"line_number":255,"context_line":"        search_opts.update(req.GET)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":258,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval(search_opts[\u0027metadata\u0027])"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F1Lg%3D","line":257,"updated":"2013-07-22 15:14:33.000000000","message":"ast.literal_eval() should be fine here. One thing though, you seem to be searching for a different key to that used in the original patchset i.e. in 34609 the key is \u0027metadata[...]\u0027. I don\u0027t know which is correct.","commit_id":"76fc407382315a97cc020e8592199609b3a6a8e9"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"b93d3bfe8152ec431694618403eacda319e55a4f","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        search_opts \u003d {}"},{"line_number":255,"context_line":"        search_opts.update(req.GET)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":258,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval(search_opts[\u0027metadata\u0027])"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F1F0%3D","line":257,"in_reply_to":"AAAAQn%2F%2F1Lg%3D","updated":"2013-07-22 15:23:54.000000000","message":"They are different approaches to fix the same bug.\nOne serialize the dict in the GET parameter, the other uses multiple params to send the metadata: ?metadata[key1]\u003dvalue1\u0026...","commit_id":"76fc407382315a97cc020e8592199609b3a6a8e9"}]}
