)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"ade0fced0ad2c98d866f335e0f0901c653560022","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"use \u0027exc_info\u003d1\u0027 instead of import traceback"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need store traceback message in log sometime. Python logging module"},{"line_number":10,"context_line":"already provide a argument to do that. For example, we could:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"logger.error(\u0027msg\u0027, exc_info\u003d1)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FhPE%3D","line":9,"updated":"2013-07-29 22:24:13.000000000","message":"/store/store a/","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"ade0fced0ad2c98d866f335e0f0901c653560022","unresolved":false,"context_lines":[{"line_number":7,"context_line":"use \u0027exc_info\u003d1\u0027 instead of import traceback"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need store traceback message in log sometime. Python logging module"},{"line_number":10,"context_line":"already provide a argument to do that. For example, we could:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"logger.error(\u0027msg\u0027, exc_info\u003d1)"},{"line_number":13,"context_line":"logger.debug(e, exc_info\u003d(type_,value_,tb))"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAQn%2F%2FhPA%3D","line":10,"updated":"2013-07-29 22:24:13.000000000","message":"/provide a/provides an/","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"}],"cinder/volume/manager.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"bd77ec10b3f867225b5fdaee175c4a6e038f7969","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexcepted Error\u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F1GE%3D","line":299,"updated":"2013-07-22 15:22:37.000000000","message":"Recommend changing this:  LOG.error(_(\u0027Unexpected Error: \u0027), exc_info\u003dexc_info)\n\n1) It fixes the typo: Unexcepted-\u003eUnexpected\n2) Delineates where the error information starts.","commit_id":"f311fb05747fbaa237a844c45791a096ede4871a"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"effc3d94c20e08afe639234ad98f00aa2d7586ba","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexcepted Error\u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2F1FI%3D","line":299,"in_reply_to":"AAAAQn%2F%2F1GE%3D","updated":"2013-07-22 15:27:16.000000000","message":"thx!","commit_id":"f311fb05747fbaa237a844c45791a096ede4871a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"ade0fced0ad2c98d866f335e0f0901c653560022","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexpected Error: \u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FhOU%3D","line":299,"updated":"2013-07-29 22:24:13.000000000","message":"Nothing else uses _log_original_error() and it\u0027s private. We can probably just git rid of it entirely.","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"039e2c070e8e1e71666d7a572acfb3e709f2f2af","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexpected Error: \u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FgVk%3D","line":299,"in_reply_to":"AAAAQn%2F%2FgV4%3D","updated":"2013-07-30 04:08:06.000000000","message":"But it has already been removed in this patch","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"f80141bb966c085b924d2bf7d11fb5e71344e05d","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexpected Error: \u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FgV4%3D","line":299,"in_reply_to":"AAAAQn%2F%2FgcQ%3D","updated":"2013-07-30 04:03:40.000000000","message":"I meant remove the definition of _log_original_error.","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"},{"author":{"_account_id":6835,"name":"Kun Huang","email":"gareth@openstacker.org","username":"academicgareth"},"change_message_id":"46073546338a89d709b15419cd90d2d1824f616a","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                                                            filter_properties)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"                if rescheduled:"},{"line_number":299,"context_line":"                    LOG.error(_(\u0027Unexpected Error: \u0027), exc_info\u003dexc_info)"},{"line_number":300,"context_line":"                    msg \u003d (_(\u0027Creating %(volume_id)s %(snapshot_id)s \u0027"},{"line_number":301,"context_line":"                             \u0027%(image_id)s was rescheduled due to \u0027"},{"line_number":302,"context_line":"                             \u0027%(reason)s\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FgcQ%3D","line":299,"in_reply_to":"AAAAQn%2F%2FhOU%3D","updated":"2013-07-30 03:10:55.000000000","message":"sorry Mike for my understanding, I didn\u0027t get the \"We can probably just git rid of it entirely\".\n\nYou mean it\u0027s better to remove LOG.error here? If that, we maybe lost traceback of original exception (line 280 here) by a new exception in volume_update or self._reschedule_or_error\n\nIf removing the _log_original_error(), that\u0027s what I did here.","commit_id":"6d0d9e288f9333d88a73f4e0f0222a0064e905e9"}]}