)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"391b4ded33e7d742fe4481f05e128294c5792111","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This removes the option and continues to allow the function of"},{"line_number":13,"context_line":"overriding a host\u0027s value by using the backend_host option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib286d01b9826a4c3064ee8bfab251c4c47407b51"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_20365fe6","line":15,"updated":"2016-10-06 12:09:56.000000000","message":"-1: Missing DocImpact, since now the backed_host can also be defined in the DEFAULT section.  And this is important for projects like TripleO.","commit_id":"c6ee20e452defa168b1ff07d6157661177fa0ff0"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1d00c550e20541ce1562256edafd70b97fca2e69","unresolved":false,"context_lines":[{"line_number":12,"context_line":"This removes the option and continues to allow the function of"},{"line_number":13,"context_line":"overriding a host\u0027s value by using the backend_host option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib286d01b9826a4c3064ee8bfab251c4c47407b51"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a95cdbc_e8560cd1","line":15,"in_reply_to":"1a95cdbc_20365fe6","updated":"2016-10-06 16:47:35.000000000","message":"Done","commit_id":"c6ee20e452defa168b1ff07d6157661177fa0ff0"}],"cinder/cmd/volume.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"abeb5f2b1fcd611ee1da094b1a9d3449b7f20e8a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    if CONF.enabled_backends:"},{"line_number":85,"context_line":"        for backend in filter(None, CONF.enabled_backends):"},{"line_number":86,"context_line":"            CONF.register_opt(host_opt, group\u003dbackend)"},{"line_number":87,"context_line":"            backend_host \u003d getattr(CONF, backend).backend_host"},{"line_number":88,"context_line":"            host \u003d \"%s@%s\" % (backend_host or CONF.backend_host, backend)"},{"line_number":89,"context_line":"            # We also want to set cluster to None on empty strings, and we"},{"line_number":90,"context_line":"            # ignore leading and trailing spaces."},{"line_number":91,"context_line":"            cluster \u003d CONF.cluster and CONF.cluster.strip()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a95cdbc_27277a65","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":73},"updated":"2016-10-05 16:44:15.000000000","message":"Hm, we can define `backend_host` option both in [DEFAULT] and specific backend configuration? Seems to make sense to me.","commit_id":"3cdf19e28e34ea76a0035f0afaa5ec3f5d1688f8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"391b4ded33e7d742fe4481f05e128294c5792111","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for backend in filter(None, CONF.enabled_backends):"},{"line_number":86,"context_line":"            CONF.register_opt(host_opt, group\u003dbackend)"},{"line_number":87,"context_line":"            backend_host \u003d getattr(CONF, backend).backend_host"},{"line_number":88,"context_line":"            host \u003d \"%s@%s\" % (backend_host or CONF.backend_host, backend)"},{"line_number":89,"context_line":"            # We also want to set cluster to None on empty strings, and we"},{"line_number":90,"context_line":"            # ignore leading and trailing spaces."},{"line_number":91,"context_line":"            cluster \u003d CONF.cluster and CONF.cluster.strip()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_ac67cb23","line":88,"range":{"start_line":88,"start_character":46,"end_line":88,"end_character":63},"updated":"2016-10-06 12:09:56.000000000","message":"nit: Since this is effectively changing current behavior, as you point out in the release notes, I think it should also be mentioned in the commit message.","commit_id":"c6ee20e452defa168b1ff07d6157661177fa0ff0"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"1d00c550e20541ce1562256edafd70b97fca2e69","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        for backend in filter(None, CONF.enabled_backends):"},{"line_number":86,"context_line":"            CONF.register_opt(host_opt, group\u003dbackend)"},{"line_number":87,"context_line":"            backend_host \u003d getattr(CONF, backend).backend_host"},{"line_number":88,"context_line":"            host \u003d \"%s@%s\" % (backend_host or CONF.backend_host, backend)"},{"line_number":89,"context_line":"            # We also want to set cluster to None on empty strings, and we"},{"line_number":90,"context_line":"            # ignore leading and trailing spaces."},{"line_number":91,"context_line":"            cluster \u003d CONF.cluster and CONF.cluster.strip()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_a84c0443","line":88,"range":{"start_line":88,"start_character":46,"end_line":88,"end_character":63},"in_reply_to":"1a95cdbc_ac67cb23","updated":"2016-10-06 16:47:35.000000000","message":"Done","commit_id":"c6ee20e452defa168b1ff07d6157661177fa0ff0"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"272909560d7c7443463d522257c104647af1c953","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CONF \u003d cfg.CONF"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"deprecated_host_opt \u003d cfg.DeprecatedOpt(\u0027host\u0027)"},{"line_number":58,"context_line":"host_opt \u003d cfg.StrOpt(\u0027backend_host\u0027, help\u003d\u0027Backend override of host value.\u0027,"},{"line_number":59,"context_line":"                      deprecated_opts\u003d[deprecated_host_opt])"},{"line_number":60,"context_line":"CONF.register_cli_opt(host_opt)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_666982be","side":"PARENT","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":47},"updated":"2016-10-28 13:39:59.000000000","message":"Waaait, isn\u0027t this the one from the [DEFAULT] section? And it actually is still used in various places, like [1], [2].\n\n[1] https://github.com/openstack/cinder/blob/8a4aecb155478e9493f4d36b080ccdf6be406eba/cinder/rpc.py#L176-L176\n[2] https://github.com/openstack/cinder/blob/087734f930fe54ccd83587bd8a0166784711e327/cinder/manager.py#L85-L85","commit_id":"75b89a36e3e6d1d4a83ded5808254a4913eb11c3"}],"releasenotes/notes/remove-deprecated-host-option-95c08000a55d470c.yaml":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"abeb5f2b1fcd611ee1da094b1a9d3449b7f20e8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The host option has been deprecated since Juno and is now removed in the"},{"line_number":4,"context_line":"    Ocata release. Please update your cinder.conf to use backend_host instead"},{"line_number":5,"context_line":"    of the host option."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a95cdbc_27de9a3f","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":23},"updated":"2016-10-05 16:44:15.000000000","message":"Can you explain here that backend_host can be also used in [DEFAULT] section as a default backend_host for all backend? It\u0027s name may confuse people on that.","commit_id":"3cdf19e28e34ea76a0035f0afaa5ec3f5d1688f8"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"65a2ef91a38e49d76c00216731ffb1078c71dca8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - The host option has been deprecated since Juno and is now removed in the"},{"line_number":4,"context_line":"    Ocata release. Please update your cinder.conf to use backend_host instead"},{"line_number":5,"context_line":"    of the host option."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a95cdbc_22e848b4","line":5,"range":{"start_line":3,"start_character":0,"end_line":5,"end_character":23},"in_reply_to":"1a95cdbc_27de9a3f","updated":"2016-10-05 17:02:55.000000000","message":"Done","commit_id":"3cdf19e28e34ea76a0035f0afaa5ec3f5d1688f8"}]}
