)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"2e8c195cb31e616b9f770815cdf1031b458ad341","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-18 15:44:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unreserve volume: fix log message for failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conditional_update fails, don\u0027t log an"},{"line_number":10,"context_line":"info message indicating that the operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_f3fd446f","line":7,"updated":"2016-10-19 07:11:02.000000000","message":"Given the discussion, I think it\u0027s better to remove \u0027failure\u0027 in commit message as well.","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0ee2576fdbc0b3eabbada5046dd31fb6b55d98f4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-18 15:44:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unreserve volume: fix log message for failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conditional_update fails, don\u0027t log an"},{"line_number":10,"context_line":"info message indicating that the operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_a8e7153f","line":7,"in_reply_to":"fa6399be_4407041d","updated":"2016-12-12 21:28:04.000000000","message":"Done","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a2570b1149faf810003b0f761911d16aa5eb175","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eric Harney \u003ceharney@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-10-18 15:44:00 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Unreserve volume: fix log message for failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conditional_update fails, don\u0027t log an"},{"line_number":10,"context_line":"info message indicating that the operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_4407041d","line":7,"in_reply_to":"fa6399be_f3fd446f","updated":"2016-10-19 08:40:49.000000000","message":"+1","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a2570b1149faf810003b0f761911d16aa5eb175","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conditional_update fails, don\u0027t log an"},{"line_number":10,"context_line":"info message indicating that the operation"},{"line_number":11,"context_line":"succeeded."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52486828e85fed90af45bf13fdf39738699b1002"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa6399be_3f35bdda","line":11,"updated":"2016-10-19 08:40:49.000000000","message":"-1: Commit message requires update after code change","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0ee2576fdbc0b3eabbada5046dd31fb6b55d98f4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If conditional_update fails, don\u0027t log an"},{"line_number":10,"context_line":"info message indicating that the operation"},{"line_number":11,"context_line":"succeeded."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52486828e85fed90af45bf13fdf39738699b1002"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a6eadb0_c8e4513d","line":11,"in_reply_to":"fa6399be_3f35bdda","updated":"2016-12-12 21:28:04.000000000","message":"Done","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"}],"cinder/volume/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2bf71c1ba14ac51ff0edecf0bede774c40d99589","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.error(_LE(\"Unreserve volume did not complete successfully.\"),"},{"line_number":641,"context_line":"                      resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_0b182dd2","line":640,"updated":"2016-10-03 17:57:06.000000000","message":"Does this really need to become an error now? For example, let\u0027s say nova doesn\u0027t reserve the volume but calls unreserve in some cleanup flow, which is how this is coming up:\n\nhttps://review.openstack.org/#/c/335358/17/nova/conductor/manager.py@516\n\nIt shouldn\u0027t be an error, it\u0027s just a noop, but the volume isn\u0027t in attaching state anymore so we\u0027re all good.\n\nNova would check the volume status, but we\u0027re trying to get away from nova having to check a point in time value of a volume status and just rely on cinder for handling those details.","commit_id":"70e003bb6331f557bebefdab3e370dd4dabcad28"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2302a9eba5869381bb58fa6c7696f880d2970944","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.error(_LE(\"Unreserve volume did not complete successfully.\"),"},{"line_number":641,"context_line":"                      resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a98d1f4_0b9bcd18","line":640,"in_reply_to":"3a98d1f4_0b182dd2","updated":"2016-10-03 18:01:47.000000000","message":"I would think a warning is fine or info at best.","commit_id":"70e003bb6331f557bebefdab3e370dd4dabcad28"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c8407516eeb3d40c9a6d9c3da620338b7ac03230","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.info(_LI(\"Unreserve volume did not complete successfully.\"),"},{"line_number":641,"context_line":"                     resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_921f05b6","line":640,"range":{"start_line":640,"start_character":26,"end_line":640,"end_character":73},"updated":"2016-10-03 21:35:04.000000000","message":"I\u0027m struggling a bit with the wording here. \u0027Success\u0027 in this case depends on your viewpoint. The API caller just cares that the volume is not listed as \u0027attaching\u0027 anymore, so in this case it\u0027s a success even though nothing changed.\n\nIf someone cares that nothing changed, then they are looking for bugs, and I think this should just be debug level logging.\n\nThe more I think about this I\u0027m not even sure if we need this change at all.","commit_id":"168eaa6620621cd2fdb79706846ffbd042d8bf6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2c9e02c04be44fe2a99a57eebda0d832f9dcfced","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.info(_LI(\"Unreserve volume did not complete successfully.\"),"},{"line_number":641,"context_line":"                     resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a98d1f4_665c6919","line":640,"range":{"start_line":640,"start_character":26,"end_line":640,"end_character":73},"in_reply_to":"3a98d1f4_921f05b6","updated":"2016-10-04 11:09:54.000000000","message":"I agree, when the conditional update mechanism was introduced here it mimicked what we had, which is as Matt says, to consider the non existence as success, just like we do when deleting a volume in the manager.\n\nSo I think we should have a debug log message saying that we attempted to unreserve non reserved volume, but we should still log the success at the info level.\n\nAnother option would be just to change the message saying \"Attempted to unreserve non reserved volume, nothing to do.\" or something like that.  But I don\u0027t think we should be saying that it did not complete successfully.","commit_id":"168eaa6620621cd2fdb79706846ffbd042d8bf6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8a2570b1149faf810003b0f761911d16aa5eb175","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.debug(\"Attempted to unreserve volume, nothing to do.\","},{"line_number":641,"context_line":"                      resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa6399be_7f465550","line":640,"updated":"2016-10-19 08:40:49.000000000","message":"nit: I think it would be good to specify why there\u0027s nothing to do (because it\u0027s not reserved).","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0ee2576fdbc0b3eabbada5046dd31fb6b55d98f4","unresolved":false,"context_lines":[{"line_number":637,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":638,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":639,"context_line":"        if not result:"},{"line_number":640,"context_line":"            LOG.debug(\"Attempted to unreserve volume, nothing to do.\","},{"line_number":641,"context_line":"                      resource\u003dvolume)"},{"line_number":642,"context_line":"            return"},{"line_number":643,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a6eadb0_68ddfd6f","line":640,"in_reply_to":"fa6399be_7f465550","updated":"2016-12-12 21:28:04.000000000","message":"Done","commit_id":"fcac0e81264ce46068711037ff3aadbb8a2581ee"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"57fb87f93dc2bdadc55154f29a1c3cbf09bf5ee5","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                                   else_\u003d\u0027available\u0027)}"},{"line_number":641,"context_line":"        result \u003d volume.conditional_update(value, expected)"},{"line_number":642,"context_line":"        if not result:"},{"line_number":643,"context_line":"            LOG.debug(\"Attempted to unreserve volume that was not \""},{"line_number":644,"context_line":"                      \"reserved, nothing to do.\","},{"line_number":645,"context_line":"                      resource\u003dvolume)"},{"line_number":646,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a6eadb0_2e5e44e9","line":643,"updated":"2016-12-21 00:56:48.000000000","message":"what is resource for here?","commit_id":"ab84ead732332501fd04729fcab2d77e09998ea5"}]}