)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    def fake_extend_volume(self, volume, new_size):"},{"line_number":400,"context_line":"        vol \u003d self.driver.common.client.getVolume(volume[\u0027name\u0027])"},{"line_number":401,"context_line":"        old_size \u003d vol[\u0027sizeMiB\u0027]"},{"line_number":402,"context_line":"        if old_size \u003e new_size:"},{"line_number":403,"context_line":"            msg \u003d \"Cannot shrink volumes.\""},{"line_number":404,"context_line":"            raise exception.InvalidInput(msg)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0Pk%3D","line":402,"updated":"2013-07-22 19:47:33.000000000","message":"This check shouldn\u0027t be here, it\u0027s done by the API layer.  Then old_size isn\u0027t needed at all.  I also see that you have \u0027sizeMiB\u0027 - be careful that new_size is in GiB.","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":399,"context_line":"    def fake_extend_volume(self, volume, new_size):"},{"line_number":400,"context_line":"        vol \u003d self.driver.common.client.getVolume(volume[\u0027name\u0027])"},{"line_number":401,"context_line":"        old_size \u003d vol[\u0027sizeMiB\u0027]"},{"line_number":402,"context_line":"        if old_size \u003e new_size:"},{"line_number":403,"context_line":"            msg \u003d \"Cannot shrink volumes.\""},{"line_number":404,"context_line":"            raise exception.InvalidInput(msg)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoU%3D","line":402,"in_reply_to":"AAAAQn%2F%2F0Pk%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                                               option)"},{"line_number":563,"context_line":"        old_size \u003d self.volume[\u0027size\u0027]"},{"line_number":564,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":565,"context_line":"        self.driver.extend_volume(volume, old_size + 1)"},{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0PE%3D","line":565,"updated":"2013-07-22 19:47:33.000000000","message":"size argument should be a string","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                                               option)"},{"line_number":563,"context_line":"        old_size \u003d self.volume[\u0027size\u0027]"},{"line_number":564,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":565,"context_line":"        self.driver.extend_volume(volume, old_size + 1)"},{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoQ%3D","line":565,"in_reply_to":"AAAAQn%2F%2F0PE%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":565,"context_line":"        self.driver.extend_volume(volume, old_size + 1)"},{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def test_invalid_extend_volume(self):"},{"line_number":570,"context_line":"        self.flags(lock_path\u003dself.tempdir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0PA%3D","line":567,"updated":"2013-07-22 19:47:33.000000000","message":"Again, size argument should be a string, and make sure your units are correct (MiB/GiB)","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":565,"context_line":"        self.driver.extend_volume(volume, old_size + 1)"},{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def test_invalid_extend_volume(self):"},{"line_number":570,"context_line":"        self.flags(lock_path\u003dself.tempdir)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoM%3D","line":567,"in_reply_to":"AAAAQn%2F%2F0PA%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def test_invalid_extend_volume(self):"},{"line_number":570,"context_line":"        self.flags(lock_path\u003dself.tempdir)"},{"line_number":571,"context_line":"        self.stubs.UnsetAll()"},{"line_number":572,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"extend_volume\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0Ow%3D","line":569,"updated":"2013-07-22 19:47:33.000000000","message":"This test can be removed, the checks are done by the API and should be removed from the driver code.","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":567,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], old_size + 1)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":"    def test_invalid_extend_volume(self):"},{"line_number":570,"context_line":"        self.flags(lock_path\u003dself.tempdir)"},{"line_number":571,"context_line":"        self.stubs.UnsetAll()"},{"line_number":572,"context_line":"        self.stubs.Set(hpdriver.hpcommon.HP3PARCommon, \"extend_volume\","}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoI%3D","line":569,"in_reply_to":"AAAAQn%2F%2F0Ow%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"773f3eaefa1d6f1796c03a8a8de87335d12ad2b7","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def fake_extend_volume(self, volume, new_size):"},{"line_number":400,"context_line":"        vol \u003d self.driver.common.client.getVolume(volume[\u0027name\u0027])"},{"line_number":401,"context_line":"        old_size \u003d vol[\u0027sizeMiB\u0027]"},{"line_number":402,"context_line":"        option \u003d {\u0027comment\u0027: vol[\u0027comment\u0027], \u0027snapCPG\u0027: vol[\u0027snapCPG\u0027]}"},{"line_number":403,"context_line":"        self.driver.common.client.deleteVolume(volume[\u0027name\u0027])"},{"line_number":404,"context_line":"        self.driver.common.client.createVolume(vol[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzA4%3D","line":401,"updated":"2013-07-23 03:07:51.000000000","message":"Again, is MiB correct here?","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"b62b35a8a17327aaec2b28bc87b194ce5e14e655","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def fake_extend_volume(self, volume, new_size):"},{"line_number":400,"context_line":"        vol \u003d self.driver.common.client.getVolume(volume[\u0027name\u0027])"},{"line_number":401,"context_line":"        old_size \u003d vol[\u0027sizeMiB\u0027]"},{"line_number":402,"context_line":"        option \u003d {\u0027comment\u0027: vol[\u0027comment\u0027], \u0027snapCPG\u0027: vol[\u0027snapCPG\u0027]}"},{"line_number":403,"context_line":"        self.driver.common.client.deleteVolume(volume[\u0027name\u0027])"},{"line_number":404,"context_line":"        self.driver.common.client.createVolume(vol[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fwi8%3D","line":401,"in_reply_to":"AAAAQn%2F%2FzA4%3D","updated":"2013-07-23 19:08:24.000000000","message":"Yes, the key is correct. The behavior is as expected.","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"773f3eaefa1d6f1796c03a8a8de87335d12ad2b7","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":561,"context_line":"        self.driver.extend_volume(volume, str(old_size + 1))"},{"line_number":562,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":563,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], str(old_size + 1))"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class TestHP3PARFCDriver(HP3PARBaseDriver, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzA0%3D","line":563,"updated":"2013-07-23 03:07:51.000000000","message":"Again, is MiB correct here?","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"b62b35a8a17327aaec2b28bc87b194ce5e14e655","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        volume \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":561,"context_line":"        self.driver.extend_volume(volume, str(old_size + 1))"},{"line_number":562,"context_line":"        vol \u003d self.driver.common.client.getVolume(self.volume[\u0027name\u0027])"},{"line_number":563,"context_line":"        self.assertEqual(vol[\u0027sizeMiB\u0027], str(old_size + 1))"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"class TestHP3PARFCDriver(HP3PARBaseDriver, test.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fwi4%3D","line":563,"in_reply_to":"AAAAQn%2F%2FzA0%3D","updated":"2013-07-23 19:08:24.000000000","message":"Yes.","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                old_size \u003d volume.size"},{"line_number":207,"context_line":"                if not (new_size \u003e old_size):"},{"line_number":208,"context_line":"                    err \u003d \"Invalid size specified. Cannot shrink volumes\""},{"line_number":209,"context_line":"                    LOG.error(err)"},{"line_number":210,"context_line":"                    raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0RY%3D","line":207,"updated":"2013-07-22 19:47:33.000000000","message":"No need to check this - it\u0027s already done by the API layer","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                raise exception.InvalidInput(reason\u003derr)"},{"line_number":205,"context_line":"            else:"},{"line_number":206,"context_line":"                old_size \u003d volume.size"},{"line_number":207,"context_line":"                if not (new_size \u003e old_size):"},{"line_number":208,"context_line":"                    err \u003d \"Invalid size specified. Cannot shrink volumes\""},{"line_number":209,"context_line":"                    LOG.error(err)"},{"line_number":210,"context_line":"                    raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoE%3D","line":207,"in_reply_to":"AAAAQn%2F%2F0RY%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    LOG.error(err)"},{"line_number":210,"context_line":"                    raise exception.InvalidInput(reason\u003derr)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"                growth_size \u003d new_size - old_size"},{"line_number":213,"context_line":"                LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":214,"context_line":"                          (hp_name, old_size, new_size, growth_size))"},{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0RE%3D","line":212,"updated":"2013-07-22 19:47:33.000000000","message":"new size is a string - you should cast to int here","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                    LOG.error(err)"},{"line_number":210,"context_line":"                    raise exception.InvalidInput(reason\u003derr)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"                growth_size \u003d new_size - old_size"},{"line_number":213,"context_line":"                LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":214,"context_line":"                          (hp_name, old_size, new_size, growth_size))"},{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FzoA%3D","line":212,"in_reply_to":"AAAAQn%2F%2F0RE%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                          (hp_name, old_size, new_size, growth_size))"},{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"},{"line_number":216,"context_line":"                              None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0Q4%3D","line":217,"updated":"2013-07-22 19:47:33.000000000","message":"No blank line here","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":214,"context_line":"                          (hp_name, old_size, new_size, growth_size))"},{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"},{"line_number":216,"context_line":"                              None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fzn8%3D","line":217,"in_reply_to":"AAAAQn%2F%2F0Q4%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"},{"line_number":216,"context_line":"                              None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"},{"line_number":221,"context_line":"            raise Exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0P8%3D","line":218,"updated":"2013-07-22 19:47:33.000000000","message":"I think you should have two try/excepts here - one in the beginning for finding the volume metadata, and one for executing the actual command - the whole function shouldn\u0027t be in a try/except.","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                self._cli_run(\"growvv -f %s %sg\" % (hp_name, growth_size),"},{"line_number":216,"context_line":"                              None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"},{"line_number":221,"context_line":"            raise Exception(err)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fzno%3D","line":218,"in_reply_to":"AAAAQn%2F%2F0P8%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"27b55195c1030eff5551bd9eb24aedb3185e342e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"},{"line_number":221,"context_line":"            raise Exception(err)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":224,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F0Pw%3D","line":221,"updated":"2013-07-22 19:47:33.000000000","message":"You should reraise here rather than raise a new exception.","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"7bf8546e948366918c93cbd1fd8bd0246cc3f9df","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        except Exception:"},{"line_number":219,"context_line":"            err \u003d \"Volume extend failed for %s\" % (volume)"},{"line_number":220,"context_line":"            LOG.error(err)"},{"line_number":221,"context_line":"            raise Exception(err)"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":224,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Fznk%3D","line":221,"in_reply_to":"AAAAQn%2F%2F0Pw%3D","updated":"2013-07-22 22:54:52.000000000","message":"Done","commit_id":"f767d985ad6dccd9a2170c8eeaf540c422a1c1cf"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"763a2e5a4eb3a2fd0b959dbc099a426cd4b567e4","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        return domain"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":199,"context_line":"        hp_name \u003d self.get_volume_metadata_value(volume, \u00273ParName\u0027)"},{"line_number":200,"context_line":"        if (hp_name is None):"},{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FxXk%3D","line":199,"updated":"2013-07-23 14:53:13.000000000","message":"I would prefer that you did not use the metadata keys as these will be removed in bug: https://bugs.launchpad.net/cinder/+bug/1203144","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"b62b35a8a17327aaec2b28bc87b194ce5e14e655","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        return domain"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":199,"context_line":"        hp_name \u003d self.get_volume_metadata_value(volume, \u00273ParName\u0027)"},{"line_number":200,"context_line":"        if (hp_name is None):"},{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fwhg%3D","line":199,"in_reply_to":"AAAAQn%2F%2FxXk%3D","updated":"2013-07-23 19:08:24.000000000","message":"Done","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d0efb47092192b469c7c7abb54038b8090b780fe","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":199,"context_line":"        hp_name \u003d self.get_volume_metadata_value(volume, \u00273ParName\u0027)"},{"line_number":200,"context_line":"        if (hp_name is None):"},{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"},{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzaU%3D","line":200,"updated":"2013-07-23 00:24:30.000000000","message":"don\u0027t need the parentheses","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"b62b35a8a17327aaec2b28bc87b194ce5e14e655","unresolved":false,"context_lines":[{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def extend_volume(self, volume, new_size):"},{"line_number":199,"context_line":"        hp_name \u003d self.get_volume_metadata_value(volume, \u00273ParName\u0027)"},{"line_number":200,"context_line":"        if (hp_name is None):"},{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"},{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fwhc%3D","line":200,"in_reply_to":"AAAAQn%2F%2FzaU%3D","updated":"2013-07-23 19:08:24.000000000","message":"Done","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"773f3eaefa1d6f1796c03a8a8de87335d12ad2b7","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"},{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzAo%3D","line":204,"updated":"2013-07-23 03:07:51.000000000","message":"You don\u0027t need this \u0027else\u0027 because you raise an exception in the \u0027if\u0027","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"b62b35a8a17327aaec2b28bc87b194ce5e14e655","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            err \u003d \"Volume not found\""},{"line_number":202,"context_line":"            LOG.error(err)"},{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FwhY%3D","line":204,"in_reply_to":"AAAAQn%2F%2FzAo%3D","updated":"2013-07-23 19:08:24.000000000","message":"Done","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"5a3f8ca522ddd348252e7ff11483085d6f56db49","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":208,"context_line":"                      (hp_name, old_size, new_size, growth_size))"},{"line_number":209,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fylc%3D","line":206,"updated":"2013-07-23 07:23:53.000000000","message":"Is it acceptable that new_size might be smaller than old size so that growth_size would be negative? Or is that tested somewhere else?","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":1994,"name":"Zhongyue Luo","email":"zhongyue.luo@gmail.com","username":"zyluo"},"change_message_id":"d0efb47092192b469c7c7abb54038b8090b780fe","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":208,"context_line":"                      (hp_name, old_size, new_size, growth_size))"},{"line_number":209,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzZs%3D","line":206,"updated":"2013-07-23 00:24:30.000000000","message":"Is there a possibility that new_size is string?","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"33aa8e5d920d2bfbeef9ea0ab1fcb9f64b361607","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":208,"context_line":"                      (hp_name, old_size, new_size, growth_size))"},{"line_number":209,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FygY%3D","line":206,"in_reply_to":"AAAAQn%2F%2Fylc%3D","updated":"2013-07-23 07:56:31.000000000","message":"That\u0027s tested by the API","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"773f3eaefa1d6f1796c03a8a8de87335d12ad2b7","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            old_size \u003d volume.size"},{"line_number":206,"context_line":"            growth_size \u003d int(new_size) - old_size"},{"line_number":207,"context_line":"            LOG.debug(\"Extending Volume %s from %s to %s, by %s GB.\" %"},{"line_number":208,"context_line":"                      (hp_name, old_size, new_size, growth_size))"},{"line_number":209,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FzBA%3D","line":206,"in_reply_to":"AAAAQn%2F%2FzZs%3D","updated":"2013-07-23 03:07:51.000000000","message":"yes, it is","commit_id":"6989b544b8f39d0b1e34dbb4290dbecc139246bf"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"bc88c92fe9c492bfa06ec390efc0bbf825ba2a9a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          None)"},{"line_number":207,"context_line":"        except Exception as ex:"},{"line_number":208,"context_line":"            LOG.error(str(ex))"},{"line_number":209,"context_line":"            raise ex"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":212,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Ft5E%3D","line":209,"updated":"2013-07-24 14:51:20.000000000","message":"Maybe you didn\u0027t understand my comment from patch set 1 about reraising the exception.  See line #357 in this file for an example.","commit_id":"86282391e849ac660b830bf269bbd5b5f414543d"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"35c3590b40cbd43188a63e424dbc12f4e9370807","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          None)"},{"line_number":207,"context_line":"        except Exception as ex:"},{"line_number":208,"context_line":"            LOG.error(str(ex))"},{"line_number":209,"context_line":"            raise ex"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":212,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Ftng%3D","line":209,"in_reply_to":"AAAAQn%2F%2Ft5E%3D","updated":"2013-07-24 16:07:48.000000000","message":"Sorry about that. Got it fixed.","commit_id":"86282391e849ac660b830bf269bbd5b5f414543d"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"f743394d3d8cfc93a0248c2c98769ceb193712f9","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          None)"},{"line_number":207,"context_line":"        except Exception:"},{"line_number":208,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":209,"context_line":"                LOG.error(\"Error extending volume %s\" % (volume))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":212,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FtO8%3D","line":209,"updated":"2013-07-24 18:01:18.000000000","message":"Should be:\nLOG.error(_(\"Error extending volume %s\") % volume)","commit_id":"efd0aede0cdb3ecbeab65b080b81af9f3c8d1911"},{"author":{"_account_id":7837,"name":"Viraj Hardikar","email":"viraj.hardikar@hp.com","username":"virajh"},"change_message_id":"38ca0c0fbd702e3011ad9429a4bf0bf288ece89f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                          None)"},{"line_number":207,"context_line":"        except Exception:"},{"line_number":208,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":209,"context_line":"                LOG.error(\"Error extending volume %s\" % (volume))"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def _get_3par_vol_name(self, volume_id):"},{"line_number":212,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FtF4%3D","line":209,"in_reply_to":"AAAAQn%2F%2FtO8%3D","updated":"2013-07-24 18:39:59.000000000","message":"Done","commit_id":"efd0aede0cdb3ecbeab65b080b81af9f3c8d1911"}]}