)]}'
{"cinder/volume/drivers/netapp/dataontap/block_7mode.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5aa03488b0b1c66225f5ec83119eafd200e08af5","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        super(NetAppBlockStorage7modeLibrary, self)._add_looping_tasks()"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def _get_volume_model_update(self, volume):"},{"line_number":130,"context_line":"        \"\"\"Provide any updates necessary for a volume being created/managed.\"\"\""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def _create_lun(self, volume_name, lun_name, size,"},{"line_number":133,"context_line":"                    metadata, qos_policy_group_name\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_7fc9b025","line":130,"updated":"2016-10-07 10:11:09.000000000","message":"This is not nice, the right approach would have been to make the base return None, but in that absence it should have been done here, or at the very list added `pass` here.","commit_id":"0bed2f471ebba59445c82c08e63794167d0b3ecf"}],"cinder/volume/drivers/netapp/dataontap/block_base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5aa03488b0b1c66225f5ec83119eafd200e08af5","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _get_volume_model_update(self, volume):"},{"line_number":260,"context_line":"        \"\"\"Provide any updates necessary for a volume being created/managed.\"\"\""},{"line_number":261,"context_line":"        raise NotImplementedError"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _mark_qos_policy_group_for_deletion(self, qos_policy_group_info):"},{"line_number":264,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_3fbd6802","line":261,"updated":"2016-10-07 10:11:09.000000000","message":"This should not have been merged in master, this should be returning None, instead of raising an exception.  :-(","commit_id":"0bed2f471ebba59445c82c08e63794167d0b3ecf"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"68a7518c2dead62e096f0fa528bc3bb784bb417c","unresolved":false,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def _get_volume_model_update(self, volume):"},{"line_number":260,"context_line":"        \"\"\"Provide any updates necessary for a volume being created/managed.\"\"\""},{"line_number":261,"context_line":"        raise NotImplementedError"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def _mark_qos_policy_group_for_deletion(self, qos_policy_group_info):"},{"line_number":264,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_2149b0d0","line":261,"in_reply_to":"1a95cdbc_3fbd6802","updated":"2016-10-14 14:51:26.000000000","message":"I think this is fine. This is the base class that needs a concrete implementation. NotImplementedError is a good way to make sure there are no coding issues for any child classes inheriting from this driver.","commit_id":"0bed2f471ebba59445c82c08e63794167d0b3ecf"}],"cinder/volume/drivers/netapp/dataontap/nfs_7mode.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5aa03488b0b1c66225f5ec83119eafd200e08af5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        return"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def _get_volume_model_update(self, volume):"},{"line_number":232,"context_line":"        \"\"\"Provide any updates necessary for a volume being created/managed.\"\"\""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def _get_backing_flexvol_names(self):"},{"line_number":235,"context_line":"        \"\"\"Returns a list of backing flexvol names.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_dfd484be","line":232,"updated":"2016-10-07 10:11:09.000000000","message":"This is not nice, the right approach would have been to make the base return None, but in that absence it should have been done here, or at the very list added `pass` here.","commit_id":"0bed2f471ebba59445c82c08e63794167d0b3ecf"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5aa03488b0b1c66225f5ec83119eafd200e08af5","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def _get_volume_model_update(self, volume):"},{"line_number":248,"context_line":"        \"\"\"Provide any updates necessary for a volume being created/managed.\"\"\""},{"line_number":249,"context_line":"        raise NotImplementedError()"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def create_snapshot(self, snapshot):"},{"line_number":252,"context_line":"        \"\"\"Creates a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a95cdbc_5f1cf4c0","line":249,"updated":"2016-10-07 10:11:09.000000000","message":"This also should have been set as return None","commit_id":"0bed2f471ebba59445c82c08e63794167d0b3ecf"}]}