)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"485da02765969525d86f864741e6a033514848ec","unresolved":false,"context_lines":[{"line_number":15,"context_line":"configuring the drivers by cinder.conf in favor of"},{"line_number":16,"context_line":"hnas_svcX_pool_name, so it can express more precisely the real"},{"line_number":17,"context_line":"purpose of this option."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4e2f145b1124f5b567585ec831a58ca6c8138aa5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_1975aff8","line":18,"updated":"2016-11-23 14:05:37.000000000","message":"nit: Maybe mention the change in the XML","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"91d07e8c94e53c1d7567cfc7686e378deec2b586","unresolved":false,"context_lines":[{"line_number":15,"context_line":"configuring the drivers by cinder.conf in favor of"},{"line_number":16,"context_line":"hnas_svcX_pool_name, so it can express more precisely the real"},{"line_number":17,"context_line":"purpose of this option."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I4e2f145b1124f5b567585ec831a58ca6c8138aa5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_2c272cb7","line":18,"in_reply_to":"5a74a57a_1975aff8","updated":"2016-11-28 12:23:48.000000000","message":"Done","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hnas_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"485da02765969525d86f864741e6a033514848ec","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                        \u0027version\u0027: \u002712.4.3924.11\u0027, \u0027hardware\u0027: \u0027NAS Platform\u0027,"},{"line_number":282,"context_line":"                        \u0027serial\u0027: \u0027B1339109\u0027, }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        parsed_xml_svc_vol_type \u003d {"},{"line_number":285,"context_line":"            \u0027username\u0027: \u0027supervisor\u0027,"},{"line_number":286,"context_line":"            \u0027password\u0027: \u0027supervisor\u0027,"},{"line_number":287,"context_line":"            \u0027hnas_cmd\u0027: \u0027ssc\u0027, \u0027fs\u0027: {\u0027fs2\u0027: \u0027fs2\u0027},"},{"line_number":288,"context_line":"            \u0027ssh_port\u0027: \u002722\u0027,"},{"line_number":289,"context_line":"            \u0027port\u0027: \u00273260\u0027,"},{"line_number":290,"context_line":"            \u0027services\u0027: {"},{"line_number":291,"context_line":"                \u0027default\u0027: {"},{"line_number":292,"context_line":"                    \u0027hdp\u0027: \u0027fs2\u0027,"},{"line_number":293,"context_line":"                    \u0027iscsi_ip\u0027: \u0027172.17.39.132\u0027,"},{"line_number":294,"context_line":"                    \u0027iscsi_port\u0027: \u00273260\u0027,"},{"line_number":295,"context_line":"                    \u0027port\u0027: \u002722\u0027,"},{"line_number":296,"context_line":"                    \u0027volume_type\u0027: \u0027default\u0027,"},{"line_number":297,"context_line":"                    \u0027label\u0027: \u0027svc_0\u0027, \u0027evs\u0027: \u00271\u0027,"},{"line_number":298,"context_line":"                    \u0027tgt\u0027: {"},{"line_number":299,"context_line":"                        \u0027alias\u0027: \u0027test\u0027,"},{"line_number":300,"context_line":"                        \u0027secret\u0027: \u0027itEpgB5gPefGhW2\u0027}},"},{"line_number":301,"context_line":"                \u0027silver\u0027: {"},{"line_number":302,"context_line":"                    \u0027hdp\u0027: \u0027fs3\u0027,"},{"line_number":303,"context_line":"                    \u0027iscsi_ip\u0027: \u0027172.17.39.133\u0027,"},{"line_number":304,"context_line":"                    \u0027iscsi_port\u0027: \u00273260\u0027,"},{"line_number":305,"context_line":"                    \u0027port\u0027: \u002722\u0027,"},{"line_number":306,"context_line":"                    \u0027volume_type\u0027: \u0027silver\u0027,"},{"line_number":307,"context_line":"                    \u0027label\u0027: \u0027svc_1\u0027, \u0027evs\u0027: \u00272\u0027,"},{"line_number":308,"context_line":"                    \u0027tgt\u0027: {"},{"line_number":309,"context_line":"                        \u0027alias\u0027: \u0027iscsi-test\u0027,"},{"line_number":310,"context_line":"                        \u0027secret\u0027: \u0027itEpgB5gPefGhW2\u0027}}},"},{"line_number":311,"context_line":"            \u0027cluster_admin_ip0\u0027: None, \u0027ssh_private_key\u0027: None,"},{"line_number":312,"context_line":"            \u0027chap_enabled\u0027: True, \u0027mgmt_ip0\u0027: \u0027172.17.44.15\u0027,"},{"line_number":313,"context_line":"            \u0027ssh_enabled\u0027: None}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.mock_object(hnas_utils, \u0027read_cinder_conf\u0027,"},{"line_number":316,"context_line":"                         mock.Mock(return_value\u003dparsed_xml_svc_vol_type))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_798303cd","line":313,"range":{"start_line":284,"start_character":1,"end_line":313,"end_character":32},"updated":"2016-11-23 14:05:37.000000000","message":"-1: You should reuse self.parsed_xml, that way you won\u0027t need to redo the mocks done in the setup and this test will be more readable:\n\n for service in self.parsed_xml[\u0027services\u0027]:\n     service[\u0027volume_type\u0027] \u003d service.pop(\u0027pool_name\u0027)","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"91d07e8c94e53c1d7567cfc7686e378deec2b586","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                        \u0027version\u0027: \u002712.4.3924.11\u0027, \u0027hardware\u0027: \u0027NAS Platform\u0027,"},{"line_number":282,"context_line":"                        \u0027serial\u0027: \u0027B1339109\u0027, }"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        parsed_xml_svc_vol_type \u003d {"},{"line_number":285,"context_line":"            \u0027username\u0027: \u0027supervisor\u0027,"},{"line_number":286,"context_line":"            \u0027password\u0027: \u0027supervisor\u0027,"},{"line_number":287,"context_line":"            \u0027hnas_cmd\u0027: \u0027ssc\u0027, \u0027fs\u0027: {\u0027fs2\u0027: \u0027fs2\u0027},"},{"line_number":288,"context_line":"            \u0027ssh_port\u0027: \u002722\u0027,"},{"line_number":289,"context_line":"            \u0027port\u0027: \u00273260\u0027,"},{"line_number":290,"context_line":"            \u0027services\u0027: {"},{"line_number":291,"context_line":"                \u0027default\u0027: {"},{"line_number":292,"context_line":"                    \u0027hdp\u0027: \u0027fs2\u0027,"},{"line_number":293,"context_line":"                    \u0027iscsi_ip\u0027: \u0027172.17.39.132\u0027,"},{"line_number":294,"context_line":"                    \u0027iscsi_port\u0027: \u00273260\u0027,"},{"line_number":295,"context_line":"                    \u0027port\u0027: \u002722\u0027,"},{"line_number":296,"context_line":"                    \u0027volume_type\u0027: \u0027default\u0027,"},{"line_number":297,"context_line":"                    \u0027label\u0027: \u0027svc_0\u0027, \u0027evs\u0027: \u00271\u0027,"},{"line_number":298,"context_line":"                    \u0027tgt\u0027: {"},{"line_number":299,"context_line":"                        \u0027alias\u0027: \u0027test\u0027,"},{"line_number":300,"context_line":"                        \u0027secret\u0027: \u0027itEpgB5gPefGhW2\u0027}},"},{"line_number":301,"context_line":"                \u0027silver\u0027: {"},{"line_number":302,"context_line":"                    \u0027hdp\u0027: \u0027fs3\u0027,"},{"line_number":303,"context_line":"                    \u0027iscsi_ip\u0027: \u0027172.17.39.133\u0027,"},{"line_number":304,"context_line":"                    \u0027iscsi_port\u0027: \u00273260\u0027,"},{"line_number":305,"context_line":"                    \u0027port\u0027: \u002722\u0027,"},{"line_number":306,"context_line":"                    \u0027volume_type\u0027: \u0027silver\u0027,"},{"line_number":307,"context_line":"                    \u0027label\u0027: \u0027svc_1\u0027, \u0027evs\u0027: \u00272\u0027,"},{"line_number":308,"context_line":"                    \u0027tgt\u0027: {"},{"line_number":309,"context_line":"                        \u0027alias\u0027: \u0027iscsi-test\u0027,"},{"line_number":310,"context_line":"                        \u0027secret\u0027: \u0027itEpgB5gPefGhW2\u0027}}},"},{"line_number":311,"context_line":"            \u0027cluster_admin_ip0\u0027: None, \u0027ssh_private_key\u0027: None,"},{"line_number":312,"context_line":"            \u0027chap_enabled\u0027: True, \u0027mgmt_ip0\u0027: \u0027172.17.44.15\u0027,"},{"line_number":313,"context_line":"            \u0027ssh_enabled\u0027: None}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        self.mock_object(hnas_utils, \u0027read_cinder_conf\u0027,"},{"line_number":316,"context_line":"                         mock.Mock(return_value\u003dparsed_xml_svc_vol_type))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_2c24515e","line":313,"range":{"start_line":284,"start_character":1,"end_line":313,"end_character":32},"in_reply_to":"5a74a57a_798303cd","updated":"2016-11-28 12:23:48.000000000","message":"This test does not make sense for the same reason commented on NFS","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hnas_nfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"485da02765969525d86f864741e6a033514848ec","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                          self.driver._check_pool_and_share, self.volume,"},{"line_number":156,"context_line":"                          nfs_shares)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_do_setup_svc_volume_type(self):"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        parsed_xml_svc_vol_type \u003d {"},{"line_number":161,"context_line":"            \u0027username\u0027: \u0027supervisor\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_598d6730","line":158,"updated":"2016-11-23 14:05:37.000000000","message":"-1: You should reuse self.parsed_xml, that way you won\u0027t need to redo the mocks done in the setup and this test will be more readable:\n\n pool_name \u003d self.parse_xml[\u0027services\u0027][\u0027default\u0027].pop(\u0027pool_name\u0027)\n self.parse_xml[\u0027services\u0027][\u0027default\u0027][\u0027volume_type\u0027] \u003d pool_name","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"91d07e8c94e53c1d7567cfc7686e378deec2b586","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                          self.driver._check_pool_and_share, self.volume,"},{"line_number":156,"context_line":"                          nfs_shares)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def test_do_setup_svc_volume_type(self):"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        parsed_xml_svc_vol_type \u003d {"},{"line_number":161,"context_line":"            \u0027username\u0027: \u0027supervisor\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_cc675db5","line":158,"in_reply_to":"5a74a57a_598d6730","updated":"2016-11-28 12:23:48.000000000","message":"You\u0027re right. However, we realized that this test does not make sense, since do_setup will never receive the volume_type. It always receives the configurations converted as pool_name.\nSo, this test will be removed.","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"}],"cinder/volume/drivers/hitachi/hnas_iscsi.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"acab56361c424726954a5f776337daca94c726ed","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        \"\"\""},{"line_number":342,"context_line":"        pool_from_vol_type \u003d hnas_utils.get_pool(self.config, volume)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        pool_from_host \u003d utils.extract_host(volume.host, level\u003d\u0027pool\u0027)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        if (pool_from_vol_type \u003d\u003d \u0027default\u0027 and"},{"line_number":347,"context_line":"                \u0027default\u0027 not in self.config[\u0027services\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_73e380d9","line":344,"updated":"2016-11-28 15:06:13.000000000","message":"nit: This should go after the new code at L356","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"6ca1bb54ee8504a7bb911bc406ccfae23eaad38f","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        \"\"\""},{"line_number":342,"context_line":"        pool_from_vol_type \u003d hnas_utils.get_pool(self.config, volume)"},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"        pool_from_host \u003d utils.extract_host(volume.host, level\u003d\u0027pool\u0027)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        if (pool_from_vol_type \u003d\u003d \u0027default\u0027 and"},{"line_number":347,"context_line":"                \u0027default\u0027 not in self.config[\u0027services\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_1c9339fb","line":344,"in_reply_to":"5a74a57a_73e380d9","updated":"2016-11-28 16:08:32.000000000","message":"Done","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"acab56361c424726954a5f776337daca94c726ed","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                     \"service_label configured in its extra-specs and there \""},{"line_number":351,"context_line":"                     \"is no pool configured with hnas_svcX_volume_type as \""},{"line_number":352,"context_line":"                     \"\u0027default\u0027 in cinder.conf.\") %"},{"line_number":353,"context_line":"                   {\u0027volume\u0027: volume.id, \u0027vol_type\u0027: volume.volume_type[\u0027id\u0027]})"},{"line_number":354,"context_line":"            LOG.error(msg)"},{"line_number":355,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_b384380b","line":353,"range":{"start_line":353,"start_character":60,"end_line":353,"end_character":77},"updated":"2016-11-28 15:06:13.000000000","message":"-1: We should use attribute notation when accessing OVO instances, so this should be `volume.volume_type.id`, but even then volume_type could be None, so this could fail.  Maybe it\u0027d be better to do: `getattr(volume.volume_type, \u0027id\u0027, None)`","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"6ca1bb54ee8504a7bb911bc406ccfae23eaad38f","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                     \"service_label configured in its extra-specs and there \""},{"line_number":351,"context_line":"                     \"is no pool configured with hnas_svcX_volume_type as \""},{"line_number":352,"context_line":"                     \"\u0027default\u0027 in cinder.conf.\") %"},{"line_number":353,"context_line":"                   {\u0027volume\u0027: volume.id, \u0027vol_type\u0027: volume.volume_type[\u0027id\u0027]})"},{"line_number":354,"context_line":"            LOG.error(msg)"},{"line_number":355,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":356,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_677736a0","line":353,"range":{"start_line":353,"start_character":60,"end_line":353,"end_character":77},"in_reply_to":"5a74a57a_b384380b","updated":"2016-11-28 16:08:32.000000000","message":"Done","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"}],"cinder/volume/drivers/hitachi/hnas_nfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"acab56361c424726954a5f776337daca94c726ed","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        if (pool_from_vol_type \u003d\u003d \u0027default\u0027 and"},{"line_number":574,"context_line":"                \u0027default\u0027 not in self.config[\u0027services\u0027]):"},{"line_number":575,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the chosen \""},{"line_number":576,"context_line":"                     \"volume type does not have a service_label configured in \""},{"line_number":577,"context_line":"                     \"its extra-specs and there is no pool configured with \""},{"line_number":578,"context_line":"                     \"hnas_svcX_volume_type as \u0027default\u0027 in cinder.conf.\"))"},{"line_number":579,"context_line":"            LOG.error(msg)"},{"line_number":580,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_f63f7eb1","line":578,"range":{"start_line":575,"start_character":0,"end_line":578,"end_character":75},"updated":"2016-11-28 15:06:13.000000000","message":"-1: Any reason not to be consistent with the error we raise in hnas_iscsi?","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"6ca1bb54ee8504a7bb911bc406ccfae23eaad38f","unresolved":false,"context_lines":[{"line_number":572,"context_line":""},{"line_number":573,"context_line":"        if (pool_from_vol_type \u003d\u003d \u0027default\u0027 and"},{"line_number":574,"context_line":"                \u0027default\u0027 not in self.config[\u0027services\u0027]):"},{"line_number":575,"context_line":"            msg \u003d (_(\"Failed to manage existing volume because the chosen \""},{"line_number":576,"context_line":"                     \"volume type does not have a service_label configured in \""},{"line_number":577,"context_line":"                     \"its extra-specs and there is no pool configured with \""},{"line_number":578,"context_line":"                     \"hnas_svcX_volume_type as \u0027default\u0027 in cinder.conf.\"))"},{"line_number":579,"context_line":"            LOG.error(msg)"},{"line_number":580,"context_line":"            raise exception.ManageExistingVolumeTypeMismatch(reason\u003dmsg)"},{"line_number":581,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a74a57a_87d6124d","line":578,"range":{"start_line":575,"start_character":0,"end_line":578,"end_character":75},"in_reply_to":"5a74a57a_f63f7eb1","updated":"2016-11-28 16:08:32.000000000","message":"I don\u0027t think so.\nI\u0027m making them consistent.","commit_id":"ceb0c59cbbff4ee0ae332b5becb614c3bf12f117"}],"cinder/volume/drivers/hitachi/hnas_utils.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a43039d21486c8152956022f6d783cd4835be279","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\"Validates if the configuration on cinder.conf is complete."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    :param config: Dictionary with the driver configurations"},{"line_number":93,"context_line":"    :param vol_type: The volume type of the current pool"},{"line_number":94,"context_line":"    :param dv_type: The type of the driver (NFS or iSCSI)"},{"line_number":95,"context_line":"    :param idx: Index of the current pool"},{"line_number":96,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_e348475e","line":93,"range":{"start_line":93,"start_character":11,"end_line":93,"end_character":19},"updated":"2016-10-11 11:03:36.000000000","message":"pool_name","commit_id":"1011bbd7c13328cfc286e19ab3c74d76e0d23a38"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"8bf25541ee6af308bb45a1320ceeb1c066481592","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    \"\"\"Validates if the configuration on cinder.conf is complete."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    :param config: Dictionary with the driver configurations"},{"line_number":93,"context_line":"    :param vol_type: The volume type of the current pool"},{"line_number":94,"context_line":"    :param dv_type: The type of the driver (NFS or iSCSI)"},{"line_number":95,"context_line":"    :param idx: Index of the current pool"},{"line_number":96,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_a549ec8d","line":93,"range":{"start_line":93,"start_character":11,"end_line":93,"end_character":19},"in_reply_to":"fa6399be_e348475e","updated":"2016-10-11 14:08:32.000000000","message":"Done","commit_id":"1011bbd7c13328cfc286e19ab3c74d76e0d23a38"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"485da02765969525d86f864741e6a033514848ec","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        service \u003d {\u0027label\u0027: svc}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # none optional"},{"line_number":246,"context_line":"        for arg in svc_params:"},{"line_number":247,"context_line":"            # Since the XML configuration file deprecated, we are treating"},{"line_number":248,"context_line":"            # this case separately, so we don\u0027t have to change the XML tag."},{"line_number":249,"context_line":"            if arg \u003d\u003d \u0027volume_type\u0027:"},{"line_number":250,"context_line":"                service[\u0027pool_name\u0027] \u003d _xml_read("},{"line_number":251,"context_line":"                    root, svc + \u0027/\u0027 + arg, \u0027check\u0027)"},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                service[arg] \u003d _xml_read(root, svc + \u0027/\u0027 + arg, \u0027check\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        config[\u0027services\u0027][service[\u0027pool_name\u0027]] \u003d service"},{"line_number":256,"context_line":"        config[\u0027fs\u0027][service[\u0027hdp\u0027]] \u003d service[\u0027hdp\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_797ce372","line":253,"range":{"start_line":246,"start_character":0,"end_line":253,"end_character":72},"updated":"2016-11-23 14:05:37.000000000","message":"nit: I think this is more readable:\n\n for arg in svc_params:\n     service[arg] \u003d _xml_read(root, svc + \u0027/\u0027 + arg, \u0027check\u0027)\n # Backward compatibility with volume_type\n service.setdefault(\u0027pool_name\u0027, service.pop(\u0027volume_type\u0027, None))","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"},{"author":{"_account_id":14865,"name":"Adriano Freires Rosso","email":"adriano.rosso@fit-tecnologia.org.br","username":"adriano_rosso"},"change_message_id":"91d07e8c94e53c1d7567cfc7686e378deec2b586","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        service \u003d {\u0027label\u0027: svc}"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # none optional"},{"line_number":246,"context_line":"        for arg in svc_params:"},{"line_number":247,"context_line":"            # Since the XML configuration file deprecated, we are treating"},{"line_number":248,"context_line":"            # this case separately, so we don\u0027t have to change the XML tag."},{"line_number":249,"context_line":"            if arg \u003d\u003d \u0027volume_type\u0027:"},{"line_number":250,"context_line":"                service[\u0027pool_name\u0027] \u003d _xml_read("},{"line_number":251,"context_line":"                    root, svc + \u0027/\u0027 + arg, \u0027check\u0027)"},{"line_number":252,"context_line":"            else:"},{"line_number":253,"context_line":"                service[arg] \u003d _xml_read(root, svc + \u0027/\u0027 + arg, \u0027check\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        config[\u0027services\u0027][service[\u0027pool_name\u0027]] \u003d service"},{"line_number":256,"context_line":"        config[\u0027fs\u0027][service[\u0027hdp\u0027]] \u003d service[\u0027hdp\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_47ed2324","line":253,"range":{"start_line":246,"start_character":0,"end_line":253,"end_character":72},"in_reply_to":"5a74a57a_797ce372","updated":"2016-11-28 12:23:48.000000000","message":"Done","commit_id":"5a2024c87573597300784f8c5761edd0a21c46bc"}],"releasenotes/notes/hnas-deprecated-svc-volume-type-77768f27946aadf4.yaml":[{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"da7d4990863e870420ee0364a6b65648fcd1361b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated the configuration option ``hnas_svcX_volume_type``. Use option"},{"line_number":4,"context_line":"    ``hnas_svcX_pool_name`` to indicate the name of the services (pools)."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a95cdbc_87d992f5","line":2,"updated":"2016-10-10 11:13:32.000000000","message":"I think we also need the upgrade section.","commit_id":"1011bbd7c13328cfc286e19ab3c74d76e0d23a38"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"a43039d21486c8152956022f6d783cd4835be279","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated the configuration option ``hnas_svcX_volume_type``. Use option"},{"line_number":4,"context_line":"    ``hnas_svcX_pool_name`` to indicate the name of the services (pools)."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_e35f670c","line":2,"in_reply_to":"1a95cdbc_87d992f5","updated":"2016-10-11 11:03:36.000000000","message":"Why the upgrade? There\u0027s no functionality being added.","commit_id":"1011bbd7c13328cfc286e19ab3c74d76e0d23a38"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"84fea62fbaf1d7ffeeed9748ee32ef90e3070697","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecated the configuration option ``hnas_svcX_volume_type``. Use option"},{"line_number":4,"context_line":"    ``hnas_svcX_pool_name`` to indicate the name of the services (pools)."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fa6399be_126aa0b3","line":2,"in_reply_to":"fa6399be_e35f670c","updated":"2016-10-12 17:41:26.000000000","message":"See http://docs.openstack.org/developer/cinder/devref/releasenotes.html\n\nI\u0027m confused with the second point under \u0027upgrades\u0027.\n\nAlso see\nhttps://review.openstack.org/#/c/367937/6/releasenotes/notes/vnx-new-driver-7e96934c2d3a6edc.yaml\n\n\nSince the new options are clearly mentioned here, I\u0027m fine skipping the upgrade section.","commit_id":"1011bbd7c13328cfc286e19ab3c74d76e0d23a38"}]}